Browse Source

Use Assert.Single()/Empty() instead of Assert.Equal()

pull/429/head
Kévin Chalet 9 years ago
parent
commit
f68fad8f01
  1. 2
      test/OpenIddict.Tests/OpenIddictProviderTests.Authentication.cs
  2. 2
      test/OpenIddict.Tests/OpenIddictProviderTests.Discovery.cs
  3. 6
      test/OpenIddict.Tests/OpenIddictProviderTests.Introspection.cs
  4. 4
      test/OpenIddict.Tests/OpenIddictProviderTests.Revocation.cs
  5. 2
      test/OpenIddict.Tests/OpenIddictProviderTests.Session.cs

2
test/OpenIddict.Tests/OpenIddictProviderTests.Authentication.cs

@ -515,7 +515,7 @@ namespace OpenIddict.Tests
var identifier = (string) response[OpenIdConnectConstants.Parameters.RequestId]; var identifier = (string) response[OpenIdConnectConstants.Parameters.RequestId];
// Assert // Assert
Assert.Equal(1, response.GetParameters().Count()); Assert.Single(response.GetParameters());
Assert.NotNull(identifier); Assert.NotNull(identifier);
cache.Verify(mock => mock.SetAsync( cache.Verify(mock => mock.SetAsync(

2
test/OpenIddict.Tests/OpenIddictProviderTests.Discovery.cs

@ -56,7 +56,7 @@ namespace OpenIddict.Tests
var types = ((JArray) response[OpenIdConnectConstants.Metadata.GrantTypesSupported]).Values<string>(); var types = ((JArray) response[OpenIdConnectConstants.Metadata.GrantTypesSupported]).Values<string>();
// Assert // Assert
Assert.Equal(1, types.Count()); Assert.Single(types);
Assert.Contains(flow, types); Assert.Contains(flow, types);
} }

6
test/OpenIddict.Tests/OpenIddictProviderTests.Introspection.cs

@ -224,7 +224,7 @@ namespace OpenIddict.Tests
}); });
// Assert // Assert
Assert.Equal(1, response.GetParameters().Count()); Assert.Single(response.GetParameters());
Assert.False((bool) response[OpenIdConnectConstants.Claims.Active]); Assert.False((bool) response[OpenIdConnectConstants.Claims.Active]);
} }
@ -398,7 +398,7 @@ namespace OpenIddict.Tests
}); });
// Assert // Assert
Assert.Equal(1, response.GetParameters().Count()); Assert.Single(response.GetParameters());
Assert.False((bool) response[OpenIdConnectConstants.Claims.Active]); Assert.False((bool) response[OpenIdConnectConstants.Claims.Active]);
Mock.Get(manager).Verify(mock => mock.FindByIdAsync("3E228451-1555-46F7-A471-951EFBA23A56", It.IsAny<CancellationToken>()), Times.Once()); Mock.Get(manager).Verify(mock => mock.FindByIdAsync("3E228451-1555-46F7-A471-951EFBA23A56", It.IsAny<CancellationToken>()), Times.Once());
@ -462,7 +462,7 @@ namespace OpenIddict.Tests
}); });
// Assert // Assert
Assert.Equal(1, response.GetParameters().Count()); Assert.Single(response.GetParameters());
Assert.False((bool) response[OpenIdConnectConstants.Claims.Active]); Assert.False((bool) response[OpenIdConnectConstants.Claims.Active]);
Mock.Get(manager).Verify(mock => mock.FindByIdAsync("3E228451-1555-46F7-A471-951EFBA23A56", It.IsAny<CancellationToken>()), Times.Once()); Mock.Get(manager).Verify(mock => mock.FindByIdAsync("3E228451-1555-46F7-A471-951EFBA23A56", It.IsAny<CancellationToken>()), Times.Once());

4
test/OpenIddict.Tests/OpenIddictProviderTests.Revocation.cs

@ -336,7 +336,7 @@ namespace OpenIddict.Tests
}); });
// Assert // Assert
Assert.Equal(0, response.GetParameters().Count()); Assert.Empty(response.GetParameters());
Mock.Get(manager).Verify(mock => mock.FindByIdAsync("3E228451-1555-46F7-A471-951EFBA23A56", It.IsAny<CancellationToken>()), Times.Once()); Mock.Get(manager).Verify(mock => mock.FindByIdAsync("3E228451-1555-46F7-A471-951EFBA23A56", It.IsAny<CancellationToken>()), Times.Once());
Mock.Get(manager).Verify(mock => mock.RevokeAsync(It.IsAny<OpenIddictToken>(), It.IsAny<CancellationToken>()), Times.Never()); Mock.Get(manager).Verify(mock => mock.RevokeAsync(It.IsAny<OpenIddictToken>(), It.IsAny<CancellationToken>()), Times.Never());
@ -382,7 +382,7 @@ namespace OpenIddict.Tests
}); });
// Assert // Assert
Assert.Equal(0, response.GetParameters().Count()); Assert.Empty(response.GetParameters());
Mock.Get(manager).Verify(mock => mock.FindByIdAsync("3E228451-1555-46F7-A471-951EFBA23A56", It.IsAny<CancellationToken>()), Times.Once()); Mock.Get(manager).Verify(mock => mock.FindByIdAsync("3E228451-1555-46F7-A471-951EFBA23A56", It.IsAny<CancellationToken>()), Times.Once());
Mock.Get(manager).Verify(mock => mock.RevokeAsync(token, It.IsAny<CancellationToken>()), Times.Once()); Mock.Get(manager).Verify(mock => mock.RevokeAsync(token, It.IsAny<CancellationToken>()), Times.Once());

2
test/OpenIddict.Tests/OpenIddictProviderTests.Session.cs

@ -120,7 +120,7 @@ namespace OpenIddict.Tests
var identifier = (string) response[OpenIdConnectConstants.Parameters.RequestId]; var identifier = (string) response[OpenIdConnectConstants.Parameters.RequestId];
// Assert // Assert
Assert.Equal(1, response.GetParameters().Count()); Assert.Single(response.GetParameters());
Assert.NotNull(identifier); Assert.NotNull(identifier);
cache.Verify(mock => mock.SetAsync( cache.Verify(mock => mock.SetAsync(

Loading…
Cancel
Save