Browse Source

Update the MapNonStandardResponseParameters userinfo handler to avoid using OpenIddictParameter.GetNamedParameters()

pull/2308/head
Kévin Chalet 9 months ago
parent
commit
f8553a9ee7
  1. 2
      sandbox/OpenIddict.Sandbox.AspNetCore.Server/Controllers/AuthorizationController.cs
  2. 1
      sandbox/OpenIddict.Sandbox.Maui.Client/MauiProgram.cs
  3. 3
      src/OpenIddict.Abstractions/Descriptors/OpenIddictApplicationDescriptor.cs
  4. 1
      src/OpenIddict.Client.SystemIntegration/OpenIddictClientSystemIntegrationHandlerFilters.cs
  5. 2
      src/OpenIddict.Client.SystemIntegration/OpenIddictClientSystemIntegrationHandlers.Authentication.cs
  6. 2
      src/OpenIddict.Client.SystemIntegration/OpenIddictClientSystemIntegrationHandlers.Session.cs
  7. 2
      src/OpenIddict.Client.SystemIntegration/OpenIddictClientSystemIntegrationService.cs
  8. 4
      src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpHandlers.Exchange.cs
  9. 4
      src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpHandlers.Introspection.cs
  10. 4
      src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpHandlers.Revocation.cs
  11. 1
      src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpHandlers.cs
  12. 8
      src/OpenIddict.Client.WebIntegration/OpenIddictClientWebIntegrationHandlers.Userinfo.cs
  13. 2
      src/OpenIddict.Client/OpenIddictClientBuilder.cs
  14. 2
      src/OpenIddict.Client/OpenIddictClientEvents.Revocation.cs
  15. 1
      src/OpenIddict.Client/OpenIddictClientHandlers.Discovery.cs
  16. 2
      src/OpenIddict.Core/OpenIddictCoreOptions.cs
  17. 1
      src/OpenIddict.MongoDb.Models/OpenIddictMongoDbAuthorization.cs
  18. 2
      src/OpenIddict.Server/OpenIddictServerBuilder.cs
  19. 1
      src/OpenIddict.Server/OpenIddictServerEvents.Userinfo.cs
  20. 8
      src/OpenIddict.Server/OpenIddictServerHandlers.Authentication.cs
  21. 2
      src/OpenIddict.Server/OpenIddictServerHandlers.Device.cs
  22. 2
      src/OpenIddict.Server/OpenIddictServerHandlers.Exchange.cs
  23. 2
      src/OpenIddict.Server/OpenIddictServerHandlers.Protection.cs
  24. 2
      src/OpenIddict.Server/OpenIddictServerHandlers.Session.cs
  25. 16
      src/OpenIddict.Server/OpenIddictServerHandlers.cs
  26. 2
      src/OpenIddict.Validation/OpenIddictValidationBuilder.cs
  27. 1
      test/OpenIddict.Abstractions.Tests/Primitives/OpenIddictParameterTests.cs
  28. 1
      test/OpenIddict.MongoDb.Tests/OpenIddictMongoDbBuilderTests.cs
  29. 2
      test/OpenIddict.MongoDb.Tests/OpenIddictMongoDbExtensionsTests.cs
  30. 1
      test/OpenIddict.Validation.IntegrationTests/OpenIddictValidationIntegrationTestClient.cs

2
sandbox/OpenIddict.Sandbox.AspNetCore.Server/Controllers/AuthorizationController.cs

@ -4,14 +4,12 @@
* the license and the contributors participating to this project.
*/
using System.Collections.Immutable;
using System.Security.Claims;
using Microsoft.AspNetCore;
using Microsoft.AspNetCore.Authentication;
using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Identity;
using Microsoft.AspNetCore.Mvc;
using Microsoft.Extensions.Primitives;
using Microsoft.IdentityModel.Tokens;
using OpenIddict.Abstractions;
using OpenIddict.Client;

1
sandbox/OpenIddict.Sandbox.Maui.Client/MauiProgram.cs

@ -1,5 +1,4 @@
#if IOS || MACCATALYST || WINDOWS
using System.Net.Http;
using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.Hosting;
using Microsoft.Extensions.Hosting.Internal;

3
src/OpenIddict.Abstractions/Descriptors/OpenIddictApplicationDescriptor.cs

@ -1,5 +1,4 @@
using System.ComponentModel;
using System.Globalization;
using System.Globalization;
using System.Text.Json;
using Microsoft.IdentityModel.Tokens;

1
src/OpenIddict.Client.SystemIntegration/OpenIddictClientSystemIntegrationHandlerFilters.cs

@ -5,7 +5,6 @@
*/
using System.ComponentModel;
using System.Runtime.CompilerServices;
using Microsoft.Extensions.Options;
using static OpenIddict.Client.SystemIntegration.OpenIddictClientSystemIntegrationAuthenticationMode;

2
src/OpenIddict.Client.SystemIntegration/OpenIddictClientSystemIntegrationHandlers.Authentication.cs

@ -9,7 +9,6 @@ using System.Diagnostics;
using System.Runtime.InteropServices;
using System.Runtime.Versioning;
using System.Text;
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Primitives;
using OpenIddict.Extensions;
@ -24,6 +23,7 @@ using AndroidX.Browser.CustomTabs;
#if SUPPORTS_AUTHENTICATION_SERVICES
using AuthenticationServices;
using Microsoft.Extensions.Logging;
#endif
#if SUPPORTS_APPKIT

2
src/OpenIddict.Client.SystemIntegration/OpenIddictClientSystemIntegrationHandlers.Session.cs

@ -9,7 +9,6 @@ using System.Diagnostics;
using System.Runtime.InteropServices;
using System.Runtime.Versioning;
using System.Text;
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Primitives;
using OpenIddict.Extensions;
@ -24,6 +23,7 @@ using AndroidX.Browser.CustomTabs;
#if SUPPORTS_AUTHENTICATION_SERVICES
using AuthenticationServices;
using Microsoft.Extensions.Logging;
#endif
#if SUPPORTS_APPKIT

2
src/OpenIddict.Client.SystemIntegration/OpenIddictClientSystemIntegrationService.cs

@ -10,10 +10,10 @@ using System.Net;
using System.Security.Principal;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Options;
using OpenIddict.Extensions;
#if SUPPORTS_ANDROID
using Android.Content;
using OpenIddict.Extensions;
#endif
namespace OpenIddict.Client.SystemIntegration;

4
src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpHandlers.Exchange.cs

@ -5,10 +5,6 @@
*/
using System.Collections.Immutable;
using System.Diagnostics;
using System.Net.Http;
using System.Net.Http.Headers;
using System.Text;
namespace OpenIddict.Client.SystemNetHttp;

4
src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpHandlers.Introspection.cs

@ -5,10 +5,6 @@
*/
using System.Collections.Immutable;
using System.Diagnostics;
using System.Net.Http;
using System.Net.Http.Headers;
using System.Text;
namespace OpenIddict.Client.SystemNetHttp;

4
src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpHandlers.Revocation.cs

@ -5,10 +5,6 @@
*/
using System.Collections.Immutable;
using System.Diagnostics;
using System.Net.Http;
using System.Net.Http.Headers;
using System.Text;
namespace OpenIddict.Client.SystemNetHttp;

1
src/OpenIddict.Client.SystemNetHttp/OpenIddictClientSystemNetHttpHandlers.cs

@ -11,7 +11,6 @@ using System.IO.Compression;
using System.Net.Http;
using System.Net.Http.Headers;
using System.Runtime.InteropServices;
using System.Security.Cryptography.X509Certificates;
using System.Text;
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Options;

8
src/OpenIddict.Client.WebIntegration/OpenIddictClientWebIntegrationHandlers.Userinfo.cs

@ -511,12 +511,12 @@ public static partial class OpenIddictClientWebIntegrationHandlers
// Note: Clever returns a non-standard "name" claim formatted as a JSON object.
else if (context.Registration.ProviderType is ProviderTypes.Clever)
{
var name = context.Response[Claims.Name]?.GetNamedParameters();
var name = context.Response[Claims.Name];
if (name is not null)
{
context.Response[Claims.Name] = $"{name["first"]} {name["last"]}";
context.Response[Claims.FamilyName] = name["last"];
context.Response[Claims.GivenName] = name["first"];
context.Response[Claims.Name] = $"{name?["first"]} {name?["last"]}";
context.Response[Claims.FamilyName] = name?["last"];
context.Response[Claims.GivenName] = name?["first"];
}
}

2
src/OpenIddict.Client/OpenIddictClientBuilder.cs

@ -45,7 +45,7 @@ public sealed class OpenIddictClientBuilder
[EditorBrowsable(EditorBrowsableState.Advanced)]
public OpenIddictClientBuilder AddEventHandler<TContext>(
Action<OpenIddictClientHandlerDescriptor.Builder<TContext>> configuration)
where TContext : OpenIddictClientEvents.BaseContext
where TContext : BaseContext
{
if (configuration is null)
{

2
src/OpenIddict.Client/OpenIddictClientEvents.Revocation.cs

@ -4,8 +4,6 @@
* the license and the contributors participating to this project.
*/
using System.Security.Claims;
namespace OpenIddict.Client;
public static partial class OpenIddictClientEvents

1
src/OpenIddict.Client/OpenIddictClientHandlers.Discovery.cs

@ -5,7 +5,6 @@
*/
using System.Collections.Immutable;
using System.Reflection;
using System.Text.Json;
using Microsoft.Extensions.Logging;
using Microsoft.IdentityModel.Tokens;

2
src/OpenIddict.Core/OpenIddictCoreOptions.cs

@ -4,8 +4,6 @@
* the license and the contributors participating to this project.
*/
using System.Diagnostics.CodeAnalysis;
namespace OpenIddict.Core;
/// <summary>

1
src/OpenIddict.MongoDb.Models/OpenIddictMongoDbAuthorization.cs

@ -4,7 +4,6 @@
* the license and the contributors participating to this project.
*/
using System.Collections.Immutable;
using System.Diagnostics;
namespace OpenIddict.MongoDb.Models;

2
src/OpenIddict.Server/OpenIddictServerBuilder.cs

@ -45,7 +45,7 @@ public sealed class OpenIddictServerBuilder
[EditorBrowsable(EditorBrowsableState.Advanced)]
public OpenIddictServerBuilder AddEventHandler<TContext>(
Action<OpenIddictServerHandlerDescriptor.Builder<TContext>> configuration)
where TContext : OpenIddictServerEvents.BaseContext
where TContext : BaseContext
{
if (configuration is null)
{

1
src/OpenIddict.Server/OpenIddictServerEvents.Userinfo.cs

@ -5,7 +5,6 @@
*/
using System.Security.Claims;
using System.Text.Json;
using System.Text.Json.Nodes;
namespace OpenIddict.Server;

8
src/OpenIddict.Server/OpenIddictServerHandlers.Authentication.cs

@ -1290,7 +1290,7 @@ public static partial class OpenIddictServerHandlers
/// </summary>
public static OpenIddictServerHandlerDescriptor Descriptor { get; }
= OpenIddictServerHandlerDescriptor.CreateBuilder<ValidateAuthorizationRequestContext>()
.UseScopedHandler<ValidateResponseType>(static provider =>
.UseScopedHandler(static provider =>
{
// Note: the application manager is only resolved if the degraded mode was not enabled to ensure
// invalid core configuration exceptions are not thrown even if the managers were registered.
@ -1462,7 +1462,7 @@ public static partial class OpenIddictServerHandlers
public static OpenIddictServerHandlerDescriptor Descriptor { get; }
= OpenIddictServerHandlerDescriptor.CreateBuilder<ValidateAuthorizationRequestContext>()
.AddFilter<RequireScopeValidationEnabled>()
.UseScopedHandler<ValidateScopes>(static provider =>
.UseScopedHandler(static provider =>
{
// Note: the scope manager is only resolved if the degraded mode was not enabled to ensure
// invalid core configuration exceptions are not thrown even if the managers were registered.
@ -3247,7 +3247,7 @@ public static partial class OpenIddictServerHandlers
/// </summary>
public static OpenIddictServerHandlerDescriptor Descriptor { get; }
= OpenIddictServerHandlerDescriptor.CreateBuilder<ValidatePushedAuthorizationRequestContext>()
.UseScopedHandler<ValidatePushedResponseType>(static provider =>
.UseScopedHandler(static provider =>
{
// Note: the application manager is only resolved if the degraded mode was not enabled to ensure
// invalid core configuration exceptions are not thrown even if the managers were registered.
@ -3419,7 +3419,7 @@ public static partial class OpenIddictServerHandlers
public static OpenIddictServerHandlerDescriptor Descriptor { get; }
= OpenIddictServerHandlerDescriptor.CreateBuilder<ValidatePushedAuthorizationRequestContext>()
.AddFilter<RequireScopeValidationEnabled>()
.UseScopedHandler<ValidatePushedScopes>(static provider =>
.UseScopedHandler(static provider =>
{
// Note: the scope manager is only resolved if the degraded mode was not enabled to ensure
// invalid core configuration exceptions are not thrown even if the managers were registered.

2
src/OpenIddict.Server/OpenIddictServerHandlers.Device.cs

@ -466,7 +466,7 @@ public static partial class OpenIddictServerHandlers
public static OpenIddictServerHandlerDescriptor Descriptor { get; }
= OpenIddictServerHandlerDescriptor.CreateBuilder<ValidateDeviceAuthorizationRequestContext>()
.AddFilter<RequireScopeValidationEnabled>()
.UseScopedHandler<ValidateScopes>(static provider =>
.UseScopedHandler(static provider =>
{
// Note: the scope manager is only resolved if the degraded mode was not enabled to ensure
// invalid core configuration exceptions are not thrown even if the managers were registered.

2
src/OpenIddict.Server/OpenIddictServerHandlers.Exchange.cs

@ -837,7 +837,7 @@ public static partial class OpenIddictServerHandlers
public static OpenIddictServerHandlerDescriptor Descriptor { get; }
= OpenIddictServerHandlerDescriptor.CreateBuilder<ValidateTokenRequestContext>()
.AddFilter<RequireScopeValidationEnabled>()
.UseScopedHandler<ValidateScopes>(static provider =>
.UseScopedHandler(static provider =>
{
// Note: the scope manager is only resolved if the degraded mode was not enabled to ensure
// invalid core configuration exceptions are not thrown even if the managers were registered.

2
src/OpenIddict.Server/OpenIddictServerHandlers.Protection.cs

@ -64,7 +64,7 @@ public static partial class OpenIddictServerHandlers
/// </summary>
public static OpenIddictServerHandlerDescriptor Descriptor { get; }
= OpenIddictServerHandlerDescriptor.CreateBuilder<ValidateTokenContext>()
.UseScopedHandler<ResolveTokenValidationParameters>(static provider =>
.UseScopedHandler(static provider =>
{
// Note: the application manager is only resolved if the degraded mode was not enabled to ensure
// invalid core configuration exceptions are not thrown even if the managers were registered.

2
src/OpenIddict.Server/OpenIddictServerHandlers.Session.cs

@ -797,7 +797,7 @@ public static partial class OpenIddictServerHandlers
/// </summary>
public static OpenIddictServerHandlerDescriptor Descriptor { get; }
= OpenIddictServerHandlerDescriptor.CreateBuilder<ValidateEndSessionRequestContext>()
.UseScopedHandler<ValidateAuthorizedParty>(static provider =>
.UseScopedHandler(static provider =>
{
// Note: the application manager is only resolved if the degraded mode was not enabled to ensure
// invalid core configuration exceptions are not thrown even if the managers were registered.

16
src/OpenIddict.Server/OpenIddictServerHandlers.cs

@ -1015,7 +1015,7 @@ public static partial class OpenIddictServerHandlers
/// </summary>
public static OpenIddictServerHandlerDescriptor Descriptor { get; }
= OpenIddictServerHandlerDescriptor.CreateBuilder<ProcessAuthenticationContext>()
.UseScopedHandler<ValidateClientId>(static provider =>
.UseScopedHandler(static provider =>
{
// Note: the application manager is only resolved if the degraded mode was not enabled to ensure
// invalid core configuration exceptions are not thrown even if the managers were registered.
@ -3065,7 +3065,7 @@ public static partial class OpenIddictServerHandlers
public static OpenIddictServerHandlerDescriptor Descriptor { get; }
= OpenIddictServerHandlerDescriptor.CreateBuilder<ProcessSignInContext>()
.AddFilter<RequireAccessTokenGenerated>()
.UseScopedHandler<PrepareAccessTokenPrincipal>(static provider =>
.UseScopedHandler(static provider =>
{
// Note: the application manager is only resolved if the degraded mode was not enabled to ensure
// invalid core configuration exceptions are not thrown even if the managers were registered.
@ -3223,7 +3223,7 @@ public static partial class OpenIddictServerHandlers
public static OpenIddictServerHandlerDescriptor Descriptor { get; }
= OpenIddictServerHandlerDescriptor.CreateBuilder<ProcessSignInContext>()
.AddFilter<RequireAuthorizationCodeGenerated>()
.UseScopedHandler<PrepareAuthorizationCodePrincipal>(static provider =>
.UseScopedHandler(static provider =>
{
// Note: the application manager is only resolved if the degraded mode was not enabled to ensure
// invalid core configuration exceptions are not thrown even if the managers were registered.
@ -3349,7 +3349,7 @@ public static partial class OpenIddictServerHandlers
public static OpenIddictServerHandlerDescriptor Descriptor { get; }
= OpenIddictServerHandlerDescriptor.CreateBuilder<ProcessSignInContext>()
.AddFilter<RequireDeviceCodeGenerated>()
.UseScopedHandler<PrepareDeviceCodePrincipal>(static provider =>
.UseScopedHandler(static provider =>
{
// Note: the application manager is only resolved if the degraded mode was not enabled to ensure
// invalid core configuration exceptions are not thrown even if the managers were registered.
@ -3462,7 +3462,7 @@ public static partial class OpenIddictServerHandlers
public static OpenIddictServerHandlerDescriptor Descriptor { get; }
= OpenIddictServerHandlerDescriptor.CreateBuilder<ProcessSignInContext>()
.AddFilter<RequireRequestTokenGenerated>()
.UseScopedHandler<PrepareRequestTokenPrincipal>(static provider =>
.UseScopedHandler(static provider =>
{
// Note: the application manager is only resolved if the degraded mode was not enabled to ensure
// invalid core configuration exceptions are not thrown even if the managers were registered.
@ -3593,7 +3593,7 @@ public static partial class OpenIddictServerHandlers
public static OpenIddictServerHandlerDescriptor Descriptor { get; }
= OpenIddictServerHandlerDescriptor.CreateBuilder<ProcessSignInContext>()
.AddFilter<RequireRefreshTokenGenerated>()
.UseScopedHandler<PrepareRefreshTokenPrincipal>(static provider =>
.UseScopedHandler(static provider =>
{
// Note: the application manager is only resolved if the degraded mode was not enabled to ensure
// invalid core configuration exceptions are not thrown even if the managers were registered.
@ -3717,7 +3717,7 @@ public static partial class OpenIddictServerHandlers
public static OpenIddictServerHandlerDescriptor Descriptor { get; }
= OpenIddictServerHandlerDescriptor.CreateBuilder<ProcessSignInContext>()
.AddFilter<RequireIdentityTokenGenerated>()
.UseScopedHandler<PrepareIdentityTokenPrincipal>(static provider =>
.UseScopedHandler(static provider =>
{
// Note: the application manager is only resolved if the degraded mode was not enabled to ensure
// invalid core configuration exceptions are not thrown even if the managers were registered.
@ -3871,7 +3871,7 @@ public static partial class OpenIddictServerHandlers
public static OpenIddictServerHandlerDescriptor Descriptor { get; }
= OpenIddictServerHandlerDescriptor.CreateBuilder<ProcessSignInContext>()
.AddFilter<RequireUserCodeGenerated>()
.UseScopedHandler<PrepareUserCodePrincipal>(static provider =>
.UseScopedHandler(static provider =>
{
// Note: the application manager is only resolved if the degraded mode was not enabled to ensure
// invalid core configuration exceptions are not thrown even if the managers were registered.

2
src/OpenIddict.Validation/OpenIddictValidationBuilder.cs

@ -44,7 +44,7 @@ public sealed class OpenIddictValidationBuilder
[EditorBrowsable(EditorBrowsableState.Advanced)]
public OpenIddictValidationBuilder AddEventHandler<TContext>(
Action<OpenIddictValidationHandlerDescriptor.Builder<TContext>> configuration)
where TContext : OpenIddictValidationEvents.BaseContext
where TContext : BaseContext
{
if (configuration is null)
{

1
test/OpenIddict.Abstractions.Tests/Primitives/OpenIddictParameterTests.cs

@ -5,7 +5,6 @@
*/
using System.Collections.Immutable;
using System.Runtime.InteropServices;
using System.Text;
using System.Text.Json;
using System.Text.Json.Nodes;

1
test/OpenIddict.MongoDb.Tests/OpenIddictMongoDbBuilderTests.cs

@ -8,7 +8,6 @@ using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Options;
using MongoDB.Driver;
using Moq;
using OpenIddict.Core;
using OpenIddict.MongoDb.Models;
using Xunit;

2
test/OpenIddict.MongoDb.Tests/OpenIddictMongoDbExtensionsTests.cs

@ -5,8 +5,6 @@
*/
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Options;
using OpenIddict.Core;
using OpenIddict.MongoDb.Models;
using Xunit;

1
test/OpenIddict.Validation.IntegrationTests/OpenIddictValidationIntegrationTestClient.cs

@ -7,7 +7,6 @@
using System.Collections.Immutable;
using System.Net.Http;
using System.Net.Http.Json;
using System.Runtime.InteropServices;
using AngleSharp.Html.Parser;
using Microsoft.Extensions.Primitives;
using OpenIddict.Extensions;

Loading…
Cancel
Save