From ffb83f78785738919d2a3818037ef42c7ec06965 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?K=C3=A9vin=20Chalet?= Date: Wed, 21 Feb 2024 10:19:03 +0100 Subject: [PATCH] Remove the obsolete comment from OpenIddictClientOptions.CodeChallengeMethods's XML documentation --- src/OpenIddict.Client/OpenIddictClientOptions.cs | 9 ++++----- .../OpenIddictClientRegistration.cs | 16 ++++++++-------- 2 files changed, 12 insertions(+), 13 deletions(-) diff --git a/src/OpenIddict.Client/OpenIddictClientOptions.cs b/src/OpenIddict.Client/OpenIddictClientOptions.cs index 2d5685be..0e718f6e 100644 --- a/src/OpenIddict.Client/OpenIddictClientOptions.cs +++ b/src/OpenIddict.Client/OpenIddictClientOptions.cs @@ -138,7 +138,6 @@ public sealed class OpenIddictClientOptions /// /// Gets the OAuth 2.0 code challenge methods enabled for this application. - /// By default, only the S256 method is allowed (if the code flow is enabled). /// public HashSet CodeChallengeMethods { get; } = new(StringComparer.Ordinal); @@ -148,14 +147,14 @@ public sealed class OpenIddictClientOptions public HashSet GrantTypes { get; } = new(StringComparer.Ordinal); /// - /// Gets the OAuth 2.0/OpenID Connect response types enabled for this application. + /// Gets the OAuth 2.0/OpenID Connect response modes enabled for this application. /// [EditorBrowsable(EditorBrowsableState.Advanced)] - public HashSet ResponseTypes { get; } = new(StringComparer.Ordinal); + public HashSet ResponseModes { get; } = new(StringComparer.Ordinal); /// - /// Gets the OAuth 2.0/OpenID Connect response modes enabled for this application. + /// Gets the OAuth 2.0/OpenID Connect response types enabled for this application. /// [EditorBrowsable(EditorBrowsableState.Advanced)] - public HashSet ResponseModes { get; } = new(StringComparer.Ordinal); + public HashSet ResponseTypes { get; } = new(StringComparer.Ordinal); } diff --git a/src/OpenIddict.Client/OpenIddictClientRegistration.cs b/src/OpenIddict.Client/OpenIddictClientRegistration.cs index 1fbe91cb..eece0a6a 100644 --- a/src/OpenIddict.Client/OpenIddictClientRegistration.cs +++ b/src/OpenIddict.Client/OpenIddictClientRegistration.cs @@ -84,24 +84,24 @@ public sealed class OpenIddictClientRegistration public HashSet GrantTypes { get; } = new(StringComparer.Ordinal); /// - /// Gets the response type combinations allowed by the client instance. - /// If no value is explicitly set, all the types enabled in the client options can be used. + /// Gets the response modes allowed by the client instance. + /// If no value is explicitly set, all the modes enabled in the client options can be used. /// /// - /// The final response type used in authorization requests is chosen by OpenIddict based on + /// The final response method used in authorization requests is chosen by OpenIddict based on /// the client options, the server configuration and the values registered in this property. /// - public HashSet ResponseTypes { get; } = new(StringComparer.Ordinal); + public HashSet ResponseModes { get; } = new(StringComparer.Ordinal); /// - /// Gets the response modes allowed by the client instance. - /// If no value is explicitly set, all the modes enabled in the client options can be used. + /// Gets the response type combinations allowed by the client instance. + /// If no value is explicitly set, all the types enabled in the client options can be used. /// /// - /// The final response method used in authorization requests is chosen by OpenIddict based on + /// The final response type used in authorization requests is chosen by OpenIddict based on /// the client options, the server configuration and the values registered in this property. /// - public HashSet ResponseModes { get; } = new(StringComparer.Ordinal); + public HashSet ResponseTypes { get; } = new(StringComparer.Ordinal); /// /// Gets or sets the URI of the authorization server.