Readonly webhooks.

src/Squidex.Domain.Apps.Read/Apps/Services/Implementations/CachingAppProvider.cs

@@ -100,6 +100,7 @@ namespace Squidex.Domain.Apps.Read.Apps.Services.Implementations
             }
 
             if (@event.Payload is AppClientAttached ||
+                @event.Payload is AppClientChanged ||
                 @event.Payload is AppClientRenamed ||
                 @event.Payload is AppClientRevoked ||
                 @event.Payload is AppPlanChanged ||

src/Squidex.Domain.Apps.Write/Apps/AppDomainObject.cs

@@ -132,7 +132,7 @@ namespace Squidex.Domain.Apps.Write.Apps
 
         public AppDomainObject UpdateClient(UpdateClient command)
         {
-            Guard.Valid(command, nameof(command), () => "Cannot rename client");
+            Guard.Valid(command, nameof(command), () => "Cannot update client");
 
             ThrowIfNotCreated();
 

src/Squidex.Domain.Apps.Write/Apps/Commands/UpdateClient.cs

@@ -28,7 +28,7 @@ namespace Squidex.Domain.Apps.Write.Apps.Commands
 
             if (string.IsNullOrWhiteSpace(Name) && IsReader == null)
             {
-                errors.Add(new ValidationError("Either name or IsReader must be defined.", nameof(Name), nameof(IsReader)));
+                errors.Add(new ValidationError("Either name or reader state must be defined.", nameof(Name), nameof(IsReader)));
             }
         }
     }

src/Squidex/Controllers/Api/Apps/Models/ClientDto.cs

@@ -29,5 +29,11 @@ namespace Squidex.Controllers.Api.Apps.Models
         /// </summary>
         [Required]
         public string Name { get; set; }
+
+        /// <summary>
+        /// Determines if the client is a reader.
+        /// </summary>
+        [Required]
+        public bool IsReader { get; set; }
     }
 }

src/Squidex/Controllers/Api/Apps/Models/UpdateAppClientDto.cs

@@ -21,6 +21,6 @@ namespace Squidex.Controllers.Api.Apps.Models
         /// <summary>
         /// Determines if the client is a reader.
         /// </summary>
-        public bool IsReader { get; set; }
+        public bool? IsReader { get; set; }
     }
 }

src/Squidex/app/features/settings/pages/clients/client.component.html

@@ -66,6 +66,16 @@
                 </button>
             </td>
         </tr>
+        <tr>
+            <td></td>
+            <td>
+                <div class="form-check">
+                    <label class="form-check-label">
+                        <input type="checkbox" [ngModel]="client.isReader" (ngModelChange)="changing.emit($event)" /> Reading only
+                    </label>
+                </div>
+            </td>
+        </tr>
     </table>
 </div>
 

src/Squidex/app/features/settings/pages/clients/client.component.scss

@@ -70,6 +70,14 @@ $color-editor: #eceeef;
     padding: .4rem;
 }
 
+.form-check {
+    padding: .5rem 0 0;
+}
+
+.form-check-label {
+    padding: 0;
+}
+
 .access-token {
     height: 18rem;
     font-size: 1rem;

src/Squidex/app/features/settings/pages/clients/client.component.ts

@@ -38,6 +38,9 @@ export class ClientComponent {
     @Output()
     public revoking = new EventEmitter();
 
+    @Output()
+    public changing = new EventEmitter<boolean>();
+
     @Input()
     public client: AppClientDto;
 

src/Squidex/app/features/settings/pages/clients/clients-page.component.html

@@ -18,7 +18,8 @@
             </div>
 
             <div *ngFor="let client of appClients">
-                <sqx-client [client]="client" [appName]="appName() | async" 
+                <sqx-client [client]="client" [appName]="appName() | async"
+                    (changing)="changeClient(client, $event)"
                     (renaming)="renameClient(client, $event)" 
                     (revoking)="revokeClient(client)"></sqx-client>
             </div>

src/Squidex/app/features/settings/pages/clients/clients-page.component.ts

@@ -91,6 +91,18 @@ export class ClientsPageComponent extends AppComponentBase implements OnInit {
             });
     }
 
+    public changeClient(client: AppClientDto, isReader: boolean) {
+        const request = new UpdateAppClientDto(undefined, isReader);
+
+        this.appNameOnce()
+            .switchMap(app => this.appClientsService.updateClient(app, client.id, request, this.version))
+            .subscribe(() => {
+                this.updateClients(this.appClients.replace(client, change(client, isReader)));
+            }, error => {
+                this.notifyError(error);
+            });
+    }
+
     public resetClientForm() {
         this.addClientFormSubmitted = false;
         this.addClientForm.enable();
@@ -123,6 +135,10 @@ export class ClientsPageComponent extends AppComponentBase implements OnInit {
     }
 }
 
+function change(client: AppClientDto, isReader: boolean): AppClientDto {
+    return new AppClientDto(client.id, client.name, client.secret, isReader);
+};
+
 function rename(client: AppClientDto, name: string): AppClientDto {
-    return new AppClientDto(client.id, name, client.secret);
+    return new AppClientDto(client.id, name, client.secret, client.isReader);
 };

src/Squidex/app/features/webhooks/pages/webhooks-page.component.html

@@ -42,7 +42,7 @@
                                     </h3>
                                 </td>
                                 <td class="client-delete">
-                                    <button type="button" class="btn btn-link btn-danger" (click)="deleteWebhook(webhook)">
+                                    <button type="button" class="btn btn-link btn-danger" (click)="deleteWebhook(w)">
                                         <i class="icon-bin2"></i>
                                     </button>
                                 </td>

src/Squidex/app/features/webhooks/pages/webhooks-page.component.ts

@@ -86,6 +86,7 @@ export class WebhooksPageComponent extends AppComponentBase implements OnInit {
                 this.notifyError(error);
             });
     }
+
     public resetWebhookForm() {
         this.addWebhookFormSubmitted = false;
         this.addWebhookForm.enable();

src/Squidex/app/shared/services/app-clients.service.spec.ts

@@ -55,19 +55,21 @@ describe('AppClientsService', () => {
             {
                 id: 'client1',
                 name: 'Client 1',
-                secret: 'secret1'
+                secret: 'secret1',
+                isReader: true
             },
             {
                 id: 'client2',
                 name: 'Client 2',
-                secret: 'secret2'
+                secret: 'secret2',
+                isReader: true
             }
         ]);
 
         expect(clients).toEqual(
             [
-                new AppClientDto('client1', 'Client 1', 'secret1'),
-                new AppClientDto('client2', 'Client 2', 'secret2')
+                new AppClientDto('client1', 'Client 1', 'secret1', true),
+                new AppClientDto('client2', 'Client 2', 'secret2', true)
             ]);
     }));
 
@@ -87,10 +89,10 @@ describe('AppClientsService', () => {
         expect(req.request.method).toEqual('POST');
         expect(req.request.headers.get('If-Match')).toEqual('1');
 
-        req.flush({ id: 'client1', name: 'Client 1', secret: 'secret1' });
+        req.flush({ id: 'client1', name: 'Client 1', secret: 'secret1', isReader: true });
 
         expect(client).toEqual(
-            new AppClientDto('client1', 'Client 1', 'secret1'));
+            new AppClientDto('client1', 'Client 1', 'secret1', true));
     }));
 
     it('should make put request to rename client',
@@ -126,7 +128,7 @@ describe('AppClientsService', () => {
 
         let accessTokenDto: AccessTokenDto | null = null;
 
-        appClientsService.createToken('my-app', new AppClientDto('myClientId', 'myClient', 'mySecret')).subscribe(result => {
+        appClientsService.createToken('my-app', new AppClientDto('myClientId', 'myClient', 'mySecret', false)).subscribe(result => {
             accessTokenDto = result;
         });
 

src/Squidex/app/shared/services/app-clients.service.ts

@@ -21,7 +21,8 @@ export class AppClientDto {
     constructor(
         public readonly id: string,
         public readonly name: string,
-        public readonly secret: string
+        public readonly secret: string,
+        public readonly isReader: boolean
     ) {
     }
 }
@@ -35,7 +36,8 @@ export class CreateAppClientDto {
 
 export class UpdateAppClientDto {
     constructor(
-        public readonly name: string
+        public readonly name?: string,
+        public readonly isReader?: boolean
     ) {
     }
 }
@@ -67,7 +69,8 @@ export class AppClientsService {
                         return new AppClientDto(
                             item.id,
                             item.name,
-                            item.secret);
+                            item.secret,
+                            item.isReader);
                     });
                 })
                 .pretifyError('Failed to load clients. Please reload.');
@@ -81,7 +84,8 @@ export class AppClientsService {
                     return new AppClientDto(
                         response.id,
                         response.name,
-                        response.secret);
+                        response.secret,
+                        response.isReader);
                 })
                 .pretifyError('Failed to add client. Please reload.');
     }