From 0cc16d6ace8fa1a74b5feaf3dc3a0ce00de1896a Mon Sep 17 00:00:00 2001 From: Sebastian Stehle Date: Tue, 2 May 2017 21:03:34 +0200 Subject: [PATCH] Better logging --- src/Squidex/Controllers/Api/Assets/AssetContentController.cs | 2 +- src/Squidex/Pipeline/FileCallbackResultExecutor.cs | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/Squidex/Controllers/Api/Assets/AssetContentController.cs b/src/Squidex/Controllers/Api/Assets/AssetContentController.cs index efae49e6f..d8ac35e3e 100644 --- a/src/Squidex/Controllers/Api/Assets/AssetContentController.cs +++ b/src/Squidex/Controllers/Api/Assets/AssetContentController.cs @@ -47,7 +47,7 @@ namespace Squidex.Controllers.Api.Assets { var asset = await assetRepository.FindAssetAsync(id); - if (asset == null || asset.FileVersion < version) + if (asset == null || asset.FileVersion < version || width == 0 || height == 0) { return NotFound(); } diff --git a/src/Squidex/Pipeline/FileCallbackResultExecutor.cs b/src/Squidex/Pipeline/FileCallbackResultExecutor.cs index 70068424e..355d0f48c 100644 --- a/src/Squidex/Pipeline/FileCallbackResultExecutor.cs +++ b/src/Squidex/Pipeline/FileCallbackResultExecutor.cs @@ -6,6 +6,7 @@ // All rights reserved. // ========================================================================== +using System; using System.Threading.Tasks; using Microsoft.AspNetCore.Mvc; using Microsoft.AspNetCore.Mvc.Internal; @@ -28,8 +29,10 @@ namespace Squidex.Pipeline await result.Callback(context.HttpContext.Response.Body); } - catch + catch (Exception e) { + Logger.LogCritical(new EventId(99), e, "Failed to send result."); + context.HttpContext.Response.Headers.Clear(); context.HttpContext.Response.StatusCode = 404; }