From 319707a7a7323d470a7717b81fbc5a5a7a61e495 Mon Sep 17 00:00:00 2001 From: Sebastian Stehle Date: Sat, 27 Jan 2018 19:22:40 +0100 Subject: [PATCH] Unified the casting. --- .../HandleRules/Actions/AlgoliaActionHandler.cs | 12 ++++++------ .../HandleRules/Actions/WebhookActionHandler.cs | 4 ++-- .../Rules/Guards/Actions/AlgoliaActionTests.cs | 1 - 3 files changed, 8 insertions(+), 9 deletions(-) diff --git a/src/Squidex.Domain.Apps.Core.Operations/HandleRules/Actions/AlgoliaActionHandler.cs b/src/Squidex.Domain.Apps.Core.Operations/HandleRules/Actions/AlgoliaActionHandler.cs index 2d19a7278..0fdb5003c 100644 --- a/src/Squidex.Domain.Apps.Core.Operations/HandleRules/Actions/AlgoliaActionHandler.cs +++ b/src/Squidex.Domain.Apps.Core.Operations/HandleRules/Actions/AlgoliaActionHandler.cs @@ -87,9 +87,9 @@ namespace Squidex.Domain.Apps.Core.HandleRules.Actions public override async Task<(string Dump, Exception Exception)> ExecuteJobAsync(RuleJobData job) { - var appId = (string)job["AppId"]; - var apiKey = (string)job["ApiKey"]; - var indexName = (string)job["IndexName"]; + var appId = job["AppId"].Value(); + var apiKey = job["ApiKey"].Value(); + var indexName = job["IndexName"].Value(); var index = clients.GetOrAdd((appId, apiKey, indexName), s => { @@ -98,9 +98,9 @@ namespace Squidex.Domain.Apps.Core.HandleRules.Actions return client.InitIndex(indexName); }); - var operation = (string)job["Operation"]; - var content = (JObject)job["Content"]; - var contentId = (string)job["ContentId"]; + var operation = job["Operation"].Value(); + var content = job["Content"].Value(); + var contentId = job["ContentId"].Value(); try { diff --git a/src/Squidex.Domain.Apps.Core.Operations/HandleRules/Actions/WebhookActionHandler.cs b/src/Squidex.Domain.Apps.Core.Operations/HandleRules/Actions/WebhookActionHandler.cs index 8ccb20c5d..0400ef435 100644 --- a/src/Squidex.Domain.Apps.Core.Operations/HandleRules/Actions/WebhookActionHandler.cs +++ b/src/Squidex.Domain.Apps.Core.Operations/HandleRules/Actions/WebhookActionHandler.cs @@ -97,8 +97,8 @@ namespace Squidex.Domain.Apps.Core.HandleRules.Actions private static HttpRequestMessage BuildRequest(Dictionary job, string requestBody) { - var requestUrl = job["RequestUrl"].ToString(); - var requestSignature = job["RequestSignature"].ToString(); + var requestUrl = job["RequestUrl"].Value(); + var requestSignature = job["RequestSignature"].Value(); var request = new HttpRequestMessage(HttpMethod.Post, requestUrl) { diff --git a/tests/Squidex.Domain.Apps.Entities.Tests/Rules/Guards/Actions/AlgoliaActionTests.cs b/tests/Squidex.Domain.Apps.Entities.Tests/Rules/Guards/Actions/AlgoliaActionTests.cs index 156b055cc..570b1730c 100644 --- a/tests/Squidex.Domain.Apps.Entities.Tests/Rules/Guards/Actions/AlgoliaActionTests.cs +++ b/tests/Squidex.Domain.Apps.Entities.Tests/Rules/Guards/Actions/AlgoliaActionTests.cs @@ -5,7 +5,6 @@ // All rights reserved. Licensed under the MIT license. // ========================================================================== -using System; using System.Threading.Tasks; using Squidex.Domain.Apps.Core.Rules.Actions; using Xunit;