Browse Source

Removed dead code.

pull/282/head
Sebastian Stehle 9 years ago
parent
commit
32e81a33e4
  1. 41
      src/Squidex/app/shared/services/app-contributors.service.spec.ts
  2. 22
      src/Squidex/app/shared/services/app-contributors.service.ts

41
src/Squidex/app/shared/services/app-contributors.service.spec.ts

@ -18,47 +18,6 @@ import {
ContributorAssignedDto ContributorAssignedDto
} from './../'; } from './../';
describe('AppContributorsDto', () => {
const contributor1 = new AppContributorDto('1', 'Owner');
const contributor2 = new AppContributorDto('2', 'Developer');
const contributor2_new = new AppContributorDto('2', 'Editor');
const version = new Version('1');
const newVersion = new Version('2');
it('should update contributors when adding contributor', () => {
const contributors_1 = new AppContributorsDto([contributor1], 4, version);
const contributors_2 = contributors_1.addContributor(contributor2, newVersion);
expect(contributors_2.contributors).toEqual([contributor1, contributor2]);
expect(contributors_2.version).toEqual(newVersion);
});
it('should update contributors when removing contributor', () => {
const contributors_1 = new AppContributorsDto([contributor1, contributor2], 4, version);
const contributors_2 = contributors_1.removeContributor(contributor1, newVersion);
expect(contributors_2.contributors).toEqual([contributor2]);
expect(contributors_2.version).toEqual(newVersion);
});
it('should update contributors when updating contributor', () => {
const contributors_1 = new AppContributorsDto([contributor1, contributor2], 4, version);
const contributors_2 = contributors_1.updateContributor(contributor2_new, newVersion);
expect(contributors_2.contributors).toEqual([contributor1, contributor2_new]);
expect(contributors_2.version).toEqual(newVersion);
});
});
describe('AppContributorDto', () => {
it('should update permission property when changing', () => {
const contributor_1 = new AppContributorDto('1', 'Owner');
const contributor_2 = contributor_1.changePermission('Editor');
expect(contributor_2.permission).toBe('Editor');
});
});
describe('AppContributorsService', () => { describe('AppContributorsService', () => {
const version = new Version('1'); const version = new Version('1');

22
src/Squidex/app/shared/services/app-contributors.service.ts

@ -26,24 +26,6 @@ export class AppContributorsDto {
public readonly version: Version public readonly version: Version
) { ) {
} }
public addContributor(contributor: AppContributorDto, version: Version) {
return new AppContributorsDto([...this.contributors, contributor], this.maxContributors, version);
}
public updateContributor(contributor: AppContributorDto, version: Version) {
return new AppContributorsDto(
this.contributors.map(c => c.contributorId === contributor.contributorId ? contributor : c),
this.maxContributors,
version);
}
public removeContributor(contributor: AppContributorDto, version: Version) {
return new AppContributorsDto(
this.contributors.filter(c => c.contributorId !== contributor.contributorId),
this.maxContributors,
version);
}
} }
export class AppContributorDto { export class AppContributorDto {
@ -52,10 +34,6 @@ export class AppContributorDto {
public readonly permission: string public readonly permission: string
) { ) {
} }
public changePermission(permission: string): AppContributorDto {
return new AppContributorDto(this.contributorId, permission);
}
} }
export class ContributorAssignedDto { export class ContributorAssignedDto {

Loading…
Cancel
Save