From 4608c20081ba4117e723f6e09b4f2483073ba452 Mon Sep 17 00:00:00 2001 From: Sebastian Date: Tue, 10 Mar 2020 11:24:20 +0100 Subject: [PATCH] Just a minor allocation improvement. --- backend/src/Squidex.Infrastructure/Queries/ClrValue.cs | 4 +++- .../Squidex.Infrastructure/Validation/ValidationException.cs | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/backend/src/Squidex.Infrastructure/Queries/ClrValue.cs b/backend/src/Squidex.Infrastructure/Queries/ClrValue.cs index 033147d3d..631792380 100644 --- a/backend/src/Squidex.Infrastructure/Queries/ClrValue.cs +++ b/backend/src/Squidex.Infrastructure/Queries/ClrValue.cs @@ -16,6 +16,8 @@ namespace Squidex.Infrastructure.Queries { public sealed class ClrValue { + private static readonly Func ToStringDelegate = ToString; + public static readonly ClrValue Null = new ClrValue(null, ClrValueType.Null, false); public object? Value { get; } @@ -121,7 +123,7 @@ namespace Squidex.Infrastructure.Queries { if (Value is IList list) { - return $"[{string.Join(", ", list.OfType().Select(ToString).ToArray())}]"; + return $"[{string.Join(", ", list.OfType().Select(ToStringDelegate).ToArray())}]"; } return ToString(Value); diff --git a/backend/src/Squidex.Infrastructure/Validation/ValidationException.cs b/backend/src/Squidex.Infrastructure/Validation/ValidationException.cs index fb3a4bd10..27edc3de9 100644 --- a/backend/src/Squidex.Infrastructure/Validation/ValidationException.cs +++ b/backend/src/Squidex.Infrastructure/Validation/ValidationException.cs @@ -16,6 +16,7 @@ namespace Squidex.Infrastructure.Validation [Serializable] public class ValidationException : DomainException { + private static readonly char[] TrimChars = { ' ', '.', ':' }; private static readonly List FallbackErrors = new List(); private readonly IReadOnlyList errors; @@ -69,7 +70,7 @@ namespace Squidex.Infrastructure.Validation { var sb = new StringBuilder(); - sb.Append(summary.TrimEnd(' ', '.', ':')); + sb.Append(summary.TrimEnd(TrimChars)); if (errors?.Count > 0) {