Browse Source

Fix condition.

release/6.x
Sebastian 4 years ago
parent
commit
871120bda1
  1. 2
      backend/src/Squidex.Domain.Apps.Entities/Comments/CommentTriggerHandler.cs
  2. 12
      backend/tests/Squidex.Domain.Apps.Entities.Tests/Comments/CommentTriggerHandlerTests.cs
  3. 6
      backend/tests/Squidex.Domain.Apps.Entities.Tests/Rules/ManualTriggerHandlerTests.cs
  4. 3
      backend/tests/Squidex.Domain.Apps.Entities.Tests/Rules/UsageTracking/UsageTriggerHandlerTests.cs

2
backend/src/Squidex.Domain.Apps.Entities/Comments/CommentTriggerHandler.cs

@ -42,7 +42,7 @@ namespace Squidex.Domain.Apps.Entities.Comments
{
var commentCreated = (CommentCreated)@event.Payload;
if (!(commentCreated.Mentions?.Length >= 0))
if (!(commentCreated.Mentions?.Length > 0))
{
yield break;
}

12
backend/tests/Squidex.Domain.Apps.Entities.Tests/Comments/CommentTriggerHandlerTests.cs

@ -77,11 +77,12 @@ namespace Squidex.Domain.Apps.Entities.Comments
var userIds = users.Select(x => x.Id).ToArray();
var @event = new CommentCreated { Mentions = userIds };
var envelope = Envelope.Create<AppEvent>(@event);
A.CallTo(() => userResolver.QueryManyAsync(userIds, default))
.Returns(users.ToDictionary(x => x.Id));
var result = await sut.CreateEnrichedEventsAsync(Envelope.Create<AppEvent>(@event), ctx, default).ToListAsync();
var result = await sut.CreateEnrichedEventsAsync(envelope, ctx, default).ToListAsync();
Assert.Equal(2, result.Count);
@ -106,8 +107,9 @@ namespace Squidex.Domain.Apps.Entities.Comments
var userIds = users.Select(x => x.Id).ToArray();
var @event = new CommentCreated { Mentions = userIds };
var envelope = Envelope.Create<AppEvent>(@event);
var result = await sut.CreateEnrichedEventsAsync(Envelope.Create<AppEvent>(@event), ctx, default).ToListAsync();
var result = await sut.CreateEnrichedEventsAsync(envelope, ctx, default).ToListAsync();
Assert.Empty(result);
}
@ -118,8 +120,9 @@ namespace Squidex.Domain.Apps.Entities.Comments
var ctx = Context();
var @event = new CommentCreated { Mentions = null };
var envelope = Envelope.Create<AppEvent>(@event);
var result = await sut.CreateEnrichedEventsAsync(Envelope.Create<AppEvent>(@event), ctx, default).ToListAsync();
var result = await sut.CreateEnrichedEventsAsync(envelope, ctx, default).ToListAsync();
Assert.Empty(result);
@ -133,8 +136,9 @@ namespace Squidex.Domain.Apps.Entities.Comments
var ctx = Context();
var @event = new CommentCreated { Mentions = Array.Empty<string>() };
var envelope = Envelope.Create<AppEvent>(@event);
var result = await sut.CreateEnrichedEventsAsync(Envelope.Create<AppEvent>(@event), ctx, default).ToListAsync();
var result = await sut.CreateEnrichedEventsAsync(envelope, ctx, default).ToListAsync();
Assert.Empty(result);

6
backend/tests/Squidex.Domain.Apps.Entities.Tests/Rules/ManualTriggerHandlerTests.cs

@ -39,8 +39,9 @@ namespace Squidex.Domain.Apps.Entities.Rules
public async Task Should_create_event_with_name()
{
var @event = TestUtils.CreateEvent<RuleManuallyTriggered>();
var envelope = Envelope.Create<AppEvent>(@event);
var result = await sut.CreateEnrichedEventsAsync(Envelope.Create<AppEvent>(@event), default, default).ToListAsync();
var result = await sut.CreateEnrichedEventsAsync(envelope, default, default).ToListAsync();
var enrichedEvent = (EnrichedManualEvent)result.Single();
@ -55,8 +56,9 @@ namespace Squidex.Domain.Apps.Entities.Rules
var actor = RefToken.User("me");
var @event = new RuleManuallyTriggered { Actor = actor };
var envelope = Envelope.Create<AppEvent>(@event);
var result = await sut.CreateEnrichedEventsAsync(Envelope.Create<AppEvent>(@event), default, default).ToListAsync();
var result = await sut.CreateEnrichedEventsAsync(envelope, default, default).ToListAsync();
Assert.Equal(actor, ((EnrichedUserEventBase)result.Single()).Actor);
}

3
backend/tests/Squidex.Domain.Apps.Entities.Tests/Rules/UsageTracking/UsageTriggerHandlerTests.cs

@ -46,8 +46,9 @@ namespace Squidex.Domain.Apps.Entities.Rules.UsageTracking
var ctx = Context();
var @event = new AppUsageExceeded { CallsCurrent = 80, CallsLimit = 120 };
var envelope = Envelope.Create<AppEvent>(@event);
var result = await sut.CreateEnrichedEventsAsync(Envelope.Create<AppEvent>(@event), ctx, default).ToListAsync();
var result = await sut.CreateEnrichedEventsAsync(envelope, ctx, default).ToListAsync();
var enrichedEvent = result.Single() as EnrichedUsageExceededEvent;

Loading…
Cancel
Save