From 8da37979fbc014b3ffc1b3dccb757db98aa810ce Mon Sep 17 00:00:00 2001
From: Sebastian Stehle <sebastian@squidex.io>
Date: Tue, 30 Apr 2019 15:02:41 +0200
Subject: [PATCH] Do not log domain exceptions.

---
 src/Squidex.Infrastructure/Orleans/LoggingFilter.cs  |  4 ++++
 .../Orleans/LoggingFilterTests.cs                    | 12 ++++++++++++
 2 files changed, 16 insertions(+)

diff --git a/src/Squidex.Infrastructure/Orleans/LoggingFilter.cs b/src/Squidex.Infrastructure/Orleans/LoggingFilter.cs
index e52c1fef2..b7edc178c 100644
--- a/src/Squidex.Infrastructure/Orleans/LoggingFilter.cs
+++ b/src/Squidex.Infrastructure/Orleans/LoggingFilter.cs
@@ -29,6 +29,10 @@ namespace Squidex.Infrastructure.Orleans
             {
                 await context.Invoke();
             }
+            catch (DomainException)
+            {
+                throw;
+            }
             catch (Exception ex)
             {
                 log.LogError(ex, w => w
diff --git a/tests/Squidex.Infrastructure.Tests/Orleans/LoggingFilterTests.cs b/tests/Squidex.Infrastructure.Tests/Orleans/LoggingFilterTests.cs
index d3e646f1e..28ee105e9 100644
--- a/tests/Squidex.Infrastructure.Tests/Orleans/LoggingFilterTests.cs
+++ b/tests/Squidex.Infrastructure.Tests/Orleans/LoggingFilterTests.cs
@@ -34,6 +34,18 @@ namespace Squidex.Infrastructure.Orleans
                 .MustNotHaveHappened();
         }
 
+        [Fact]
+        public async Task Should_not_log_domain_exceptions()
+        {
+            A.CallTo(() => context.Invoke())
+                .Throws(new ValidationException("Failed"));
+
+            await Assert.ThrowsAsync<ValidationException>(() => sut.Invoke(context));
+
+            A.CallTo(() => log.Log(A<SemanticLogLevel>.Ignored, A<None>.Ignored, A<Action<None, IObjectWriter>>.Ignored))
+                .MustNotHaveHappened();
+        }
+
         [Fact]
         public async Task Should_log_exception_and_forward_it()
         {