From bf69f79f547f7858f5a67b8196563122f1ff0921 Mon Sep 17 00:00:00 2001
From: Sebastian Stehle <sebastian@squidex.io>
Date: Wed, 19 Apr 2017 20:19:05 +0200
Subject: [PATCH] 1) Editors cannot edit content #19 2) Improve UI to indicate
 that only existing users can be added. #20

---
 src/Squidex/Controllers/Api/Apps/AppLanguagesController.cs | 7 +++++--
 .../pages/contributors/contributors-page.component.html    | 4 ++--
 .../app/framework/angular/autocomplete.component.html      | 2 +-
 .../app/framework/angular/autocomplete.component.ts        | 3 +++
 4 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/src/Squidex/Controllers/Api/Apps/AppLanguagesController.cs b/src/Squidex/Controllers/Api/Apps/AppLanguagesController.cs
index b1f37a5da..6764b99e8 100644
--- a/src/Squidex/Controllers/Api/Apps/AppLanguagesController.cs
+++ b/src/Squidex/Controllers/Api/Apps/AppLanguagesController.cs
@@ -26,7 +26,6 @@ namespace Squidex.Controllers.Api.Apps
     /// <summary>
     /// Manages and configures apps.
     /// </summary>
-    [Authorize(Roles = SquidexRoles.AppOwner)]
     [ApiExceptionFilter]
     [ServiceFilter(typeof(AppFilterAttribute))]
     [SwaggerTag("Apps")]
@@ -48,6 +47,7 @@ namespace Squidex.Controllers.Api.Apps
         /// 200 => Language configuration returned.
         /// 404 => App not found.
         /// </returns>
+        [Authorize(Roles = SquidexRoles.AppEditor)]
         [HttpGet]
         [Route("apps/{app}/languages/")]
         [ProducesResponseType(typeof(LanguageDto[]), 200)]
@@ -82,6 +82,7 @@ namespace Squidex.Controllers.Api.Apps
         /// 400 => Language is an invalid language.
         /// 404 => App not found.
         /// </returns>
+        [Authorize(Roles = SquidexRoles.AppOwner)]
         [HttpPost]
         [Route("apps/{app}/languages/")]
         [ProducesResponseType(typeof(AppLanguageDto), 201)]
@@ -94,7 +95,7 @@ namespace Squidex.Controllers.Api.Apps
 
             return CreatedAtAction(nameof(GetLanguages), new { app }, response);
         }
-        
+
         /// <summary>
         /// Updates an app language.
         /// </summary>
@@ -106,6 +107,7 @@ namespace Squidex.Controllers.Api.Apps
         /// 400 => Language is an invalid language.
         /// 404 => App not found.
         /// </returns>
+        [Authorize(Roles = SquidexRoles.AppOwner)]
         [HttpPut]
         [Route("apps/{app}/languages/{language}")]
         public async Task<IActionResult> Update(string app, string language, [FromBody] UpdateAppLanguageDto model)
@@ -128,6 +130,7 @@ namespace Squidex.Controllers.Api.Apps
         /// 400 => Language is an invalid language.
         /// 404 => App not found.
         /// </returns>
+        [Authorize(Roles = SquidexRoles.AppOwner)]
         [HttpDelete]
         [Route("apps/{app}/languages/{language}")]
         public async Task<IActionResult> DeleteLanguage(string app, string language)
diff --git a/src/Squidex/app/features/settings/pages/contributors/contributors-page.component.html b/src/Squidex/app/features/settings/pages/contributors/contributors-page.component.html
index 6ad89bc72..18e640339 100644
--- a/src/Squidex/app/features/settings/pages/contributors/contributors-page.component.html
+++ b/src/Squidex/app/features/settings/pages/contributors/contributors-page.component.html
@@ -69,8 +69,8 @@
             
             <div class="table-items-footer">
                 <form class="form-inline" [formGroup]="addContributorForm" (ngSubmit)="assignContributor()">
-                    <div class="form-group mr-2">
-                        <sqx-autocomplete [source]="usersDataSource" formControlName="user" [inputName]="'contributor'"></sqx-autocomplete>
+                    <div class="form-group mr-3">
+                        <sqx-autocomplete [source]="usersDataSource" formControlName="user" [inputName]="'contributor'" placeholder="Find existing user"></sqx-autocomplete>
                     </div>
 
                     <button type="submit" class="btn btn-success" [disabled]="!addContributorForm.valid">Add Contributor</button>
diff --git a/src/Squidex/app/framework/angular/autocomplete.component.html b/src/Squidex/app/framework/angular/autocomplete.component.html
index 81dbeb283..7af1556b7 100644
--- a/src/Squidex/app/framework/angular/autocomplete.component.html
+++ b/src/Squidex/app/framework/angular/autocomplete.component.html
@@ -1,5 +1,5 @@
 <span>
-    <input type="text" class="form-control" (blur)="blur()" [attr.name]="inputName" (keydown)="onKeyDown($event)" (blur)="markTouched()"
+    <input type="text" class="form-control" (blur)="blur()" [attr.name]="inputName" (keydown)="onKeyDown($event)" (blur)="markTouched()" [attr.placeholder]="placeholder"
         [formControl]="queryInput"
         autocomplete="off" 
         autocorrect="off"
diff --git a/src/Squidex/app/framework/angular/autocomplete.component.ts b/src/Squidex/app/framework/angular/autocomplete.component.ts
index 3262486ed..77d2971b7 100644
--- a/src/Squidex/app/framework/angular/autocomplete.component.ts
+++ b/src/Squidex/app/framework/angular/autocomplete.component.ts
@@ -49,6 +49,9 @@ export class AutocompleteComponent implements ControlValueAccessor, OnDestroy, O
     @Input()
     public inputName = 'autocompletion';
 
+    @Input()
+    public placeholder = '';
+
     public items: AutocompleteItem[] = [];
     public itemSelection = -1;