Refactor JpaAbstractDao

dao/src/main/java/org/thingsboard/server/dao/sql/JpaAbstractDao.java

@@ -81,6 +81,7 @@ public abstract class JpaAbstractDao<E extends BaseEntity<D>, D>
     }
 
     protected E doSave(E entity, boolean isNew) {
+        EntityManager entityManager = getEntityManager();
         if (isNew) {
             if (entity instanceof HasVersion versionedEntity) {
                 versionedEntity.setVersion(1L);
@@ -179,6 +180,10 @@ public abstract class JpaAbstractDao<E extends BaseEntity<D>, D>
         return ModelConstants.TENANT_ID_COLUMN;
     }
 
+    protected EntityManager getEntityManager() {
+        return entityManager;
+    }
+
     protected JdbcTemplate getJdbcTemplate() {
         return jdbcTemplate;
     }

dao/src/main/java/org/thingsboard/server/dao/sql/JpaPartitionedAbstractDao.java

@@ -29,8 +29,4 @@ public abstract class JpaPartitionedAbstractDao<E extends BaseEntity<D>, D> exte
 
     public abstract void createPartition(E entity);
 
-    protected EntityManager getEntityManager() {
-        return entityManager;
-    }
-
 }

dao/src/main/java/org/thingsboard/server/dao/sql/audit/DedicatedJpaAuditLogDao.java

@@ -64,8 +64,8 @@ public class DedicatedJpaAuditLogDao extends JpaAuditLogDao {
 
     @Transactional(transactionManager = EVENTS_TRANSACTION_MANAGER)
     @Override
-    public boolean removeById(TenantId tenantId, UUID id) {
-        return super.removeById(tenantId, id);
+    public void removeById(TenantId tenantId, UUID id) {
+        super.removeById(tenantId, id);
     }
 
     @Transactional(transactionManager = EVENTS_TRANSACTION_MANAGER)