Browse Source

Protect against bogus interval

pull/455/head
Unknown 9 years ago
committed by Andrew Shvayka
parent
commit
160aa7ac04
  1. 3
      extensions-core/src/main/java/org/thingsboard/server/extensions/core/plugin/telemetry/handlers/TelemetryRestMsgHandler.java

3
extensions-core/src/main/java/org/thingsboard/server/extensions/core/plugin/telemetry/handlers/TelemetryRestMsgHandler.java

@ -128,8 +128,9 @@ public class TelemetryRestMsgHandler extends DefaultRestMsgHandler {
Optional<Long> interval = request.getLongParamValue("interval"); Optional<Long> interval = request.getLongParamValue("interval");
Optional<Integer> limit = request.getIntParamValue("limit"); Optional<Integer> limit = request.getIntParamValue("limit");
// If some of these params are specified, they all must be
if (startTs.isPresent() || endTs.isPresent() || interval.isPresent() || limit.isPresent()) { if (startTs.isPresent() || endTs.isPresent() || interval.isPresent() || limit.isPresent()) {
if (!startTs.isPresent() || !endTs.isPresent() || !interval.isPresent()) { if (!startTs.isPresent() || !endTs.isPresent() || !interval.isPresent() || interval.get() < 0) {
msg.getResponseHolder().setResult(new ResponseEntity<>(HttpStatus.BAD_REQUEST)); msg.getResponseHolder().setResult(new ResponseEntity<>(HttpStatus.BAD_REQUEST));
return; return;
} }

Loading…
Cancel
Save