Add max string value lenght parameter for attributes/timeseries. Improve WS updates handling.

application/src/main/java/org/thingsboard/server/controller/TelemetryController.java

@@ -24,6 +24,7 @@ import com.google.gson.JsonElement;
 import com.google.gson.JsonParser;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.beans.factory.annotation.Value;
 import org.springframework.http.HttpStatus;
 import org.springframework.http.ResponseEntity;
 import org.springframework.security.access.prepost.PreAuthorize;
@@ -99,6 +100,9 @@ public class TelemetryController extends BaseController {
     @Autowired
     private AccessValidator accessValidator;
 
+    @Value("${transport.json.max_string_value_length:0}")
+    private int maxStringValueLength;
+
     private ExecutorService executor;
 
     @PostConstruct
@@ -628,6 +632,10 @@ public class TelemetryController extends BaseController {
             String key = entry.getKey();
             JsonNode value = entry.getValue();
             if (entry.getValue().isTextual()) {
+                if (maxStringValueLength > 0 && entry.getValue().textValue().length() > maxStringValueLength) {
+                    String message = String.format("String value length [%d] for key [%s] is greater than maximum allowed [%d]", entry.getValue().textValue().length(), key, maxStringValueLength);
+                    throw new UncheckedApiException(new InvalidParametersException(message));
+                }
                 attributes.add(new BaseAttributeKvEntry(new StringDataEntry(key, value.textValue()), ts));
             } else if (entry.getValue().isBoolean()) {
                 attributes.add(new BaseAttributeKvEntry(new BooleanDataEntry(key, value.booleanValue()), ts));

application/src/main/java/org/thingsboard/server/controller/plugin/TbWebSocketHandler.java

@@ -200,7 +200,12 @@ public class TbWebSocketHandler extends TextWebSocketHandler implements Telemetr
                     }
                 }
                 synchronized (sessionMd) {
+                    long start = System.currentTimeMillis();
                     sessionMd.session.sendMessage(new TextMessage(msg));
+                    long took = System.currentTimeMillis() - start;
+                    if (took >= 1000) {
+                        log.info("[{}][{}] Sending message took more than 1 second [{}ms] {}", sessionRef.getSecurityCtx().getTenantId(), externalId, took, msg);
+                    }
                 }
             } else {
                 log.warn("[{}][{}] Failed to find session by internal id", externalId, internalId);

application/src/main/java/org/thingsboard/server/service/telemetry/DefaultTelemetryWebSocketService.java

@@ -581,13 +581,15 @@ public class DefaultTelemetryWebSocketService implements TelemetryWebSocketServi
     }
 
     private void sendWsMsg(TelemetryWebSocketSessionRef sessionRef, SubscriptionUpdate update) {
-        try {
+        executor.submit(() -> {
-            msgEndpoint.send(sessionRef, update.getSubscriptionId(), jsonMapper.writeValueAsString(update));
+            try {
-        } catch (JsonProcessingException e) {
+                msgEndpoint.send(sessionRef, update.getSubscriptionId(), jsonMapper.writeValueAsString(update));
-            log.warn("[{}] Failed to encode reply: {}", sessionRef.getSessionId(), update, e);
+            } catch (JsonProcessingException e) {
-        } catch (IOException e) {
+                log.warn("[{}] Failed to encode reply: {}", sessionRef.getSessionId(), update, e);
-            log.warn("[{}] Failed to send reply: {}", sessionRef.getSessionId(), update, e);
+            } catch (IOException e) {
-        }
+                log.warn("[{}] Failed to send reply: {}", sessionRef.getSessionId(), update, e);
+            }
+        });
     }
 
     private static Optional<Set<String>> getKeys(TelemetryPluginCmd cmd) {

application/src/main/resources/thingsboard.yml

@@ -439,6 +439,8 @@ transport:
   json:
     # Cast String data types to Numeric if possible when processing Telemetry/Attributes JSON
     type_cast_enabled: "${JSON_TYPE_CAST_ENABLED:true}"
+    # Maximum allowed string value length when processing Telemetry/Attributes JSON (0 value disables string value length check)
+    max_string_value_length: "${JSON_MAX_STRING_VALUE_LENGTH:0}"
   # Local HTTP transport parameters
   http:
     enabled: "${HTTP_ENABLED:true}"

common/transport/transport-api/src/main/java/org/thingsboard/server/common/transport/adaptor/JsonConverter.java

@@ -61,6 +61,8 @@ public class JsonConverter {
 
     private static boolean isTypeCastEnabled = true;
 
+    private static int maxStringValueLength = 0;
+
     public static PostTelemetryMsg convertToTelemetryProto(JsonElement jsonObject) throws JsonSyntaxException {
         long systemTs = System.currentTimeMillis();
         PostTelemetryMsg.Builder builder = PostTelemetryMsg.newBuilder();
@@ -131,6 +133,10 @@ public class JsonConverter {
             if (element.isJsonPrimitive()) {
                 JsonPrimitive value = element.getAsJsonPrimitive();
                 if (value.isString()) {
+                    if (maxStringValueLength > 0 && value.getAsString().length() > maxStringValueLength) {
+                        String message = String.format("String value length [%d] for key [%s] is greater than maximum allowed [%d]", value.getAsString().length(), valueEntry.getKey(), maxStringValueLength);
+                        throw new JsonSyntaxException(message);
+                    }
                     if(isTypeCastEnabled && NumberUtils.isParsable(value.getAsString())) {
                         try {
                             result.add(buildNumericKeyValueProto(value, valueEntry.getKey()));
@@ -389,6 +395,10 @@ public class JsonConverter {
             if (element.isJsonPrimitive()) {
                 JsonPrimitive value = element.getAsJsonPrimitive();
                 if (value.isString()) {
+                    if (maxStringValueLength > 0 && value.getAsString().length() > maxStringValueLength) {
+                        String message = String.format("String value length [%d] for key [%s] is greater than maximum allowed [%d]", value.getAsString().length(), valueEntry.getKey(), maxStringValueLength);
+                        throw new JsonSyntaxException(message);
+                    }
                     if(isTypeCastEnabled && NumberUtils.isParsable(value.getAsString())) {
                         try {
                             parseNumericValue(result, valueEntry, value);
@@ -456,4 +466,9 @@ public class JsonConverter {
     public static void setTypeCastEnabled(boolean enabled) {
         isTypeCastEnabled = enabled;
     }
+
+    public static void setMaxStringValueLength(int length) {
+        maxStringValueLength = length;
+    }
+
 }

common/transport/transport-api/src/main/java/org/thingsboard/server/common/transport/adaptor/JsonConverterConfig.java

@@ -28,4 +28,10 @@ public class JsonConverterConfig {
         JsonConverter.setTypeCastEnabled(jsonTypeCastEnabled);
         log.info("JSON type cast enabled = {}", jsonTypeCastEnabled);
     }
+
+    @Value("${transport.json.max_string_value_length:0}")
+    public void setMaxStringValueLength(int maxStringValueLength) {
+        JsonConverter.setMaxStringValueLength(maxStringValueLength);
+        log.info("JSON max string value length = {}", maxStringValueLength);
+    }
 }