Browse Source

Claim device improvements (#1915)

* add-device-to-claim-result

* code update

* code-update

* added-condition-on-empty-cache-clause

* remove empty row

* update code

* cleaned code
pull/1928/head
ShvaykaD 7 years ago
committed by Andrew Shvayka
parent
commit
19d103fef4
  1. 6
      application/src/main/java/org/thingsboard/server/controller/DeviceController.java
  2. 2
      dao/src/main/java/org/thingsboard/server/dao/device/ClaimDevicesServiceImpl.java

6
application/src/main/java/org/thingsboard/server/controller/DeviceController.java

@ -418,11 +418,7 @@ public class DeviceController extends BaseController {
deferredResult.setResult(new ResponseEntity<>(result, status));
} else {
status = HttpStatus.BAD_REQUEST;
if (result.getResponse().equals(ClaimResponse.FAILURE)) {
deferredResult.setResult(new ResponseEntity<>(result.getResponse(), status));
} else {
deferredResult.setResult(new ResponseEntity<>(result, status));
}
deferredResult.setResult(new ResponseEntity<>(result.getResponse(), status));
}
} else {
deferredResult.setResult(new ResponseEntity<>(HttpStatus.BAD_REQUEST));

2
dao/src/main/java/org/thingsboard/server/dao/device/ClaimDevicesServiceImpl.java

@ -116,7 +116,7 @@ public class ClaimDevicesServiceImpl implements ClaimDevicesService {
}
} else {
log.warn("Failed to find the device's claiming message![{}]", device.getName());
if(device.getCustomerId().getId().equals(ModelConstants.NULL_UUID)) {
if (device.getCustomerId().getId().equals(ModelConstants.NULL_UUID)) {
return Futures.immediateFuture(new ClaimResult(null, ClaimResponse.FAILURE));
} else {
return Futures.immediateFuture(new ClaimResult(null, ClaimResponse.CLAIMED));

Loading…
Cancel
Save