Browse Source

Use Number.isFinite for input validation

Replaces separate isNaN/null checks with a single Number.isFinite
guard that also handles Infinity/-Infinity.
pull/15396/head
Vladyslav_Prykhodko 6 months ago
committed by Vladyslav Prykhodko
parent
commit
284c7d9d30
  1. 6
      ui-ngx/src/app/shared/pipe/short-number.pipe.ts

6
ui-ngx/src/app/shared/pipe/short-number.pipe.ts

@ -28,9 +28,9 @@ export interface ShortNumberArgs {
export class ShortNumberPipe implements PipeTransform {
transform(number: number, args?: ShortNumberArgs): string {
if (isNaN(number)) return '0';
if (number === null) return '0';
if (number === 0) return '0';
if (!Number.isFinite(number) || number === 0) {
return '0';
}
let abs = Math.abs(number);
const rounder = Math.pow(10, 1);
const isNegative = number < 0;

Loading…
Cancel
Save