Browse Source

Refactor: more consistent tests cases names for CalculateDeltaNode

pull/8661/head
Dmytro Skarzhynets 4 years ago
parent
commit
2b6b9537c9
  1. 8
      rule-engine/rule-engine-components/src/test/java/org/thingsboard/rule/engine/metadata/CalculateDeltaNodeTest.java

8
rule-engine/rule-engine-components/src/test/java/org/thingsboard/rule/engine/metadata/CalculateDeltaNodeTest.java

@ -143,7 +143,7 @@ public class CalculateDeltaNodeTest {
} }
@Test @Test
public void givenDoubleValue_whenOnMsg_thenSuccess() throws TbNodeException { public void givenDoubleValue_whenOnMsg_thenShouldTellSuccess() throws TbNodeException {
// GIVEN // GIVEN
config.setRound(1); config.setRound(1);
config.setInputValueKey("temperature"); config.setInputValueKey("temperature");
@ -173,7 +173,7 @@ public class CalculateDeltaNodeTest {
} }
@Test @Test
public void givenLongStringValue_whenOnMsg_thenSuccess() throws TbNodeException { public void givenLongStringValue_whenOnMsg_thenShouldTellSuccess() throws TbNodeException {
// GIVEN // GIVEN
config.setInputValueKey("temperature"); config.setInputValueKey("temperature");
config.setOutputValueKey("temp_delta"); config.setOutputValueKey("temp_delta");
@ -202,7 +202,7 @@ public class CalculateDeltaNodeTest {
} }
@Test @Test
public void givenValidStringValue_whenOnMsg_thenSuccess() throws TbNodeException { public void givenValidStringValue_whenOnMsg_thenShouldTellSuccess() throws TbNodeException {
// GIVEN // GIVEN
config.setInputValueKey("temperature"); config.setInputValueKey("temperature");
config.setOutputValueKey("temp_delta"); config.setOutputValueKey("temp_delta");
@ -319,7 +319,7 @@ public class CalculateDeltaNodeTest {
} }
@Test @Test
public void givenNegativeDeltaAndTellFailureIfNegativeDeltaTrue_whenOnMsg_thenFailure() throws TbNodeException { public void givenNegativeDeltaAndTellFailureIfNegativeDeltaTrue_whenOnMsg_thenShouldTellFailure() throws TbNodeException {
// GIVEN // GIVEN
config.setTellFailureIfDeltaIsNegative(true); config.setTellFailureIfDeltaIsNegative(true);
nodeConfiguration = new TbNodeConfiguration(JacksonUtil.valueToTree(config)); nodeConfiguration = new TbNodeConfiguration(JacksonUtil.valueToTree(config));

Loading…
Cancel
Save