Browse Source

fixed test

pull/7762/head
dashevchenko 4 years ago
parent
commit
2db28e2296
  1. 2
      common/dao-api/src/main/java/org/thingsboard/server/dao/alarm/AlarmCommentService.java
  2. 6
      dao/src/test/java/org/thingsboard/server/dao/service/BaseAlarmCommentServiceTest.java

2
common/dao-api/src/main/java/org/thingsboard/server/dao/alarm/AlarmCommentService.java

@ -29,7 +29,7 @@ public interface AlarmCommentService {
AlarmCommentOperationResult deleteAlarmComment(TenantId tenantId, AlarmCommentId alarmCommentId);
PageData<AlarmCommentInfo>findAlarmComments(TenantId tenantId, AlarmId alarmId, PageLink pageLink);
PageData<AlarmCommentInfo> findAlarmComments(TenantId tenantId, AlarmId alarmId, PageLink pageLink);
ListenableFuture<AlarmComment> findAlarmCommentByIdAsync(TenantId tenantId, AlarmCommentId alarmCommentId);

6
dao/src/test/java/org/thingsboard/server/dao/service/BaseAlarmCommentServiceTest.java

@ -64,6 +64,8 @@ public abstract class BaseAlarmCommentServiceTest extends AbstractServiceTest {
user.setAuthority(Authority.TENANT_ADMIN);
user.setTenantId(tenantId);
user.setEmail("tenant@thingsboard.org");
user.setFirstName("John");
user.setLastName("Brown");
user = userService.saveUser(user);
}
@ -98,7 +100,7 @@ public abstract class BaseAlarmCommentServiceTest extends AbstractServiceTest {
PageData<AlarmCommentInfo> alarmComments = alarmCommentService.findAlarmComments(tenantId, alarm.getId(), new PageLink(10, 0));
Assert.assertNotNull(alarmComments.getData());
Assert.assertEquals(1, alarmComments.getData().size());
Assert.assertEquals(createdComment, alarmComments.getData().get(0));
Assert.assertEquals(createdComment, new AlarmComment(alarmComments.getData().get(0)));
}
@Test
@ -134,7 +136,7 @@ public abstract class BaseAlarmCommentServiceTest extends AbstractServiceTest {
PageData<AlarmCommentInfo> alarmComments = alarmCommentService.findAlarmComments(tenantId, alarm.getId(), new PageLink(10, 0));
Assert.assertNotNull(alarmComments.getData());
Assert.assertEquals(1, alarmComments.getData().size());
Assert.assertEquals(new AlarmCommentInfo(updatedComment), alarmComments.getData().get(0));
Assert.assertEquals(updatedComment, new AlarmComment(alarmComments.getData().get(0)));
}
@Test

Loading…
Cancel
Save