From 2e57990e04f242cd9d001906f28f696c3dc6e695 Mon Sep 17 00:00:00 2001
From: Andrii Shvaika <ashvayka@thingsboard.io>
Date: Fri, 16 Feb 2024 14:00:27 +0200
Subject: [PATCH] Fix the old websocket API

---
 .../server/service/ws/DefaultWebSocketService.java         | 3 ++-
 .../ws/telemetry/sub/TelemetrySubscriptionUpdate.java      | 7 ++++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/application/src/main/java/org/thingsboard/server/service/ws/DefaultWebSocketService.java b/application/src/main/java/org/thingsboard/server/service/ws/DefaultWebSocketService.java
index edb2d7b7fa..0af50ff859 100644
--- a/application/src/main/java/org/thingsboard/server/service/ws/DefaultWebSocketService.java
+++ b/application/src/main/java/org/thingsboard/server/service/ws/DefaultWebSocketService.java
@@ -260,7 +260,8 @@ public class DefaultWebSocketService implements WebSocketService {
 
     @Override
     public void sendUpdate(String sessionId, int cmdId, TelemetrySubscriptionUpdate update) {
-        doSendUpdate(sessionId, cmdId, update);
+        // We substitute the subscriptionId with cmdId for old-style subscriptions.
+        doSendUpdate(sessionId, cmdId, update.copyWithNewSubscriptionId(cmdId));
     }
 
     @Override
diff --git a/application/src/main/java/org/thingsboard/server/service/ws/telemetry/sub/TelemetrySubscriptionUpdate.java b/application/src/main/java/org/thingsboard/server/service/ws/telemetry/sub/TelemetrySubscriptionUpdate.java
index 1320a055cd..aa1a44096d 100644
--- a/application/src/main/java/org/thingsboard/server/service/ws/telemetry/sub/TelemetrySubscriptionUpdate.java
+++ b/application/src/main/java/org/thingsboard/server/service/ws/telemetry/sub/TelemetrySubscriptionUpdate.java
@@ -15,6 +15,7 @@
  */
 package org.thingsboard.server.service.ws.telemetry.sub;
 
+import lombok.AllArgsConstructor;
 import org.thingsboard.server.common.data.kv.TsKvEntry;
 import org.thingsboard.server.service.subscription.SubscriptionErrorCode;
 
@@ -26,8 +27,8 @@ import java.util.Map;
 import java.util.TreeMap;
 import java.util.stream.Collectors;
 
+@AllArgsConstructor
 public class TelemetrySubscriptionUpdate {
-
     private final int subscriptionId;
     private int errorCode;
     private String errorMsg;
@@ -93,6 +94,10 @@ public class TelemetrySubscriptionUpdate {
         return errorMsg;
     }
 
+    public TelemetrySubscriptionUpdate copyWithNewSubscriptionId(int subscriptionId){
+        return new TelemetrySubscriptionUpdate(subscriptionId, errorCode, errorMsg, data);
+    }
+
     @Override
     public String toString() {
         StringBuilder result = new StringBuilder("TelemetrySubscriptionUpdate [subscriptionId=" + subscriptionId + ", errorCode=" + errorCode + ", errorMsg=" + errorMsg + ", data=");