Browse Source

Merge pull request #16044 from AndriiLandiak/fix/sync-not-stranded-on-fetcher-failure-lts-4.2

Do not strand edge sync when an event fetcher fails
lts-4.2
Viacheslav Klimov 2 days ago
committed by GitHub
parent
commit
32742a3c38
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 7
      application/src/main/java/org/thingsboard/server/service/edge/rpc/EdgeGrpcSession.java

7
application/src/main/java/org/thingsboard/server/service/edge/rpc/EdgeGrpcSession.java

@ -269,7 +269,12 @@ public abstract class EdgeGrpcSession implements Closeable {
@Override
public void onFailure(Throwable t) {
log.error("[{}][{}] Exception during sync process", tenantId, edge.getId(), t);
log.error("[{}][{}] Exception during sync process, skipping fetcher {} and continuing",
tenantId, edge.getId(), next.getClass().getSimpleName(), t);
// Keep walking the cursor: returning here leaves syncInProgress set for the life of the
// session, so the edge never receives SyncCompletedMsg and both general downlink delivery
// and uplink processing stay gated until the session is re-established.
doSync(cursor);
}
}, ctx.getGrpcCallbackExecutorService());
} else {

Loading…
Cancel
Save