From 345c1e5a31779b1f0b8a03381f5319f5464f564a Mon Sep 17 00:00:00 2001
From: ViacheslavKlimov <viacheslavklimov11@gmail.com>
Date: Tue, 17 Sep 2024 19:05:03 +0300
Subject: [PATCH] Fix incrementFailedLoginAttemptsByUserId

---
 .../org/thingsboard/server/controller/TwoFactorAuthTest.java  | 4 +++-
 .../server/dao/sql/user/UserCredentialsRepository.java        | 1 -
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/application/src/test/java/org/thingsboard/server/controller/TwoFactorAuthTest.java b/application/src/test/java/org/thingsboard/server/controller/TwoFactorAuthTest.java
index 63703ae27b..7fa848f95d 100644
--- a/application/src/test/java/org/thingsboard/server/controller/TwoFactorAuthTest.java
+++ b/application/src/test/java/org/thingsboard/server/controller/TwoFactorAuthTest.java
@@ -319,7 +319,9 @@ public class TwoFactorAuthTest extends AbstractControllerTest {
             assertThat(successfulLogInAuditLog.getActionStatus()).isEqualTo(ActionStatus.SUCCESS);
             assertThat(successfulLogInAuditLog.getUserName()).isEqualTo(username);
         });
-        assertThat(userService.findUserById(tenantId, user.getId()).getAdditionalInfo()
+
+        loginTenantAdmin();
+        assertThat(doGet("/api/user/" + user.getId(), User.class).getAdditionalInfo()
                 .get("lastLoginTs").asLong())
                 .isGreaterThan(System.currentTimeMillis() - TimeUnit.SECONDS.toMillis(3));
     }
diff --git a/dao/src/main/java/org/thingsboard/server/dao/sql/user/UserCredentialsRepository.java b/dao/src/main/java/org/thingsboard/server/dao/sql/user/UserCredentialsRepository.java
index 60cdffb410..4aca40647c 100644
--- a/dao/src/main/java/org/thingsboard/server/dao/sql/user/UserCredentialsRepository.java
+++ b/dao/src/main/java/org/thingsboard/server/dao/sql/user/UserCredentialsRepository.java
@@ -43,7 +43,6 @@ public interface UserCredentialsRepository extends JpaRepository<UserCredentials
     void updateLastLoginTsByUserId(UUID userId, long lastLoginTs);
 
     @Transactional
-    @Modifying
     @Query(value = "UPDATE user_credentials SET failed_login_attempts = coalesce(failed_login_attempts, 0) + 1 " +
             "WHERE user_id = :userId RETURNING failed_login_attempts", nativeQuery = true)
     int incrementFailedLoginAttemptsByUserId(UUID userId);