diff --git a/ui/src/app/common/utils.service.js b/ui/src/app/common/utils.service.js index f140893d2b..7f05481f0e 100644 --- a/ui/src/app/common/utils.service.js +++ b/ui/src/app/common/utils.service.js @@ -120,18 +120,6 @@ function Utils($mdColorPalette, $rootScope, $window, $translate, $q, $timeout, t ]; var defaultAlarmDataKeys = []; - for (var i=0;i 0 && ngModelCtrl.$viewValue.dataKeys.length >= scope.maxDataKeys ) { return null; } else { - return scope.generateDataKey({chip: chip.name, type: chip.type}); + if (chip.type) { + return scope.generateDataKey({chip: chip.name, type: chip.type}); + } else { + if (scope.widgetType != types.widgetType.latest.value) { + return scope.generateDataKey({chip: chip, type: types.dataKeyType.timeseries}); + } else { + return null; + } + } } }; diff --git a/ui/src/app/components/datasource-entity.tpl.html b/ui/src/app/components/datasource-entity.tpl.html index 50858caef1..b609daa361 100644 --- a/ui/src/app/components/datasource-entity.tpl.html +++ b/ui/src/app/components/datasource-entity.tpl.html @@ -70,20 +70,23 @@
+
+ +
-
- - {{'datakey.attributes' | translate }} - - - - {{'datakey.timeseries' | translate }} - - - {{$chip.label}} +
+ + {{'datakey.attributes' | translate }} + + + + {{'datakey.timeseries' | translate }} + + + {{$chip.label}}
:
@@ -130,11 +133,14 @@
+
+ +
-
+
{{$chip.label}}
:
diff --git a/ui/src/app/components/datasource-func.tpl.html b/ui/src/app/components/datasource-func.tpl.html index 289570fd77..5cae48df77 100644 --- a/ui/src/app/components/datasource-func.tpl.html +++ b/ui/src/app/components/datasource-func.tpl.html @@ -58,11 +58,14 @@
-
+
+ +
+
-
+
{{$chip.label}}
:
@@ -109,11 +112,14 @@
-
+
+ +
+
-
+
{{$chip.label}}
:
diff --git a/ui/src/app/components/datasource.scss b/ui/src/app/components/datasource.scss index 217e73f6aa..8cd552ff47 100644 --- a/ui/src/app/components/datasource.scss +++ b/ui/src/app/components/datasource.scss @@ -58,6 +58,14 @@ } .tb-attribute-chip { + .tb-chip-drag-handle { + cursor: move; + + ng-md-icon { + pointer-events: none; + } + } + .tb-chip-label { overflow: hidden; text-overflow: ellipsis; diff --git a/ui/src/app/components/md-chip-draggable.directive.js b/ui/src/app/components/md-chip-draggable.directive.js index 8fcdc0ad73..9ac63fdefc 100644 --- a/ui/src/app/components/md-chip-draggable.directive.js +++ b/ui/src/app/components/md-chip-draggable.directive.js @@ -22,9 +22,6 @@ export default angular.module('thingsboard.directives.mdChipDraggable', []) controllerAs: 'vm', controller: ['$document', '$scope', '$element', '$timeout', function ($document, $scope, $element, $timeout) { - var options = { - axis: 'horizontal', - }; var handle = $element[0]; var draggingClassName = 'dragging'; var droppingClassName = 'dropping'; @@ -92,26 +89,28 @@ export default angular.module('thingsboard.directives.mdChipDraggable', []) y: (event.originalEvent || event).clientY - bounds.top, }; - var offset = options.axis === 'vertical' ? props.y : props.x; - var midPoint = (options.axis === 'vertical' ? props.height : props.width) / 2; + var horizontalOffset = props.x; + var horizontalMidPoint = props.width / 2; + + var verticalOffset = props.y; + var verticalMidPoint = props.height / 2; $element.addClass(droppingClassName); - - if (offset < midPoint) { - dropPosition = 'before'; - $element.removeClass(droppingAfterClassName); - $element.addClass(droppingBeforeClassName); + if (horizontalOffset >= horizontalMidPoint || verticalOffset >= verticalMidPoint) { + dropPosition = 'after'; + $element.removeClass(droppingBeforeClassName); + $element.addClass(droppingAfterClassName); } else { - dropPosition = 'after'; - $element.removeClass(droppingBeforeClassName); - $element.addClass(droppingAfterClassName); + dropPosition = 'before'; + $element.removeClass(droppingAfterClassName); + $element.addClass(droppingBeforeClassName); } + }; var dropHandler = function (event) { event.preventDefault(); - var droppedItemIndex = parseInt((event.dataTransfer || event.originalEvent.dataTransfer).getData('text/plain'), 10); var currentIndex = $scope.$parent.$mdChipsCtrl.items.indexOf($scope.$parent.$chip); var newIndex = null; diff --git a/ui/src/app/components/widget/widget-config.tpl.html b/ui/src/app/components/widget/widget-config.tpl.html index c4db5386dc..0998ad9378 100644 --- a/ui/src/app/components/widget/widget-config.tpl.html +++ b/ui/src/app/components/widget/widget-config.tpl.html @@ -23,12 +23,14 @@
- {{ 'widget-config.use-dashboard-timewindow' | translate }} - - {{ 'widget-config.display-timewindow' | translate }} - +
+ {{ 'widget-config.use-dashboard-timewindow' | translate }} + + {{ 'widget-config.display-timewindow' | translate }} + +
widget-config.timewindow