Merge branch 'fix/3993-created-mqtt-default-values' of github.com:maxunbearable/thingsboard into improvement/gateway-dashboard

ui-ngx/src/app/modules/home/components/widget/lib/gateway/connectors-configuration/broker-config-control/broker-config-control.component.ts

@@ -78,7 +78,7 @@ export class BrokerConfigControlComponent implements ControlValueAccessor, Valid
       host: ['', [Validators.required, Validators.pattern(noLeadTrailSpacesRegex)]],
       port: [null, [Validators.required, Validators.min(PortLimits.MIN), Validators.max(PortLimits.MAX)]],
       version: [5, []],
-      clientId: ['', [Validators.pattern(noLeadTrailSpacesRegex)]],
+      clientId: ['tb_gw_' + generateSecret(5), [Validators.pattern(noLeadTrailSpacesRegex)]],
       security: []
     });
 

ui-ngx/src/app/modules/home/components/widget/lib/gateway/connectors-configuration/mqtt-basic-config/mqtt-basic-config.component.ts

@@ -113,16 +113,18 @@ export class MqttBasicConfigComponent implements ControlValueAccessor, Validator
   }
 
   writeValue(basicConfig: ConnectorBaseConfig): void {
+    const { broker, dataMapping = [], requestsMapping } = basicConfig;
+
     const editedBase = {
-      workers: {
+      workers: broker && (broker.maxNumberOfWorkers || broker.maxMessageNumberPerWorker) ? {
-        maxNumberOfWorkers: basicConfig.broker?.maxNumberOfWorkers,
+        maxNumberOfWorkers: broker.maxNumberOfWorkers,
-        maxMessageNumberPerWorker: basicConfig.broker?.maxMessageNumberPerWorker,
+        maxMessageNumberPerWorker: broker.maxMessageNumberPerWorker,
-      },
+      } : {},
-      dataMapping: basicConfig.dataMapping || [],
+      dataMapping: dataMapping || [],
-      broker: basicConfig.broker || {},
+      broker: broker || {},
-      requestsMapping: Array.isArray(basicConfig.requestsMapping)
+      requestsMapping: Array.isArray(requestsMapping)
-        ? basicConfig.requestsMapping
+        ? requestsMapping
-        : this.getRequestDataArray(basicConfig.requestsMapping),
+        : this.getRequestDataArray(requestsMapping),
     };
 
     this.basicFormGroup.setValue(editedBase, {emitEvent: false});

ui-ngx/src/app/modules/home/components/widget/lib/gateway/connectors-configuration/workers-config-control/workers-config-control.component.ts

@@ -25,7 +25,9 @@ import {
   FormBuilder,
   NG_VALIDATORS,
   NG_VALUE_ACCESSOR,
-  UntypedFormGroup, ValidationErrors, Validator,
+  UntypedFormGroup,
+  ValidationErrors,
+  Validator,
   Validators
 } from '@angular/forms';
 import { SharedModule } from '@shared/shared.module';

ui-ngx/src/app/modules/home/components/widget/lib/gateway/dialog/add-connector-dialog.component.ts

@@ -33,7 +33,7 @@ import {
 } from '@home/components/widget/lib/gateway/gateway-widget.models';
 import { Subject } from 'rxjs';
 import { ResourcesService } from '@core/services/resources.service';
-import { takeUntil, tap } from "rxjs/operators";
+import { takeUntil, tap } from 'rxjs/operators';
 
 @Component({
   selector: 'tb-add-connector-dialog',