Save time series strategies: add test for changes in entity view service

2 years ago · 3aac81745f
1 changed files with 109 additions and 0 deletions
--- a/application/src/test/java/org/thingsboard/server/service/entitiy/entityview/DefaultTbEntityViewServiceTest.java
+++ b/application/src/test/java/org/thingsboard/server/service/entitiy/entityview/DefaultTbEntityViewServiceTest.java
@ -0,0 +1,109 @@
+/**
+ * Copyright © 2016-2024 The Thingsboard Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.thingsboard.server.service.entitiy.entityview;
+
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.ArgumentCaptor;
+import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
+import org.thingsboard.rule.engine.api.TimeseriesSaveRequest;
+import org.thingsboard.server.common.data.EntityView;
+import org.thingsboard.server.common.data.id.DeviceId;
+import org.thingsboard.server.common.data.id.EntityId;
+import org.thingsboard.server.common.data.id.EntityViewId;
+import org.thingsboard.server.common.data.id.TenantId;
+import org.thingsboard.server.common.data.kv.BasicTsKvEntry;
+import org.thingsboard.server.common.data.kv.DoubleDataEntry;
+import org.thingsboard.server.common.data.kv.TsKvEntry;
+import org.thingsboard.server.common.data.objects.AttributesEntityView;
+import org.thingsboard.server.common.data.objects.TelemetryEntityView;
+import org.thingsboard.server.dao.attributes.AttributesService;
+import org.thingsboard.server.dao.entityview.EntityViewService;
+import org.thingsboard.server.dao.timeseries.TimeseriesService;
+import org.thingsboard.server.service.telemetry.TelemetrySubscriptionService;
+
+import java.util.List;
+import java.util.UUID;
+
+import static com.google.common.util.concurrent.Futures.immediateFuture;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.mockito.ArgumentMatchers.anyList;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.BDDMockito.given;
+import static org.mockito.BDDMockito.then;
+
+@ExtendWith(MockitoExtension.class)
+class DefaultTbEntityViewServiceTest {
+
+    final TenantId tenantId = TenantId.fromUUID(UUID.fromString("f09c8180-686c-11ef-9471-a71d33080e9c"));
+    final EntityId entityId = DeviceId.fromString("782aaab0-c7a8-11ef-a668-79582e785d5f");
+
+    @Mock
+    EntityViewService entityViewService;
+    @Mock
+    AttributesService attributesService;
+    @Mock
+    TelemetrySubscriptionService tsSubService;
+    @Mock
+    TimeseriesService tsService;
+
+    DefaultTbEntityViewService defaultTbEntityViewService;
+
+    @BeforeEach
+    void setup() {
+        defaultTbEntityViewService = new DefaultTbEntityViewService(entityViewService, attributesService, tsSubService, tsService);
+    }
+
+    @Test
+    void shouldNotSaveTimeseriesWhenCopyingLatestToEntityView() throws Exception {
+        // GIVEN
+        var entityView = new EntityView(new EntityViewId(UUID.randomUUID()));
+        entityView.setTenantId(tenantId);
+        entityView.setEntityId(entityId);
+        entityView.setKeys(new TelemetryEntityView(List.of("temperature"), new AttributesEntityView()));
+
+        List<TsKvEntry> latest = List.of(new BasicTsKvEntry(123L, new DoubleDataEntry("temperature", 22.3)));
+
+        given(tsService.findAll(eq(tenantId), eq(entityId), anyList())).willReturn(immediateFuture(latest));
+
+        // WHEN
+        defaultTbEntityViewService.updateEntityViewAttributes(tenantId, entityView, null, null);
+
+        // THEN
+        var captor = ArgumentCaptor.forClass(TimeseriesSaveRequest.class);
+        then(tsSubService).should().saveTimeseries(captor.capture());
+
+        var expectedCopyLatestRequest = TimeseriesSaveRequest.builder()
+                .tenantId(tenantId)
+                .entityId(entityView.getId())
+                .entries(latest)
+                .ttl(0L)
+                .saveTimeseries(false)
+                .saveLatest(true)
+                .sendWsUpdate(true)
+                .build();
+
+        var actualCopyLatestRequest = captor.getValue();
+
+        assertThat(actualCopyLatestRequest)
+                .usingRecursiveComparison()
+                .ignoringFields("callback")
+                .isEqualTo(expectedCopyLatestRequest);
+    }
+
+}