Browse Source

Minor refactoring of private method after self review

pull/9965/head
ShvaykaD 2 years ago
parent
commit
4155fcd03f
  1. 26
      rest-client/src/main/java/org/thingsboard/rest/client/RestClient.java

26
rest-client/src/main/java/org/thingsboard/rest/client/RestClient.java

@ -2741,7 +2741,7 @@ public class RestClient implements Closeable {
addPageLinkToParam(params, pageLink); addPageLinkToParam(params, pageLink);
addTenantOnlyAndFullSearchToParams(tenantOnly, fullSearch, params); addTenantOnlyAndFullSearchToParams(tenantOnly, fullSearch, params);
return restTemplate.exchange( return restTemplate.exchange(
baseURL + "/api/widgetsBundles?" + getUrlParams(pageLink) + getWidgetsBundlePageRequestUrlParams(tenantOnly, fullSearch), baseURL + "/api/widgetsBundles?" + getUrlParams(pageLink) + getTenantOnlyAndFullSearchUrlParams(tenantOnly, fullSearch),
HttpMethod.GET, HttpMethod.GET,
HttpEntity.EMPTY, HttpEntity.EMPTY,
new ParameterizedTypeReference<PageData<WidgetsBundle>>() { new ParameterizedTypeReference<PageData<WidgetsBundle>>() {
@ -3776,20 +3776,20 @@ public class RestClient implements Closeable {
return urlParams; return urlParams;
} }
private String getWidgetsBundlePageRequestUrlParams(Boolean tenantOnly, Boolean fullSearch) { private String getWidgetTypeInfoPageRequestUrlParams(Boolean tenantOnly, Boolean fullSearch,
String urlParams = ""; DeprecatedFilter deprecatedFilter,
if (tenantOnly != null) { List<String> widgetTypeList) {
urlParams = "&tenantOnly={tenantOnly}"; String urlParams = getTenantOnlyAndFullSearchUrlParams(tenantOnly, fullSearch);
if (deprecatedFilter != null) {
urlParams += "&deprecatedFilter={deprecatedFilter}";
} }
if (fullSearch != null) { if (!CollectionUtils.isEmpty(widgetTypeList)) {
urlParams += "&fullSearch={fullSearch}"; urlParams += "&widgetTypeList={widgetTypeList}";
} }
return urlParams; return urlParams;
} }
private String getWidgetTypeInfoPageRequestUrlParams(Boolean tenantOnly, Boolean fullSearch, private String getTenantOnlyAndFullSearchUrlParams(Boolean tenantOnly, Boolean fullSearch) {
DeprecatedFilter deprecatedFilter,
List<String> widgetTypeList) {
String urlParams = ""; String urlParams = "";
if (tenantOnly != null) { if (tenantOnly != null) {
urlParams = "&tenantOnly={tenantOnly}"; urlParams = "&tenantOnly={tenantOnly}";
@ -3797,12 +3797,6 @@ public class RestClient implements Closeable {
if (fullSearch != null) { if (fullSearch != null) {
urlParams += "&fullSearch={fullSearch}"; urlParams += "&fullSearch={fullSearch}";
} }
if (deprecatedFilter != null) {
urlParams += "&deprecatedFilter={deprecatedFilter}";
}
if (!CollectionUtils.isEmpty(widgetTypeList)) {
urlParams += "&widgetTypeList={widgetTypeList}";
}
return urlParams; return urlParams;
} }

Loading…
Cancel
Save