From 52d53c952e18dc41fa4c414c62f705a025dcae36 Mon Sep 17 00:00:00 2001 From: Volodymyr Babak Date: Thu, 29 Jun 2017 12:22:37 +0300 Subject: [PATCH] Fixed nullpointerexception --- .../server/controller/DeviceController.java | 11 ++++++++--- .../org/thingsboard/server/dao/JpaDaoTestSuite.java | 3 +-- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/application/src/main/java/org/thingsboard/server/controller/DeviceController.java b/application/src/main/java/org/thingsboard/server/controller/DeviceController.java index 81ddf8e585..f0cde3316f 100644 --- a/application/src/main/java/org/thingsboard/server/controller/DeviceController.java +++ b/application/src/main/java/org/thingsboard/server/controller/DeviceController.java @@ -62,7 +62,12 @@ public class DeviceController extends BaseController { try { device.setTenantId(getCurrentUser().getTenantId()); Device savedDevice = checkNotNull(deviceService.saveDevice(device)); - actorService.onDeviceNameOrTypeUpdate(device.getTenantId(), device.getId(), device.getName(), device.getType()); + actorService + .onDeviceNameOrTypeUpdate( + savedDevice.getTenantId(), + savedDevice.getId(), + savedDevice.getName(), + savedDevice.getType()); return savedDevice; } catch (Exception e) { throw handleException(e); @@ -176,7 +181,7 @@ public class DeviceController extends BaseController { try { TenantId tenantId = getCurrentUser().getTenantId(); TextPageLink pageLink = createPageLink(limit, textSearch, idOffset, textOffset); - if (type != null && type.trim().length()>0) { + if (type != null && type.trim().length() > 0) { return checkNotNull(deviceService.findDevicesByTenantIdAndType(tenantId, type, pageLink)); } else { return checkNotNull(deviceService.findDevicesByTenantId(tenantId, pageLink)); @@ -215,7 +220,7 @@ public class DeviceController extends BaseController { CustomerId customerId = new CustomerId(toUUID(strCustomerId)); checkCustomerId(customerId); TextPageLink pageLink = createPageLink(limit, textSearch, idOffset, textOffset); - if (type != null && type.trim().length()>0) { + if (type != null && type.trim().length() > 0) { return checkNotNull(deviceService.findDevicesByTenantIdAndCustomerIdAndType(tenantId, customerId, type, pageLink)); } else { return checkNotNull(deviceService.findDevicesByTenantIdAndCustomerId(tenantId, customerId, pageLink)); diff --git a/dao/src/test/java/org/thingsboard/server/dao/JpaDaoTestSuite.java b/dao/src/test/java/org/thingsboard/server/dao/JpaDaoTestSuite.java index 7b880fa295..c74aeeff27 100644 --- a/dao/src/test/java/org/thingsboard/server/dao/JpaDaoTestSuite.java +++ b/dao/src/test/java/org/thingsboard/server/dao/JpaDaoTestSuite.java @@ -24,8 +24,7 @@ import java.util.Arrays; @RunWith(ClasspathSuite.class) @ClassnameFilters({ -// "org.thingsboard.server.dao.sql.alarm.", - "org.thingsboard.server.dao.sql.*Test", + "org.thingsboard.server.dao.sql.*Test" }) public class JpaDaoTestSuite {