From 59c88a89ad6ca876f6e218feaaffd7d6ccca7524 Mon Sep 17 00:00:00 2001 From: Andrii Shvaika Date: Thu, 9 Apr 2026 16:37:19 +0300 Subject: [PATCH] fix(iot-hub): fix device review dialog after component refactor - Remove stale iotHubApiService from dialog data (now directly injected) - Fall back to regular detail dialog for items without installState (installed before the review mode feature) --- .../iot-hub/iot-hub-installed-items.component.ts | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/ui-ngx/src/app/modules/home/pages/iot-hub/iot-hub-installed-items.component.ts b/ui-ngx/src/app/modules/home/pages/iot-hub/iot-hub-installed-items.component.ts index 6ddd8bf2ff..7548649d87 100644 --- a/ui-ngx/src/app/modules/home/pages/iot-hub/iot-hub-installed-items.component.ts +++ b/ui-ngx/src/app/modules/home/pages/iot-hub/iot-hub-installed-items.component.ts @@ -255,7 +255,15 @@ export class TbIotHubInstalledItemsComponent implements OnInit, AfterViewInit, O private openDeviceReviewDialog(item: IotHubInstalledItem): void { const descriptor = item.descriptor as DeviceInstalledItemDescriptor; if (!descriptor.installState || !descriptor.selectedConnectivity) { - return; // No install state stored — can't open review + // No install state — fall back to regular detail dialog + this.iotHubApiService.getVersionInfo(item.itemVersionId, {ignoreLoading: true}).subscribe(versionView => { + this.dialog.open(TbIotHubItemDetailDialogComponent, { + panelClass: ['tb-dialog', 'tb-fullscreen-dialog'], + autoFocus: false, + data: { item: versionView, installedItem: item } as IotHubItemDetailDialogData + }); + }); + return; } this.iotHubApiService.getVersionFileData(item.itemVersionId, { ignoreLoading: true }).subscribe({ next: async (blob: Blob) => { @@ -268,7 +276,6 @@ export class TbIotHubInstalledItemsComponent implements OnInit, AfterViewInit, O data: { item: versionView, zipData, - iotHubApiService: this.iotHubApiService, reviewMode: true, selectedConnectivity: descriptor.selectedConnectivity, installState: descriptor.installState