From 5a65ec75fe6dece007277555044770ed8952efd4 Mon Sep 17 00:00:00 2001
From: viktorbasanets <vbasanec@gmail.com>
Date: Thu, 27 Sep 2018 17:07:54 +0300
Subject: [PATCH] Reviewed

---
 .../dao/entityview/EntityViewServiceImpl.java  | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/dao/src/main/java/org/thingsboard/server/dao/entityview/EntityViewServiceImpl.java b/dao/src/main/java/org/thingsboard/server/dao/entityview/EntityViewServiceImpl.java
index a45a6419b1..9fdadcd631 100644
--- a/dao/src/main/java/org/thingsboard/server/dao/entityview/EntityViewServiceImpl.java
+++ b/dao/src/main/java/org/thingsboard/server/dao/entityview/EntityViewServiceImpl.java
@@ -228,17 +228,13 @@ public class EntityViewServiceImpl extends AbstractEntityService implements Enti
                     filteredAttributes =
                             attributeKvEntries.stream()
                                     .filter(attributeKvEntry -> {
-                                        if (entityView.getStartTimeMs() == 0 && entityView.getEndTimeMs() == 0) {
-                                            return true;
-                                        }
-                                        if (entityView.getEndTimeMs() == 0 && entityView.getStartTimeMs() < attributeKvEntry.getLastUpdateTs()) {
-                                            return true;
-                                        }
-                                        if (entityView.getStartTimeMs() == 0 && entityView.getEndTimeMs() > attributeKvEntry.getLastUpdateTs()) {
-                                            return true;
-                                        }
-                                        return entityView.getStartTimeMs() < attributeKvEntry.getLastUpdateTs()
-                                                && entityView.getEndTimeMs() > attributeKvEntry.getLastUpdateTs();
+                                        long startTime = entityView.getStartTimeMs();
+                                        long endTime = entityView.getEndTimeMs();
+                                        long lastUpdateTs = attributeKvEntry.getLastUpdateTs();
+                                        return startTime == 0 && endTime == 0 ||
+                                                (endTime == 0 && startTime < lastUpdateTs) ||
+                                                (startTime == 0 && endTime > lastUpdateTs) ||
+                                                (startTime < lastUpdateTs && endTime > lastUpdateTs);
                                     }).collect(Collectors.toList());
                 }
                 try {