From 5ee50e1e0e2635be9e966eb98ca1c0221994feaf Mon Sep 17 00:00:00 2001 From: Yuriy Lytvynchuk Date: Wed, 28 Sep 2022 10:01:20 +0300 Subject: [PATCH] add private fields refactor test --- .../thingsboard/rule/engine/transform/TbJsonPathNode.java | 8 ++++---- .../rule/engine/transform/TbJsonPathNodeTest.java | 5 ----- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/rule-engine/rule-engine-components/src/main/java/org/thingsboard/rule/engine/transform/TbJsonPathNode.java b/rule-engine/rule-engine-components/src/main/java/org/thingsboard/rule/engine/transform/TbJsonPathNode.java index c601f591fe..ff5b8a1ece 100644 --- a/rule-engine/rule-engine-components/src/main/java/org/thingsboard/rule/engine/transform/TbJsonPathNode.java +++ b/rule-engine/rule-engine-components/src/main/java/org/thingsboard/rule/engine/transform/TbJsonPathNode.java @@ -49,10 +49,10 @@ import java.util.concurrent.ExecutionException; ) public class TbJsonPathNode implements TbNode { - TbJsonPathNodeConfiguration config; - Configuration configurationJsonPath; - JsonPath jsonPath; - String jsonPathValue; + private TbJsonPathNodeConfiguration config; + private Configuration configurationJsonPath; + private JsonPath jsonPath; + private String jsonPathValue; @Override public void init(TbContext ctx, TbNodeConfiguration configuration) throws TbNodeException { diff --git a/rule-engine/rule-engine-components/src/test/java/org/thingsboard/rule/engine/transform/TbJsonPathNodeTest.java b/rule-engine/rule-engine-components/src/test/java/org/thingsboard/rule/engine/transform/TbJsonPathNodeTest.java index 1b1e34e0f5..ae9a8f9fdb 100644 --- a/rule-engine/rule-engine-components/src/test/java/org/thingsboard/rule/engine/transform/TbJsonPathNodeTest.java +++ b/rule-engine/rule-engine-components/src/test/java/org/thingsboard/rule/engine/transform/TbJsonPathNodeTest.java @@ -71,11 +71,6 @@ public class TbJsonPathNodeTest { node.destroy(); } - @Test - void givenDefaultConfig_whenInit_thenOK() { - assertThat(node.config).isEqualTo(config); - } - @Test void givenDefaultConfig_whenInit_thenFail() { config.setJsonPath("");