Browse Source

added try catch to not fail upgrade

pull/8110/head
dashevchenko 4 years ago
parent
commit
63a5a053a2
  1. 24
      application/src/main/java/org/thingsboard/server/service/install/SqlDatabaseUpgradeService.java

24
application/src/main/java/org/thingsboard/server/service/install/SqlDatabaseUpgradeService.java

@ -717,16 +717,22 @@ public class SqlDatabaseUpgradeService implements DatabaseEntitiesUpgradeService
users = userService.findAllUsers(pageLink); users = userService.findAllUsers(pageLink);
for (User user : users.getData()) { for (User user : users.getData()) {
futures.add(dbUpgradeExecutor.submit(() -> { futures.add(dbUpgradeExecutor.submit(() -> {
JsonNode additionalInfo = user.getAdditionalInfo(); try {
if (additionalInfo.isObject() && additionalInfo.has("userPasswordHistory")){ log.info("Migrating password history for user: " + user.getId());
UserCredentials creds = userService.findUserCredentialsByUserId(user.getTenantId(), user.getId()); JsonNode additionalInfo = user.getAdditionalInfo();
if (creds != null) { if (additionalInfo != null && additionalInfo.has("userPasswordHistory")){
creds.setAdditionalInfo(JacksonUtil.newObjectNode().set("userPasswordHistory", additionalInfo.get("userPasswordHistory"))); UserCredentials creds = userService.findUserCredentialsByUserId(user.getTenantId(), user.getId());
userService.saveUserCredentials(user.getTenantId(), creds); if (creds != null) {
creds.setAdditionalInfo(JacksonUtil.newObjectNode().set("userPasswordHistory", additionalInfo.get("userPasswordHistory")));
userService.saveUserCredentials(user.getTenantId(), creds);
}
((ObjectNode) additionalInfo).remove("userPasswordHistory");
userService.saveUser(user);
} }
((ObjectNode) additionalInfo).remove("userPasswordHistory"); } catch (Exception e){
userService.saveUser(user); log.error("Failed to migrate password history for user: " + user.getId(), e);
}})); }
}));
} }
Futures.allAsList(futures).get(); Futures.allAsList(futures).get();
pageLink = pageLink.nextPageLink(); pageLink = pageLink.nextPageLink();

Loading…
Cancel
Save