From 678312830cbff3df7a12cc0ae9a86224602a7ace Mon Sep 17 00:00:00 2001
From: Sergey Matvienko <smatvienko@thingsboard.io>
Date: Tue, 21 Apr 2026 17:06:06 +0200
Subject: [PATCH] chore(build): silence ~200 lines of harmless warnings on
 lts-4.2

Build hygiene for developers who rebuild lts-4.2 frequently: cleans the
pom.xml sources that generate noise without any code change.

- Pin maven-clean-plugin to 3.5.0 (latest stable) via a
  <maven-clean-plugin.version> property, matching the convention already
  used for surefire/install/deploy/jar plugins. Removes 55 "version is
  missing" warnings plus the cascading "Some problems were encountered
  while building the effective model" messages for every child module.
- Extend license-maven-plugin excludes for files that never carry a
  license header: **/lombok.config, **/eslint.config.mjs,
  **/config.monitoring, **/valkey-certs/**, **/data/certs/**, **/*.otf.
  Directory-scoped patterns are used instead of broad extension globs
  (**/*.crt, **/*.key, **/*.pem) so a stray cert dropped outside these
  directories still raises a warning.
- Exclude sjk-jfr5 / sjk-jfr6 / sjk-nps transitive deps from cassandra-all
  in tools/pom.xml. Their published POMs declare system-scope deps against
  unresolved ${jmc5.path}, ${jmc6.path}, ${visualvm.path} properties,
  producing 7 ERROR-level lines on every build. No ThingsBoard code imports
  sjk, jmc, or netbeans profiler classes.

Net impact: 1040 -> 843 WARNING lines, 7 -> 0 ERROR lines. Build still
green. Full categorization of remaining warnings and Tier 2/3 migration
plan is tracked in issue #15481.
---
 pom.xml       |  8 ++++++++
 tools/pom.xml | 18 ++++++++++++++++++
 2 files changed, 26 insertions(+)

diff --git a/pom.xml b/pom.xml
index 409e16cdc9..5604ca39d7 100755
--- a/pom.xml
+++ b/pom.xml
@@ -97,6 +97,7 @@
         <maven-surefire-plugin.version>3.5.4</maven-surefire-plugin.version>
         <maven-install-plugin.version>3.1.4</maven-install-plugin.version>
         <maven-deploy-plugin.version>3.1.4</maven-deploy-plugin.version>
+        <maven-clean-plugin.version>3.5.0</maven-clean-plugin.version>
         <springdoc-swagger.version>2.8.8TB</springdoc-swagger.version>
         <swagger-annotations.version>2.2.30</swagger-annotations.version>
         <spatial4j.version>0.8</spatial4j.version>
@@ -915,6 +916,12 @@
                             <exclude>**/resources/lwm2m/models/**</exclude>
                             <exclude>src/main/data/resources/**</exclude>
                             <exclude>.claude/**</exclude>
+                            <exclude>**/lombok.config</exclude>
+                            <exclude>**/eslint.config.mjs</exclude>
+                            <exclude>**/config.monitoring</exclude>
+                            <exclude>**/valkey-certs/**</exclude>
+                            <exclude>**/data/certs/**</exclude>
+                            <exclude>**/*.otf</exclude>
                         </excludes>
                         <mapping>
                             <proto>JAVADOC_STYLE</proto>
@@ -967,6 +974,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-clean-plugin</artifactId>
+                <version>${maven-clean-plugin.version}</version>
                 <inherited>false</inherited>
                 <configuration>
                     <filesets>
diff --git a/tools/pom.xml b/tools/pom.xml
index a2820d48f6..46c56c634b 100644
--- a/tools/pom.xml
+++ b/tools/pom.xml
@@ -54,6 +54,24 @@
         <dependency>
             <groupId>org.apache.cassandra</groupId>
             <artifactId>cassandra-all</artifactId>
+            <exclusions>
+                <!-- These sjk-* artifacts pull in com.jrockit.mc / com.oracle.jmc / jdk.org.netbeans
+                     system-scope dependencies with unresolved systemPath properties, which produces
+                     ERROR-level Maven warnings on every build. No ThingsBoard code imports from sjk,
+                     jmc, or netbeans profiler, so excluding them is safe. -->
+                <exclusion>
+                    <groupId>org.perfkit.sjk.parsers</groupId>
+                    <artifactId>sjk-jfr5</artifactId>
+                </exclusion>
+                <exclusion>
+                    <groupId>org.perfkit.sjk.parsers</groupId>
+                    <artifactId>sjk-jfr6</artifactId>
+                </exclusion>
+                <exclusion>
+                    <groupId>org.perfkit.sjk.parsers</groupId>
+                    <artifactId>sjk-nps</artifactId>
+                </exclusion>
+            </exclusions>
         </dependency>
         <dependency>
             <groupId>at.yawk.lz4</groupId>