fixed device session closing: should close every device session if message id wrong

common/transport/mqtt/src/main/java/org/thingsboard/server/transport/mqtt/session/AbstractGatewaySessionHandler.java

@@ -845,27 +845,31 @@ public abstract class AbstractGatewaySessionHandler<T extends AbstractGatewayDev
                         log.trace("[{}][{}][{}] Wrong msg id: [{}]", gateway.getTenantId(), gateway.getDeviceId(), sessionId, msgId);
                         ctx.writeAndFlush(MqttTransportHandler.createMqttPubAckMsg(
                                 deviceSessionCtx, msgId, MqttReasonCodes.PubAck.UNSPECIFIED_ERROR.byteValue()));
-                        closeDeviceSession(deviceName, MqttReasonCodes.Disconnect.MALFORMED_PACKET);
                     }
                 }
+                if (msgId <= 0) {
+                    closeDeviceSession(deviceName, MqttReasonCodes.Disconnect.MALFORMED_PACKET);
+                }
             }
 
             @Override
             public void onError(Throwable e) {
                 log.trace("[{}][{}][{}] Failed to publish msg: [{}] for device: [{}]", gateway.getTenantId(), gateway.getDeviceId(), sessionId, msg, deviceName, e);
-                if (ackSent.compareAndSet(false, true)) {
-                    if (e instanceof TbRateLimitsException) {
+                if (e instanceof TbRateLimitsException) {
+                    if (ackSent.compareAndSet(false, true)) {
                         ctx.writeAndFlush(MqttTransportHandler.createMqttPubAckMsg(
                                 deviceSessionCtx, msgId, MqttReasonCodes.PubAck.QUOTA_EXCEEDED.byteValue()));
-                        closeDeviceSession(deviceName, MqttReasonCodes.Disconnect.MESSAGE_RATE_TOO_HIGH);
-                    } else {
+                        ctx.close();
+                    }
+                    closeDeviceSession(deviceName, MqttReasonCodes.Disconnect.MESSAGE_RATE_TOO_HIGH);
+                } else {
+                    if (ackSent.compareAndSet(false, true)) {
                         ctx.writeAndFlush(MqttTransportHandler.createMqttPubAckMsg(
                                 deviceSessionCtx, msgId, MqttReasonCodes.PubAck.UNSPECIFIED_ERROR.byteValue()));
-                        closeDeviceSession(deviceName, MqttReasonCodes.Disconnect.UNSPECIFIED_ERROR);
+                        ctx.close();
                     }
-                    ctx.close();
+                    closeDeviceSession(deviceName, MqttReasonCodes.Disconnect.UNSPECIFIED_ERROR);
                 }
-                remaining.set(0);
             }
         };
     }