Browse Source

Small refactoring

pull/3557/head
vzikratyi 6 years ago
parent
commit
6e7d0c633f
  1. 2
      application/src/main/java/org/thingsboard/server/controller/OAuth2Controller.java
  2. 2
      application/src/main/java/org/thingsboard/server/service/security/auth/oauth2/Oauth2AuthenticationSuccessHandler.java
  3. 2
      common/dao-api/src/main/java/org/thingsboard/server/dao/oauth2/OAuth2Service.java
  4. 2
      dao/src/main/java/org/thingsboard/server/dao/oauth2/HybridClientRegistrationRepository.java
  5. 2
      dao/src/main/java/org/thingsboard/server/dao/oauth2/OAuth2ServiceImpl.java

2
application/src/main/java/org/thingsboard/server/controller/OAuth2Controller.java

@ -39,7 +39,7 @@ public class OAuth2Controller extends BaseController {
@ResponseBody
public OAuth2ClientRegistration getClientRegistrationById(@PathVariable(REGISTRATION_ID) String registrationId) throws ThingsboardException {
try {
return oauth2Service.getClientRegistrationByRegistrationId(registrationId);
return oauth2Service.getClientRegistration(registrationId);
} catch (Exception e) {
throw handleException(e);
}

2
application/src/main/java/org/thingsboard/server/service/security/auth/oauth2/Oauth2AuthenticationSuccessHandler.java

@ -64,7 +64,7 @@ public class Oauth2AuthenticationSuccessHandler extends SimpleUrlAuthenticationS
try {
OAuth2AuthenticationToken token = (OAuth2AuthenticationToken) authentication;
OAuth2ClientRegistration clientRegistration = oAuth2Service.getClientRegistrationByRegistrationId(token.getAuthorizedClientRegistrationId());
OAuth2ClientRegistration clientRegistration = oAuth2Service.getClientRegistration(token.getAuthorizedClientRegistrationId());
OAuth2ClientMapper mapper = oauth2ClientMapperProvider.getOAuth2ClientMapperByType(clientRegistration.getMapperConfig().getType());
SecurityUser securityUser = mapper.getOrCreateUserByClientPrincipal(token, clientRegistration.getMapperConfig());

2
common/dao-api/src/main/java/org/thingsboard/server/dao/oauth2/OAuth2Service.java

@ -21,7 +21,7 @@ import org.thingsboard.server.common.data.oauth2.OAuth2ClientRegistration;
import java.util.List;
public interface OAuth2Service {
OAuth2ClientRegistration getClientRegistrationByRegistrationId(String registrationId);
OAuth2ClientRegistration getClientRegistration(String registrationId);
List<OAuth2ClientInfo> getOAuth2Clients();
}

2
dao/src/main/java/org/thingsboard/server/dao/oauth2/HybridClientRegistrationRepository.java

@ -18,7 +18,7 @@ public class HybridClientRegistrationRepository implements ClientRegistrationRep
@Override
public ClientRegistration findByRegistrationId(String registrationId) {
OAuth2ClientRegistration localClientRegistration = oAuth2Service.getClientRegistrationByRegistrationId(registrationId);
OAuth2ClientRegistration localClientRegistration = oAuth2Service.getClientRegistration(registrationId);
return localClientRegistration == null ?
null : toSpringClientRegistration(localClientRegistration);
}

2
dao/src/main/java/org/thingsboard/server/dao/oauth2/OAuth2ServiceImpl.java

@ -53,7 +53,7 @@ public class OAuth2ServiceImpl implements OAuth2Service {
}
@Override
public OAuth2ClientRegistration getClientRegistrationByRegistrationId(String registrationId) {
public OAuth2ClientRegistration getClientRegistration(String registrationId) {
if (oauth2Configuration == null || !oauth2Configuration.isEnabled()) return null;
OAuth2Client oAuth2Client = oauth2Configuration.getClients() == null ? null : oauth2Configuration.getClients().get(registrationId);
if (oAuth2Client != null){

Loading…
Cancel
Save