Browse Source

minor refactoring

pull/11231/head
dashevchenko 2 years ago
parent
commit
6f833a3b18
  1. 2
      application/src/main/java/org/thingsboard/server/service/entitiy/domain/DefaultTbDomainService.java
  2. 2
      application/src/main/java/org/thingsboard/server/service/entitiy/mobile/DefaultTbMobileAppService.java
  3. 2
      dao/src/main/java/org/thingsboard/server/dao/oauth2/OAuth2ClientDao.java
  4. 2
      dao/src/main/java/org/thingsboard/server/dao/oauth2/OAuth2ClientServiceImpl.java
  5. 2
      dao/src/main/java/org/thingsboard/server/dao/sql/oauth2/JpaOAuth2ClientDao.java

2
application/src/main/java/org/thingsboard/server/service/entitiy/domain/DefaultTbDomainService.java

@ -42,7 +42,7 @@ public class DefaultTbDomainService extends AbstractTbEntityService implements T
TenantId tenantId = domain.getTenantId(); TenantId tenantId = domain.getTenantId();
try { try {
Domain savedDomain = checkNotNull(domainService.saveDomain(tenantId, domain)); Domain savedDomain = checkNotNull(domainService.saveDomain(tenantId, domain));
if (!CollectionUtils.isEmpty(oAuth2Clients)) { if (CollectionUtils.isNotEmpty(oAuth2Clients)) {
domainService.updateOauth2Clients(domain.getTenantId(), savedDomain.getId(), oAuth2Clients); domainService.updateOauth2Clients(domain.getTenantId(), savedDomain.getId(), oAuth2Clients);
} }
logEntityActionService.logEntityAction(tenantId, savedDomain.getId(), savedDomain, actionType, user, oAuth2Clients); logEntityActionService.logEntityAction(tenantId, savedDomain.getId(), savedDomain, actionType, user, oAuth2Clients);

2
application/src/main/java/org/thingsboard/server/service/entitiy/mobile/DefaultTbMobileAppService.java

@ -42,7 +42,7 @@ public class DefaultTbMobileAppService extends AbstractTbEntityService implement
TenantId tenantId = mobileApp.getTenantId(); TenantId tenantId = mobileApp.getTenantId();
try { try {
MobileApp savedMobileApp = checkNotNull(mobileAppService.saveMobileApp(tenantId, mobileApp)); MobileApp savedMobileApp = checkNotNull(mobileAppService.saveMobileApp(tenantId, mobileApp));
if (!CollectionUtils.isEmpty(oauth2Clients)) { if (CollectionUtils.isNotEmpty(oauth2Clients)) {
mobileAppService.updateOauth2Clients(tenantId, savedMobileApp.getId(), oauth2Clients); mobileAppService.updateOauth2Clients(tenantId, savedMobileApp.getId(), oauth2Clients);
} }
logEntityActionService.logEntityAction(tenantId, savedMobileApp.getId(), savedMobileApp, actionType, user); logEntityActionService.logEntityAction(tenantId, savedMobileApp.getId(), savedMobileApp, actionType, user);

2
dao/src/main/java/org/thingsboard/server/dao/oauth2/OAuth2ClientDao.java

@ -32,7 +32,7 @@ public interface OAuth2ClientDao extends Dao<OAuth2Client> {
List<OAuth2Client> findEnabledByDomainName(String domainName); List<OAuth2Client> findEnabledByDomainName(String domainName);
List<OAuth2Client> findEnabledByPckNameAndPlatformType(String pkgName, PlatformType platformType); List<OAuth2Client> findEnabledByPkgNameAndPlatformType(String pkgName, PlatformType platformType);
List<OAuth2Client> findByDomainId(UUID domainId); List<OAuth2Client> findByDomainId(UUID domainId);

2
dao/src/main/java/org/thingsboard/server/dao/oauth2/OAuth2ClientServiceImpl.java

@ -61,7 +61,7 @@ public class OAuth2ClientServiceImpl extends AbstractEntityService implements OA
@Override @Override
public List<OAuth2ClientLoginInfo> findOAuth2ClientLoginInfosByMobilePkgNameAndPlatformType(String pkgName, PlatformType platformType) { public List<OAuth2ClientLoginInfo> findOAuth2ClientLoginInfosByMobilePkgNameAndPlatformType(String pkgName, PlatformType platformType) {
log.trace("Executing findOAuth2ClientLoginInfosByMobilePkgNameAndPlatformType pkgName=[{}] platformType=[{}]",pkgName, platformType); log.trace("Executing findOAuth2ClientLoginInfosByMobilePkgNameAndPlatformType pkgName=[{}] platformType=[{}]",pkgName, platformType);
return oauth2ClientDao.findEnabledByPckNameAndPlatformType(pkgName, platformType) return oauth2ClientDao.findEnabledByPkgNameAndPlatformType(pkgName, platformType)
.stream() .stream()
.map(OAuth2Utils::toClientLoginInfo) .map(OAuth2Utils::toClientLoginInfo)
.collect(Collectors.toList()); .collect(Collectors.toList());

2
dao/src/main/java/org/thingsboard/server/dao/sql/oauth2/JpaOAuth2ClientDao.java

@ -64,7 +64,7 @@ public class JpaOAuth2ClientDao extends JpaAbstractDao<OAuth2ClientEntity, OAuth
} }
@Override @Override
public List<OAuth2Client> findEnabledByPckNameAndPlatformType(String pkgName, PlatformType platformType) { public List<OAuth2Client> findEnabledByPkgNameAndPlatformType(String pkgName, PlatformType platformType) {
return DaoUtil.convertDataList(repository.findEnabledByPkgNameAndPlatformType(pkgName, return DaoUtil.convertDataList(repository.findEnabledByPkgNameAndPlatformType(pkgName,
platformType != null ? platformType.name() : null)); platformType != null ? platformType.name() : null));
} }

Loading…
Cancel
Save