From 78b43c04aae03cf34187f4df40bc7e2fa2b42707 Mon Sep 17 00:00:00 2001
From: rusikv <rvasylkiv@thingsboard.io>
Date: Mon, 19 Aug 2024 13:47:49 +0300
Subject: [PATCH] UI: fixed client form blocking save, mobile app enabled by
 default

---
 .../src/app/modules/home/pages/admin/admin-routing.module.ts  | 4 ++--
 .../home/pages/admin/oauth2/clients/client.component.ts       | 1 +
 .../pages/admin/oauth2/mobile-apps/mobile-app.component.ts    | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/ui-ngx/src/app/modules/home/pages/admin/admin-routing.module.ts b/ui-ngx/src/app/modules/home/pages/admin/admin-routing.module.ts
index 0b6ed5a2be..c1d32a44c8 100644
--- a/ui-ngx/src/app/modules/home/pages/admin/admin-routing.module.ts
+++ b/ui-ngx/src/app/modules/home/pages/admin/admin-routing.module.ts
@@ -15,8 +15,8 @@
 ///
 
 import { inject, NgModule } from '@angular/core';
-import { ActivatedRouteSnapshot, ResolveFn, RouterStateSnapshot } from '@angular/router';
-import { RouterModule, Routes } from '@angular/router';
+import { ActivatedRouteSnapshot, Resolve, ResolveFn, RouterModule, RouterStateSnapshot, Routes } from '@angular/router';
+
 import { MailServerComponent } from '@modules/home/pages/admin/mail-server.component';
 import { ConfirmOnExitGuard } from '@core/guards/confirm-on-exit.guard';
 import { Authority } from '@shared/models/authority.enum';
diff --git a/ui-ngx/src/app/modules/home/pages/admin/oauth2/clients/client.component.ts b/ui-ngx/src/app/modules/home/pages/admin/oauth2/clients/client.component.ts
index 90f0b17403..cf60b3ed51 100644
--- a/ui-ngx/src/app/modules/home/pages/admin/oauth2/clients/client.component.ts
+++ b/ui-ngx/src/app/modules/home/pages/admin/oauth2/clients/client.component.ts
@@ -278,6 +278,7 @@ export class ClientComponent extends EntityComponent<OAuth2Client, PageLink, OAu
         mapperConfig.addControl('basic', this.formBasicGroup(predefinedValue?.basic));
       } else if (predefinedValue?.basic) {
         mapperConfig.get('basic').patchValue(predefinedValue.basic, {emitEvent: false});
+        mapperConfig.get('basic.tenantNameStrategy').updateValueAndValidity({onlySelf: true});
       }
       if (type === MapperType.GITHUB) {
         mapperConfig.get('basic.emailAttributeKey').disable();
diff --git a/ui-ngx/src/app/modules/home/pages/admin/oauth2/mobile-apps/mobile-app.component.ts b/ui-ngx/src/app/modules/home/pages/admin/oauth2/mobile-apps/mobile-app.component.ts
index 07ee9b7bfc..0baa72f5f7 100644
--- a/ui-ngx/src/app/modules/home/pages/admin/oauth2/mobile-apps/mobile-app.component.ts
+++ b/ui-ngx/src/app/modules/home/pages/admin/oauth2/mobile-apps/mobile-app.component.ts
@@ -57,7 +57,7 @@ export class MobileAppComponent extends EntityComponent<MobileAppInfo> {
       pkgName: [entity?.pkgName ? entity.pkgName : '', [Validators.required]],
       appSecret: [entity?.appSecret ? entity.appSecret : btoa(randomAlphanumeric(64)),
         [Validators.required, this.base64Format]],
-      oauth2Enabled: isDefinedAndNotNull(entity?.oauth2Enabled) ? entity.oauth2Enabled : false,
+      oauth2Enabled: isDefinedAndNotNull(entity?.oauth2Enabled) ? entity.oauth2Enabled : true,
       oauth2ClientInfos: entity?.oauth2ClientInfos ? entity.oauth2ClientInfos.map(info => info.id.id) : []
     });
   }