From 7a19dee3eb4a441bf17dfd99e9978351bf5862fa Mon Sep 17 00:00:00 2001
From: Igor Kulikov <ikulikov@thingsboard.io>
Date: Fri, 3 Jul 2020 12:15:11 +0300
Subject: [PATCH] UI: Dynamic filter value configuration

---
 .../data/query/FilterPredicateValue.java      | 16 ++++++--
 ...lex-filter-predicate-dialog.component.html |  2 +-
 .../filter-predicate-value.component.html     | 38 ++++++++++++++++++-
 .../filter-predicate-value.component.ts       | 26 +++++++++++--
 .../filter/filters-edit-panel.component.html  |  4 +-
 .../filter/key-filter-dialog.component.html   |  2 +-
 .../filter/user-filter-dialog.component.ts    | 11 ++++--
 .../app/shared/models/query/query.models.ts   |  1 +
 .../assets/locale/locale.constant-en_US.json  |  8 +++-
 9 files changed, 90 insertions(+), 18 deletions(-)

diff --git a/common/data/src/main/java/org/thingsboard/server/common/data/query/FilterPredicateValue.java b/common/data/src/main/java/org/thingsboard/server/common/data/query/FilterPredicateValue.java
index b2611f7216..8897d35586 100644
--- a/common/data/src/main/java/org/thingsboard/server/common/data/query/FilterPredicateValue.java
+++ b/common/data/src/main/java/org/thingsboard/server/common/data/query/FilterPredicateValue.java
@@ -27,25 +27,33 @@ public class FilterPredicateValue<T> {
     @Getter
     private final T defaultValue;
     @Getter
+    private final T userValue;
+    @Getter
     private final DynamicValue<T> dynamicValue;
 
     public FilterPredicateValue(T defaultValue) {
-        this(defaultValue, null);
+        this(defaultValue, null, null);
     }
 
     @JsonCreator
     public FilterPredicateValue(@JsonProperty("defaultValue") T defaultValue,
+                                @JsonProperty("userValue") T userValue,
                                 @JsonProperty("dynamicValue") DynamicValue<T> dynamicValue) {
         this.defaultValue = defaultValue;
+        this.userValue = userValue;
         this.dynamicValue = dynamicValue;
     }
 
     @JsonIgnore
     public T getValue() {
-        if (this.dynamicValue != null && this.dynamicValue.getResolvedValue() != null) {
-            return this.dynamicValue.getResolvedValue();
+        if (this.userValue != null) {
+            return this.userValue;
         } else {
-            return defaultValue;
+            if (this.dynamicValue != null && this.dynamicValue.getResolvedValue() != null) {
+                return this.dynamicValue.getResolvedValue();
+            } else {
+                return defaultValue;
+            }
         }
     }
 
diff --git a/ui-ngx/src/app/modules/home/components/filter/complex-filter-predicate-dialog.component.html b/ui-ngx/src/app/modules/home/components/filter/complex-filter-predicate-dialog.component.html
index 32fc06a2e1..fe0b217063 100644
--- a/ui-ngx/src/app/modules/home/components/filter/complex-filter-predicate-dialog.component.html
+++ b/ui-ngx/src/app/modules/home/components/filter/complex-filter-predicate-dialog.component.html
@@ -15,7 +15,7 @@
     limitations under the License.
 
 -->
-<form [formGroup]="complexFilterFormGroup" (ngSubmit)="save()" style="width: 700px;">
+<form [formGroup]="complexFilterFormGroup" (ngSubmit)="save()" style="width: 900px;">
   <mat-toolbar color="primary">
     <h2 translate>filter.complex-filter</h2>
     <span fxFlex></span>
diff --git a/ui-ngx/src/app/modules/home/components/filter/filter-predicate-value.component.html b/ui-ngx/src/app/modules/home/components/filter/filter-predicate-value.component.html
index c97ee2a100..e9e38c71f5 100644
--- a/ui-ngx/src/app/modules/home/components/filter/filter-predicate-value.component.html
+++ b/ui-ngx/src/app/modules/home/components/filter/filter-predicate-value.component.html
@@ -16,7 +16,7 @@
 
 -->
 <div fxFlex fxLayout="row" fxLayoutAlign="start center" fxLayoutGap="8px" [formGroup]="filterPredicateValueFormGroup">
-  <div fxFlex fxLayout="column">
+  <div fxFlex fxLayout="column" [fxShow]="!dynamicMode">
     <div fxFlex fxLayout="column" [ngSwitch]="valueType">
       <ng-template [ngSwitchCase]="valueTypeEnum.STRING">
         <mat-form-field floatLabel="always" hideRequiredMarker fxFlex class="mat-block">
@@ -43,6 +43,40 @@
         </mat-checkbox>
       </ng-template>
     </div>
-    <div class="tb-hint">Default value</div>
+    <div class="tb-hint" translate>filter.default-value</div>
   </div>
+  <div fxFlex fxLayout="column" [fxShow]="dynamicMode">
+    <div fxFlex formGroupName="dynamicValue" fxLayout="row" fxLayoutAlign="start center" fxLayoutGap="8px">
+      <div fxFlex fxLayout="column">
+        <mat-form-field floatLabel="always" hideRequiredMarker fxFlex class="mat-block">
+          <mat-label></mat-label>
+          <mat-select formControlName="sourceType" placeholder="{{'filter.dynamic-source-type' | translate}}">
+            <mat-option [value]="null">
+              {{'filter.no-dynamic-value' | translate}}
+            </mat-option>
+            <mat-option *ngFor="let sourceType of dynamicValueSourceTypes" [value]="sourceType">
+              {{dynamicValueSourceTypeTranslations.get(dynamicValueSourceTypeEnum[sourceType]) | translate}}
+            </mat-option>
+          </mat-select>
+        </mat-form-field>
+        <div class="tb-hint" translate>filter.dynamic-source-type</div>
+      </div>
+      <div fxFlex fxLayout="column">
+        <mat-form-field floatLabel="always" hideRequiredMarker fxFlex class="mat-block">
+          <mat-label></mat-label>
+          <input matInput formControlName="sourceAttribute" placeholder="{{'filter.source-attribute' | translate}}">
+        </mat-form-field>
+        <div class="tb-hint" translate>filter.source-attribute</div>
+      </div>
+    </div>
+  </div>
+  <button mat-icon-button
+          class="mat-elevation-z1 tb-mat-32"
+          color="primary"
+          type="button"
+          matTooltip="{{ (dynamicMode ? 'filter.switch-to-default-value' : 'filter.switch-to-dynamic-value') | translate }}"
+          matTooltipPosition="above"
+          (click)="dynamicMode = !dynamicMode">
+    <mat-icon class="tb-mat-20" [svgIcon]="dynamicMode ? 'mdi:numeric' : 'mdi:variable'"></mat-icon>
+  </button>
 </div>
diff --git a/ui-ngx/src/app/modules/home/components/filter/filter-predicate-value.component.ts b/ui-ngx/src/app/modules/home/components/filter/filter-predicate-value.component.ts
index 4997d270db..548137976e 100644
--- a/ui-ngx/src/app/modules/home/components/filter/filter-predicate-value.component.ts
+++ b/ui-ngx/src/app/modules/home/components/filter/filter-predicate-value.component.ts
@@ -23,7 +23,12 @@ import {
   ValidatorFn,
   Validators
 } from '@angular/forms';
-import { EntityKeyValueType, FilterPredicateValue } from '@shared/models/query/query.models';
+import {
+  DynamicValueSourceType,
+  dynamicValueSourceTypeTranslationMap,
+  EntityKeyValueType,
+  FilterPredicateValue
+} from '@shared/models/query/query.models';
 
 @Component({
   selector: 'tb-filter-predicate-value',
@@ -46,8 +51,14 @@ export class FilterPredicateValueComponent implements ControlValueAccessor, OnIn
 
   valueTypeEnum = EntityKeyValueType;
 
+  dynamicValueSourceTypes = Object.keys(DynamicValueSourceType);
+  dynamicValueSourceTypeEnum = DynamicValueSourceType;
+  dynamicValueSourceTypeTranslations = dynamicValueSourceTypeTranslationMap;
+
   filterPredicateValueFormGroup: FormGroup;
 
+  dynamicMode = false;
+
   private propagateChange = null;
 
   constructor(private fb: FormBuilder) {
@@ -83,6 +94,13 @@ export class FilterPredicateValueComponent implements ControlValueAccessor, OnIn
         }
       )
     });
+    this.filterPredicateValueFormGroup.get('dynamicValue').get('sourceType').valueChanges.subscribe(
+      (sourceType) => {
+        if (!sourceType) {
+          this.filterPredicateValueFormGroup.get('dynamicValue').get('sourceAttribute').patchValue(null, {emitEvent: false});
+        }
+      }
+    );
     this.filterPredicateValueFormGroup.valueChanges.subscribe(() => {
       this.updateModel();
     });
@@ -106,8 +124,10 @@ export class FilterPredicateValueComponent implements ControlValueAccessor, OnIn
 
   writeValue(predicateValue: FilterPredicateValue<string | number | boolean>): void {
     this.filterPredicateValueFormGroup.get('defaultValue').patchValue(predicateValue.defaultValue, {emitEvent: false});
-    this.filterPredicateValueFormGroup.get('dynamicValue').patchValue(predicateValue.dynamicValue ?
-      predicateValue.dynamicValue : { sourceType: null, sourceAttribute: null }, {emitEvent: false});
+    this.filterPredicateValueFormGroup.get('dynamicValue').get('sourceType').patchValue(predicateValue.dynamicValue ?
+      predicateValue.dynamicValue.sourceType : null, {emitEvent: false});
+    this.filterPredicateValueFormGroup.get('dynamicValue').get('sourceAttribute').patchValue(predicateValue.dynamicValue ?
+      predicateValue.dynamicValue.sourceAttribute : null, {emitEvent: false});
   }
 
   private updateModel() {
diff --git a/ui-ngx/src/app/modules/home/components/filter/filters-edit-panel.component.html b/ui-ngx/src/app/modules/home/components/filter/filters-edit-panel.component.html
index a1d1822a6b..3de6b75bc4 100644
--- a/ui-ngx/src/app/modules/home/components/filter/filters-edit-panel.component.html
+++ b/ui-ngx/src/app/modules/home/components/filter/filters-edit-panel.component.html
@@ -16,7 +16,7 @@
 
 -->
 <div fxLayout="column" class="mat-content mat-padding">
-  <div fxLayout="column" *ngFor="let filter of filtersInfo | keyvalue">
+  <div fxLayout="column" *ngFor="let filter of filtersInfo | keyvalue; let last = last">
     <div fxFlex fxLayout="row" fxLayoutAlign="start center">
       <mat-label fxFlex>{{filter.value.filter}}</mat-label>
       <button mat-icon-button color="primary"
@@ -28,6 +28,6 @@
         <mat-icon>edit</mat-icon>
       </button>
     </div>
-    <mat-divider></mat-divider>
+    <mat-divider *ngIf="!last"></mat-divider>
   </div>
 </div>
diff --git a/ui-ngx/src/app/modules/home/components/filter/key-filter-dialog.component.html b/ui-ngx/src/app/modules/home/components/filter/key-filter-dialog.component.html
index 4a555eff2f..c69c74c45f 100644
--- a/ui-ngx/src/app/modules/home/components/filter/key-filter-dialog.component.html
+++ b/ui-ngx/src/app/modules/home/components/filter/key-filter-dialog.component.html
@@ -15,7 +15,7 @@
     limitations under the License.
 
 -->
-<form [formGroup]="keyFilterFormGroup" (ngSubmit)="save()" style="width: 700px;">
+<form [formGroup]="keyFilterFormGroup" (ngSubmit)="save()" style="width: 900px;">
   <mat-toolbar color="primary">
     <h2>{{(data.isAdd ? 'filter.add-key-filter' : 'filter.edit-key-filter') | translate}}</h2>
     <span fxFlex></span>
diff --git a/ui-ngx/src/app/modules/home/components/filter/user-filter-dialog.component.ts b/ui-ngx/src/app/modules/home/components/filter/user-filter-dialog.component.ts
index 58634d7424..d743058de5 100644
--- a/ui-ngx/src/app/modules/home/components/filter/user-filter-dialog.component.ts
+++ b/ui-ngx/src/app/modules/home/components/filter/user-filter-dialog.component.ts
@@ -33,10 +33,11 @@ import { DialogComponent } from '@app/shared/components/dialog.component';
 import { TranslateService } from '@ngx-translate/core';
 import {
   EntityKeyValueType,
-  Filter,
+  Filter, FilterPredicateValue,
   filterToUserFilterInfoList,
   UserFilterInputInfo
 } from '@shared/models/query/query.models';
+import { isDefinedAndNotNull } from '@core/utils';
 
 export interface UserFilterDialogData {
   filter: Filter;
@@ -81,15 +82,17 @@ export class UserFilterDialogComponent extends DialogComponent<UserFilterDialogC
   }
 
   private createUserInputFormControl(userInput: UserFilterInputInfo): AbstractControl {
+    const predicateValue: FilterPredicateValue<string | number | boolean> = (userInput.info.keyFilterPredicate as any).value;
+    const value = isDefinedAndNotNull(predicateValue.userValue) ? predicateValue.userValue : predicateValue.defaultValue;
     const userInputControl = this.fb.group({
       label: [userInput.label],
       valueType: [userInput.valueType],
-      value: [(userInput.info.keyFilterPredicate as any).value.defaultValue,
+      value: [value,
         userInput.valueType === EntityKeyValueType.NUMERIC ||
         userInput.valueType === EntityKeyValueType.DATE_TIME  ? [Validators.required] : []]
     });
-    userInputControl.get('value').valueChanges.subscribe(value => {
-      (userInput.info.keyFilterPredicate as any).value.defaultValue = value;
+    userInputControl.get('value').valueChanges.subscribe(userValue => {
+      (userInput.info.keyFilterPredicate as any).value.userValue = userValue;
     });
     return userInputControl;
   }
diff --git a/ui-ngx/src/app/shared/models/query/query.models.ts b/ui-ngx/src/app/shared/models/query/query.models.ts
index d9bd0ca15f..f45c79967e 100644
--- a/ui-ngx/src/app/shared/models/query/query.models.ts
+++ b/ui-ngx/src/app/shared/models/query/query.models.ts
@@ -255,6 +255,7 @@ export interface DynamicValue<T> {
 
 export interface FilterPredicateValue<T> {
   defaultValue: T;
+  userValue?: T;
   dynamicValue?: DynamicValue<T>;
 }
 
diff --git a/ui-ngx/src/assets/locale/locale.constant-en_US.json b/ui-ngx/src/assets/locale/locale.constant-en_US.json
index 0a97e56e96..3a145894ed 100644
--- a/ui-ngx/src/assets/locale/locale.constant-en_US.json
+++ b/ui-ngx/src/assets/locale/locale.constant-en_US.json
@@ -1230,7 +1230,13 @@
          "time": "Time",
          "current-tenant": "Current tenant",
          "current-customer": "Current customer",
-         "current-user": "Current user"
+         "current-user": "Current user",
+         "default-value": "Default value",
+         "dynamic-source-type": "Dynamic source type",
+         "no-dynamic-value": "No dynamic value",
+         "source-attribute": "Source attribute",
+         "switch-to-dynamic-value": "Switch to dynamic value",
+         "switch-to-default-value": "Switch to default value"
     },
     "fullscreen": {
         "expand": "Expand to fullscreen",