Refactored logEntityActionService calls in DefaultTbAlarmService to handle null alarmOriginatorId gracefully; updated corresponding unit tests.

Signed-off-by: Oleksandra Matviienko <al.zzzeebra@gmail.com>

application/src/main/java/org/thingsboard/server/service/entitiy/alarm/DefaultTbAlarmService.java

@@ -203,12 +203,12 @@ public class DefaultTbAlarmService extends AbstractTbEntityService implements Tb
         try {
             deleted = alarmSubscriptionService.deleteAlarm(tenantId, alarmId);
         } catch (Exception e) {
-            logEntityActionService.logEntityAction(tenantId, alarmOriginatorId, ActionType.ALARM_DELETE, user, e, alarmId);
+            logEntityActionService.logEntityAction(tenantId, alarmOriginatorId == null ? alarmId: alarmOriginatorId, ActionType.ALARM_DELETE, user, e, alarmId);
             throw e;
         }
 
         if (deleted) {
-            logEntityActionService.logEntityAction(tenantId, alarmOriginatorId, alarm, alarm.getCustomerId(), ActionType.ALARM_DELETE, user, alarmId);
+            logEntityActionService.logEntityAction(tenantId, alarmOriginatorId == null ? alarmId: alarmOriginatorId, alarm, alarm.getCustomerId(), ActionType.ALARM_DELETE, user, alarmId);
         }
 
         return deleted;

application/src/test/java/org/thingsboard/server/service/entitiy/alarm/DefaultTbAlarmServiceTest.java

@@ -203,7 +203,7 @@ class DefaultTbAlarmServiceTest {
                 .isInstanceOf(RuntimeException.class)
                 .hasMessage("failed to delete alarm");
 
-        verify(logEntityActionService).logEntityAction(tenantId, new DeviceId(EntityId.NULL_UUID), ActionType.ALARM_DELETE, user, exception, alarm.getId());
+        verify(logEntityActionService).logEntityAction(tenantId, alarmOriginator, ActionType.ALARM_DELETE, user, exception, alarm.getId());
         verify(alarmSubscriptionService).deleteAlarm(tenantId, alarm.getId());
     }