From e223dda96f5ad3005d6a3c408337d62cdb10e341 Mon Sep 17 00:00:00 2001 From: Sergey Matvienko Date: Fri, 6 Aug 2021 13:53:35 +0300 Subject: [PATCH 1/4] test scope: dependency upgrade a refactor for all POMs in project --- application/pom.xml | 24 ++--- common/actor/pom.xml | 13 ++- common/cache/pom.xml | 13 ++- common/dao-api/pom.xml | 13 ++- common/data/pom.xml | 15 ++- common/message/pom.xml | 13 ++- common/queue/pom.xml | 12 +-- common/stats/pom.xml | 14 ++- common/transport/coap/pom.xml | 8 +- common/transport/http/pom.xml | 8 +- common/transport/lwm2m/pom.xml | 8 +- common/transport/mqtt/pom.xml | 9 +- common/transport/transport-api/pom.xml | 13 ++- common/util/pom.xml | 12 +-- dao/pom.xml | 24 ++--- msa/black-box-tests/pom.xml | 11 +-- pom.xml | 101 ++++++++++++++------- rule-engine/rule-engine-api/pom.xml | 14 ++- rule-engine/rule-engine-components/pom.xml | 21 +++-- transport/coap/pom.xml | 8 +- transport/http/pom.xml | 8 +- transport/lwm2m/pom.xml | 8 +- transport/mqtt/pom.xml | 8 +- 23 files changed, 219 insertions(+), 159 deletions(-) diff --git a/application/pom.xml b/application/pom.xml index 83a9eefdc3..48d5c88046 100644 --- a/application/pom.xml +++ b/application/pom.xml @@ -258,17 +258,6 @@ rest-client test - - org.springframework.boot - spring-boot-starter-test - test - - - com.vaadin.external.google - android-json - - - org.springframework.security spring-security-test @@ -285,18 +274,18 @@ test - junit - junit + org.springframework.boot + spring-boot-starter-test test - org.awaitility - awaitility + org.junit.vintage + junit-vintage-engine test - org.mockito - mockito-core + org.awaitility + awaitility test @@ -312,6 +301,7 @@ org.hsqldb hsqldb + test org.javadelight diff --git a/common/actor/pom.xml b/common/actor/pom.xml index 1f4849cb79..5efd6629ec 100644 --- a/common/actor/pom.xml +++ b/common/actor/pom.xml @@ -61,13 +61,18 @@ logback-classic - junit - junit + org.springframework.boot + spring-boot-starter-test test - org.mockito - mockito-core + org.junit.vintage + junit-vintage-engine + test + + + org.awaitility + awaitility test diff --git a/common/cache/pom.xml b/common/cache/pom.xml index 80000b80a0..e920acaba4 100644 --- a/common/cache/pom.xml +++ b/common/cache/pom.xml @@ -77,13 +77,18 @@ logback-classic - junit - junit + org.springframework.boot + spring-boot-starter-test + test + + + org.junit.vintage + junit-vintage-engine test - org.mockito - mockito-core + org.awaitility + awaitility test diff --git a/common/dao-api/pom.xml b/common/dao-api/pom.xml index ba30e5bb43..72d3df8587 100644 --- a/common/dao-api/pom.xml +++ b/common/dao-api/pom.xml @@ -97,13 +97,18 @@ provided - junit - junit + org.springframework.boot + spring-boot-starter-test + test + + + org.junit.vintage + junit-vintage-engine test - org.mockito - mockito-core + org.awaitility + awaitility test diff --git a/common/data/pom.xml b/common/data/pom.xml index 47902f493f..d73913c6db 100644 --- a/common/data/pom.xml +++ b/common/data/pom.xml @@ -63,15 +63,20 @@ com.fasterxml.jackson.core jackson-databind - + - junit - junit + org.springframework.boot + spring-boot-starter-test test - org.mockito - mockito-core + org.junit.vintage + junit-vintage-engine + test + + + org.awaitility + awaitility test diff --git a/common/message/pom.xml b/common/message/pom.xml index 06ba4aff3b..13c7a3d848 100644 --- a/common/message/pom.xml +++ b/common/message/pom.xml @@ -70,13 +70,18 @@ provided - junit - junit + org.springframework.boot + spring-boot-starter-test test - org.mockito - mockito-core + org.junit.vintage + junit-vintage-engine + test + + + org.awaitility + awaitility test diff --git a/common/queue/pom.xml b/common/queue/pom.xml index 2b1d87fc7b..424c1a18e0 100644 --- a/common/queue/pom.xml +++ b/common/queue/pom.xml @@ -121,18 +121,18 @@ curator-recipes - junit - junit + org.springframework.boot + spring-boot-starter-test test - org.hamcrest - hamcrest + org.junit.vintage + junit-vintage-engine test - org.mockito - mockito-core + org.awaitility + awaitility test diff --git a/common/stats/pom.xml b/common/stats/pom.xml index 005c210b7b..1fa25505b5 100644 --- a/common/stats/pom.xml +++ b/common/stats/pom.xml @@ -71,15 +71,19 @@ io.micrometer micrometer-registry-prometheus - - junit - junit + org.springframework.boot + spring-boot-starter-test + test + + + org.junit.vintage + junit-vintage-engine test - org.mockito - mockito-core + org.awaitility + awaitility test diff --git a/common/transport/coap/pom.xml b/common/transport/coap/pom.xml index 2fefb8f300..7ca800ba3a 100644 --- a/common/transport/coap/pom.xml +++ b/common/transport/coap/pom.xml @@ -82,13 +82,13 @@ test - junit - junit + org.junit.vintage + junit-vintage-engine test - org.mockito - mockito-core + org.awaitility + awaitility test diff --git a/common/transport/http/pom.xml b/common/transport/http/pom.xml index f229627480..fdaa638529 100644 --- a/common/transport/http/pom.xml +++ b/common/transport/http/pom.xml @@ -67,13 +67,13 @@ test - junit - junit + org.junit.vintage + junit-vintage-engine test - org.mockito - mockito-core + org.awaitility + awaitility test diff --git a/common/transport/lwm2m/pom.xml b/common/transport/lwm2m/pom.xml index 1b639af89d..ae708028b4 100644 --- a/common/transport/lwm2m/pom.xml +++ b/common/transport/lwm2m/pom.xml @@ -90,13 +90,13 @@ test - junit - junit + org.junit.vintage + junit-vintage-engine test - org.mockito - mockito-core + org.awaitility + awaitility test diff --git a/common/transport/mqtt/pom.xml b/common/transport/mqtt/pom.xml index b6ceb13951..dffc1dbdb2 100644 --- a/common/transport/mqtt/pom.xml +++ b/common/transport/mqtt/pom.xml @@ -84,8 +84,8 @@ test - junit - junit + org.junit.vintage + junit-vintage-engine test @@ -93,11 +93,6 @@ awaitility test - - org.mockito - mockito-core - test - diff --git a/common/transport/transport-api/pom.xml b/common/transport/transport-api/pom.xml index 491adc189e..10713d544a 100644 --- a/common/transport/transport-api/pom.xml +++ b/common/transport/transport-api/pom.xml @@ -85,13 +85,18 @@ logback-classic - junit - junit + org.springframework.boot + spring-boot-starter-test + test + + + org.junit.vintage + junit-vintage-engine test - org.mockito - mockito-core + org.awaitility + awaitility test diff --git a/common/util/pom.xml b/common/util/pom.xml index 26c4b42920..3fbae48be2 100644 --- a/common/util/pom.xml +++ b/common/util/pom.xml @@ -70,18 +70,18 @@ logback-classic - junit - junit + org.springframework.boot + spring-boot-starter-test test - org.hamcrest - hamcrest + org.junit.vintage + junit-vintage-engine test - org.mockito - mockito-core + org.awaitility + awaitility test diff --git a/dao/pom.xml b/dao/pom.xml index cc25e1a13c..cbeca50511 100644 --- a/dao/pom.xml +++ b/dao/pom.xml @@ -80,8 +80,18 @@ postgresql - junit - junit + org.springframework.boot + spring-boot-starter-test + test + + + org.junit.vintage + junit-vintage-engine + test + + + org.awaitility + awaitility test @@ -94,11 +104,6 @@ spring-test-dbunit test - - org.mockito - mockito-core - test - org.apache.commons commons-lang3 @@ -206,11 +211,6 @@ hsqldb test - - org.junit.jupiter - junit-jupiter-params - test - org.springframework spring-context-support diff --git a/msa/black-box-tests/pom.xml b/msa/black-box-tests/pom.xml index 7840b2ecf2..50aca3ce22 100644 --- a/msa/black-box-tests/pom.xml +++ b/msa/black-box-tests/pom.xml @@ -34,34 +34,33 @@ UTF-8 ${basedir}/../.. - 1.11.4 - 1.10 - 4.5.13 org.testcontainers testcontainers - ${testcontainers.version} + test org.zeroturnaround zt-exec - ${zeroturnaround.version} + test org.java-websocket Java-WebSocket + test org.apache.httpcomponents httpclient - ${httpclient.version} + test io.takari.junit takari-cpsuite + test ch.qos.logback diff --git a/pom.xml b/pom.xml index 59c160c6a9..ff33d497fd 100755 --- a/pom.xml +++ b/pom.xml @@ -46,21 +46,13 @@ 2.4.3 3.3.0 0.7.0 - 2.2.0 - 4.12 - 5.7.1 - 4.1.0 - 2.2 1.7.7 1.2.3 - 3.3.3 0.10 4.10.0 4.0.5 - 4.3.1.0 3.11.10 3.11.0 - 1.2.7 28.2-jre 2.6.1 3.4 @@ -92,9 +84,6 @@ 1.15.0 1.64 2.0.1 - 2.6.0 - 2.5.3 - 1.2.1 42.2.20 org/thingsboard/server/gen/**/*, org/thingsboard/server/extensions/core/plugin/telemetry/gen/**/* @@ -113,7 +102,6 @@ 1.4.3 1.9.4 3.2.2 - 1.5.0 1.5.2 1.0.3TB 3.4.0 @@ -123,6 +111,20 @@ 2.0.1.Final 1.6.2 2.8.5 + + 4.1.0 + 4.3.1.0 + 2.7.2 + 2.6.0 + 1.5.2 + 5.6.3 + 2.6.0 + 1.3.0 + 1.2.7 + + 1.16.0 + 1.12 + 4.5.13 @@ -1097,6 +1099,12 @@ spring-boot-starter-test ${spring-boot.version} test + + + com.vaadin.external.google + android-json + + org.springframework.boot @@ -1426,12 +1434,32 @@ takari-cpsuite ${takari-cpsuite.version} test + + + junit + junit + + org.cassandraunit cassandra-unit ${cassandra-unit.version} test + + + junit + junit + + + org.hamcrest + hamcrest-core + + + org.hamcrest + hamcrest-library + + org.apache.cassandra @@ -1439,10 +1467,16 @@ ${cassandra-all.version} - junit - junit - ${junit.version} + org.junit.vintage + junit-vintage-engine + ${jupiter.version} test + + + org.hamcrest + hamcrest-core + + org.awaitility @@ -1450,30 +1484,12 @@ ${awaitility.version} test - - org.hamcrest - hamcrest - ${hamcrest.version} - test - - - org.junit.jupiter - junit-jupiter-params - ${jupiter.version} - test - org.dbunit dbunit ${dbunit.version} test - - org.mockito - mockito-core - ${mockito.version} - test - org.projectlombok lombok @@ -1509,6 +1525,7 @@ org.hsqldb hsqldb ${hsqldb.version} + test org.springframework.data @@ -1709,6 +1726,24 @@ snmp4j ${snmp4j.version} + + org.testcontainers + testcontainers + ${testcontainers.version} + test + + + org.zeroturnaround + zt-exec + ${zeroturnaround.version} + test + + + org.apache.httpcomponents + httpclient + ${httpclient.version} + test + diff --git a/rule-engine/rule-engine-api/pom.xml b/rule-engine/rule-engine-api/pom.xml index bb348793c1..da7720fe1e 100644 --- a/rule-engine/rule-engine-api/pom.xml +++ b/rule-engine/rule-engine-api/pom.xml @@ -89,14 +89,18 @@ provided - junit - junit - ${junit.version} + org.springframework.boot + spring-boot-starter-test test - org.mockito - mockito-core + org.junit.vintage + junit-vintage-engine + test + + + org.awaitility + awaitility test diff --git a/rule-engine/rule-engine-components/pom.xml b/rule-engine/rule-engine-components/pom.xml index 31c0c1d824..671b1705b0 100644 --- a/rule-engine/rule-engine-components/pom.xml +++ b/rule-engine/rule-engine-components/pom.xml @@ -126,9 +126,18 @@ provided - junit - junit - ${junit.version} + org.springframework.boot + spring-boot-starter-test + test + + + org.junit.vintage + junit-vintage-engine + test + + + org.awaitility + awaitility test @@ -146,12 +155,6 @@ test - - org.mockito - mockito-core - test - - diff --git a/transport/coap/pom.xml b/transport/coap/pom.xml index 1ede01a491..95183088e4 100644 --- a/transport/coap/pom.xml +++ b/transport/coap/pom.xml @@ -70,13 +70,13 @@ test - junit - junit + org.junit.vintage + junit-vintage-engine test - org.mockito - mockito-core + org.awaitility + awaitility test diff --git a/transport/http/pom.xml b/transport/http/pom.xml index 41ca5683a1..ce224cda65 100644 --- a/transport/http/pom.xml +++ b/transport/http/pom.xml @@ -70,13 +70,13 @@ test - junit - junit + org.junit.vintage + junit-vintage-engine test - org.mockito - mockito-core + org.awaitility + awaitility test diff --git a/transport/lwm2m/pom.xml b/transport/lwm2m/pom.xml index 331e7482be..89c21ea18f 100644 --- a/transport/lwm2m/pom.xml +++ b/transport/lwm2m/pom.xml @@ -104,13 +104,13 @@ test - junit - junit + org.junit.vintage + junit-vintage-engine test - org.mockito - mockito-core + org.awaitility + awaitility test diff --git a/transport/mqtt/pom.xml b/transport/mqtt/pom.xml index 28aaeeab39..d359aa0c16 100644 --- a/transport/mqtt/pom.xml +++ b/transport/mqtt/pom.xml @@ -70,13 +70,13 @@ test - junit - junit + org.junit.vintage + junit-vintage-engine test - org.mockito - mockito-core + org.awaitility + awaitility test From 114825215ea341f6f605abb95b326338b4db1734 Mon Sep 17 00:00:00 2001 From: Sergey Matvienko Date: Fri, 6 Aug 2021 14:10:11 +0300 Subject: [PATCH 2/4] test scope: comments edited on versions for the test scope and blackbox test scope --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index ff33d497fd..28c6754c86 100755 --- a/pom.xml +++ b/pom.xml @@ -111,7 +111,7 @@ 2.0.1.Final 1.6.2 2.8.5 - + 4.1.0 4.3.1.0 2.7.2 @@ -121,7 +121,7 @@ 2.6.0 1.3.0 1.2.7 - + 1.16.0 1.12 4.5.13 From c759b2792a9ea4679e027041b70a37d1afd42563 Mon Sep 17 00:00:00 2001 From: Sergey Matvienko Date: Fri, 6 Aug 2021 14:29:53 +0300 Subject: [PATCH 3/4] dependency org.apache.httpcomponents httpclient moved from blackboxtests to the room POM. httpclient used in edge, but not explicitly added by dependency management. httpclient version with no change. --- pom.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 28c6754c86..e1bc101d00 100755 --- a/pom.xml +++ b/pom.xml @@ -111,6 +111,7 @@ 2.0.1.Final 1.6.2 2.8.5 + 4.5.13 4.1.0 4.3.1.0 @@ -124,7 +125,6 @@ 1.16.0 1.12 - 4.5.13 @@ -1742,7 +1742,6 @@ org.apache.httpcomponents httpclient ${httpclient.version} - test From 8bdd437644b613cf1d3a4de140f513ff569fabee Mon Sep 17 00:00:00 2001 From: Sergey Matvienko Date: Fri, 6 Aug 2021 15:50:38 +0300 Subject: [PATCH 4/4] rollback testcontainers version to 1.11.4 due to the newest testcontainers does not support "container_name" in docker compose --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index e1bc101d00..fbf3861cc1 100755 --- a/pom.xml +++ b/pom.xml @@ -123,8 +123,8 @@ 1.3.0 1.2.7 - 1.16.0 - 1.12 + 1.11.4 + 1.10