From 81e35e134e8377f2e24f106aba1188a235aee153 Mon Sep 17 00:00:00 2001
From: Yevhenii <uman980124@gmail.com>
Date: Wed, 7 May 2025 17:40:59 +0300
Subject: [PATCH] Validation DefaultEdgeRuleChain in DeviceProfile

- added validation for DefaultEdgeRuleChain
- refactoring
---
 .../validator/DeviceProfileDataValidator.java | 28 +++++++++++++------
 1 file changed, 19 insertions(+), 9 deletions(-)

diff --git a/dao/src/main/java/org/thingsboard/server/dao/service/validator/DeviceProfileDataValidator.java b/dao/src/main/java/org/thingsboard/server/dao/service/validator/DeviceProfileDataValidator.java
index a9e14229f8..e32195022c 100644
--- a/dao/src/main/java/org/thingsboard/server/dao/service/validator/DeviceProfileDataValidator.java
+++ b/dao/src/main/java/org/thingsboard/server/dao/service/validator/DeviceProfileDataValidator.java
@@ -43,6 +43,7 @@ import org.thingsboard.server.common.data.device.profile.lwm2m.bootstrap.Abstrac
 import org.thingsboard.server.common.data.device.profile.lwm2m.bootstrap.LwM2MBootstrapServerCredential;
 import org.thingsboard.server.common.data.device.profile.lwm2m.bootstrap.RPKLwM2MBootstrapServerCredential;
 import org.thingsboard.server.common.data.device.profile.lwm2m.bootstrap.X509LwM2MBootstrapServerCredential;
+import org.thingsboard.server.common.data.id.RuleChainId;
 import org.thingsboard.server.common.data.id.TenantId;
 import org.thingsboard.server.common.data.queue.Queue;
 import org.thingsboard.server.common.data.rule.RuleChain;
@@ -188,13 +189,11 @@ public class DeviceProfileDataValidator extends AbstractHasOtaPackageValidator<D
         }
 
         if (deviceProfile.getDefaultRuleChainId() != null) {
-            RuleChain ruleChain = ruleChainService.findRuleChainById(tenantId, deviceProfile.getDefaultRuleChainId());
-            if (ruleChain == null) {
-                throw new DataValidationException("Can't assign non-existent rule chain!");
-            }
-            if (!ruleChain.getTenantId().equals(deviceProfile.getTenantId())) {
-                throw new DataValidationException("Can't assign rule chain from different tenant!");
-            }
+            validateRuleChain(tenantId, deviceProfile.getTenantId(), deviceProfile.getDefaultRuleChainId());
+        }
+
+        if (deviceProfile.getDefaultEdgeRuleChainId() != null) {
+            validateRuleChain(tenantId, deviceProfile.getTenantId(), deviceProfile.getDefaultEdgeRuleChainId());
         }
 
         if (deviceProfile.getDefaultDashboardId() != null) {
@@ -210,6 +209,16 @@ public class DeviceProfileDataValidator extends AbstractHasOtaPackageValidator<D
         validateOtaPackage(tenantId, deviceProfile, deviceProfile.getId());
     }
 
+    private void validateRuleChain(TenantId tenantId, TenantId deviceTenantId, RuleChainId ruleChainId) {
+        RuleChain ruleChain = ruleChainService.findRuleChainById(tenantId, ruleChainId);
+        if (ruleChain == null) {
+            throw new DataValidationException("Can't assign non-existent rule chain!");
+        }
+        if (!ruleChain.getTenantId().equals(deviceTenantId)) {
+            throw new DataValidationException("Can't assign rule chain from different tenant!");
+        }
+    }
+
     @Override
     protected DeviceProfile validateUpdate(TenantId tenantId, DeviceProfile deviceProfile) {
         DeviceProfile old = deviceProfileDao.findById(deviceProfile.getTenantId(), deviceProfile.getId().getId());
@@ -329,8 +338,8 @@ public class DeviceProfileDataValidator extends AbstractHasOtaPackageValidator<D
             }
 
             if (serverConfig.getShortServerId() != null) {
-                if (serverConfig.isBootstrapServerIs()){
-                    if(serverConfig.getShortServerId() < 0 || serverConfig.getShortServerId() > 65535){
+                if (serverConfig.isBootstrapServerIs()) {
+                    if (serverConfig.getShortServerId() < 0 || serverConfig.getShortServerId() > 65535) {
                         throw new DeviceCredentialsValidationException("Bootstrap Server ShortServerId must be in range [0 - 65535]!");
                     }
                 } else {
@@ -423,4 +432,5 @@ public class DeviceProfileDataValidator extends AbstractHasOtaPackageValidator<D
     private String getCertificateString(X509Certificate cert) throws CertificateEncodingException {
         return EncryptionUtil.certTrimNewLines(Base64.getEncoder().encodeToString(cert.getEncoded()));
     }
+
 }