Browse Source

junit5: BaseUserServiceTest annotation exceptions refactoring

pull/8174/head
Oleksandra Matviienko 4 years ago
parent
commit
8646526446
  1. 25
      dao/src/test/java/org/thingsboard/server/dao/service/BaseUserServiceTest.java

25
dao/src/test/java/org/thingsboard/server/dao/service/BaseUserServiceTest.java

@ -19,6 +19,7 @@ import org.junit.After;
import org.junit.Assert; import org.junit.Assert;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
import org.junit.jupiter.api.Assertions;
import org.thingsboard.common.util.JacksonUtil; import org.thingsboard.common.util.JacksonUtil;
import org.thingsboard.server.common.data.Customer; import org.thingsboard.server.common.data.Customer;
import org.thingsboard.server.common.data.StringUtils; import org.thingsboard.server.common.data.StringUtils;
@ -142,32 +143,40 @@ public abstract class BaseUserServiceTest extends AbstractServiceTest {
userService.deleteUser(tenantId, savedUser.getId()); userService.deleteUser(tenantId, savedUser.getId());
} }
@Test(expected = DataValidationException.class) @Test
public void testSaveUserWithSameEmail() { public void testSaveUserWithSameEmail() {
User tenantAdminUser = userService.findUserByEmail(tenantId, "tenant@thingsboard.org"); User tenantAdminUser = userService.findUserByEmail(tenantId, "tenant@thingsboard.org");
tenantAdminUser.setEmail("sysadmin@thingsboard.org"); tenantAdminUser.setEmail("sysadmin@thingsboard.org");
userService.saveUser(tenantAdminUser); Assertions.assertThrows(DataValidationException.class, () -> {
userService.saveUser(tenantAdminUser);
});
} }
@Test(expected = DataValidationException.class) @Test
public void testSaveUserWithInvalidEmail() { public void testSaveUserWithInvalidEmail() {
User tenantAdminUser = userService.findUserByEmail(tenantId, "tenant@thingsboard.org"); User tenantAdminUser = userService.findUserByEmail(tenantId, "tenant@thingsboard.org");
tenantAdminUser.setEmail("tenant_thingsboard.org"); tenantAdminUser.setEmail("tenant_thingsboard.org");
userService.saveUser(tenantAdminUser); Assertions.assertThrows(DataValidationException.class, () -> {
userService.saveUser(tenantAdminUser);
});
} }
@Test(expected = DataValidationException.class) @Test
public void testSaveUserWithEmptyEmail() { public void testSaveUserWithEmptyEmail() {
User tenantAdminUser = userService.findUserByEmail(tenantId, "tenant@thingsboard.org"); User tenantAdminUser = userService.findUserByEmail(tenantId, "tenant@thingsboard.org");
tenantAdminUser.setEmail(null); tenantAdminUser.setEmail(null);
userService.saveUser(tenantAdminUser); Assertions.assertThrows(DataValidationException.class, () -> {
userService.saveUser(tenantAdminUser);
});
} }
@Test(expected = DataValidationException.class) @Test
public void testSaveUserWithoutTenant() { public void testSaveUserWithoutTenant() {
User tenantAdminUser = userService.findUserByEmail(tenantId, "tenant@thingsboard.org"); User tenantAdminUser = userService.findUserByEmail(tenantId, "tenant@thingsboard.org");
tenantAdminUser.setTenantId(null); tenantAdminUser.setTenantId(null);
userService.saveUser(tenantAdminUser); Assertions.assertThrows(DataValidationException.class, () -> {
userService.saveUser(tenantAdminUser);
});
} }
@Test @Test

Loading…
Cancel
Save