Improve entity state controller.

ui/src/app/dashboard/states/entity-state-controller.js

@@ -44,8 +44,7 @@ export default function EntityStateController($scope, $timeout, $location, $stat
     function openState(id, params, openRightLayout) {
         if (vm.states && vm.states[id]) {
             resolveEntity(params).then(
-                function success(entityName) {
+                function success() {
-                    params.entityName = entityName;
                     var newState = {
                         id: id,
                         params: params
@@ -66,8 +65,7 @@ export default function EntityStateController($scope, $timeout, $location, $stat
         }
         if (vm.states && vm.states[id]) {
             resolveEntity(params).then(
-                function success(entityName) {
+                function success() {
-                    params.entityName = entityName;
                     var newState = {
                         id: id,
                         params: params
@@ -183,16 +181,16 @@ export default function EntityStateController($scope, $timeout, $location, $stat
             params = params[params.targetEntityParamName];
         }
         if (params && params.entityId && params.entityId.id && params.entityId.entityType) {
-            if (params.entityName && params.entityName.length) {
+            if (isEntityResolved(params)) {
-                deferred.resolve(params.entityName);
+                deferred.resolve();
             } else {
                 entityService.getEntity(params.entityId.entityType, params.entityId.id, {
                     ignoreLoading: true,
                     ignoreErrors: true
                 }).then(
                     function success(entity) {
-                        var entityName = entity.name;
+                        params.entityName = entity.name;
-                        deferred.resolve(entityName);
+                        deferred.resolve();
                     },
                     function fail() {
                         deferred.reject();
@@ -200,11 +198,18 @@ export default function EntityStateController($scope, $timeout, $location, $stat
                 );
             }
         } else {
-            deferred.resolve('');
+            deferred.resolve();
         }
         return deferred.promise;
     }
 
+    function isEntityResolved(params) {
+        if (!params.entityName || !params.entityName.length) {
+            return false;
+        }
+        return true;
+    }
+
     function parseState(stateBase64) {
         var result;
         if (stateBase64) {