From 934ede0298de1cce12c0237a0d1d5cf233a79424 Mon Sep 17 00:00:00 2001 From: Sergey Matvienko Date: Wed, 7 Dec 2022 17:50:33 +0100 Subject: [PATCH] TestListener refactored to not hold local var --- .../thingsboard/server/msa/ui/listeners/TestListener.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/msa/black-box-tests/src/test/java/org/thingsboard/server/msa/ui/listeners/TestListener.java b/msa/black-box-tests/src/test/java/org/thingsboard/server/msa/ui/listeners/TestListener.java index 737022a096..60da6d32e6 100644 --- a/msa/black-box-tests/src/test/java/org/thingsboard/server/msa/ui/listeners/TestListener.java +++ b/msa/black-box-tests/src/test/java/org/thingsboard/server/msa/ui/listeners/TestListener.java @@ -29,13 +29,11 @@ import static org.thingsboard.server.msa.ui.base.AbstractDriverBaseTest.captureS @Slf4j public class TestListener implements ITestListener { - WebDriver driver; - public void onTestSuccess(ITestResult tr) { String str = "Test " + tr.getMethod().getMethodName() + " success"; log.info("*----------------------* " + str + " *----------------------*"); if (!((AbstractDriverBaseTest) tr.getInstance()).getHeadless()) { - driver = ((AbstractDriverBaseTest) tr.getInstance()).getDriver(); + WebDriver driver = ((AbstractDriverBaseTest) tr.getInstance()).getDriver(); captureScreen(driver, "success"); } } @@ -46,7 +44,7 @@ public class TestListener implements ITestListener { log.info("*----------------------* " + str + " *----------------------*"); log.info("*----------------------* " + str1 + " *----------------------*"); if (!((AbstractDriverBaseTest) tr.getInstance()).getHeadless()) { - driver = ((AbstractDriverBaseTest) tr.getInstance()).getDriver(); + WebDriver driver = ((AbstractDriverBaseTest) tr.getInstance()).getDriver(); captureScreen(driver, "failure"); } } @@ -57,7 +55,7 @@ public class TestListener implements ITestListener { log.info("*----------------------* " + str + " *----------------------*"); log.info("*----------------------* " + str1 + " *----------------------*"); if (!((AbstractDriverBaseTest) tr.getInstance()).getHeadless()) { - driver = ((AbstractDriverBaseTest) tr.getInstance()).getDriver(); + WebDriver driver = ((AbstractDriverBaseTest) tr.getInstance()).getDriver(); captureScreen(driver, "skipped"); } }