Removed redundant lock

application/src/main/java/org/thingsboard/server/service/edge/rpc/EdgeGrpcSession.java

@@ -92,7 +92,6 @@ import java.util.stream.Collectors;
 public final class EdgeGrpcSession implements Closeable {
 
     private static final ReentrantLock downlinkMsgLock = new ReentrantLock();
-    private static final ReentrantLock downlinkMsgsPackLock = new ReentrantLock();
 
     private static final String QUEUE_START_TS_ATTR_KEY = "queueStartTs";
 
@@ -390,15 +389,15 @@ public final class EdgeGrpcSession implements Closeable {
     }
 
     private ListenableFuture<Void> sendDownlinkMsgsPack(List<DownlinkMsg> downlinkMsgsPack) {
-        sendDownlinkMsgsFuture = SettableFuture.create();
+        if (sendDownlinkMsgsFuture != null && !sendDownlinkMsgsFuture.isDone()) {
-        downlinkMsgsPackLock.lock();
+            String erroMsg = "[" + this.sessionId + "] Previous send downdlink future was not properly completed, stopping it now";
-        try {
+            log.error(erroMsg);
-            pendingMsgsMap.clear();
+            sendDownlinkMsgsFuture.setException(new RuntimeException(erroMsg));
-            downlinkMsgsPack.forEach(msg -> pendingMsgsMap.put(msg.getDownlinkMsgId(), msg));
-            scheduleDownlinkMsgsPackSend(true);
-        } finally {
-            downlinkMsgsPackLock.unlock();
         }
+        sendDownlinkMsgsFuture = SettableFuture.create();
+        pendingMsgsMap.clear();
+        downlinkMsgsPack.forEach(msg -> pendingMsgsMap.put(msg.getDownlinkMsgId(), msg));
+        scheduleDownlinkMsgsPackSend(true);
         return sendDownlinkMsgsFuture;
     }
 

application/src/main/java/org/thingsboard/server/service/edge/rpc/EdgeSyncCursor.java

@@ -32,6 +32,7 @@ import org.thingsboard.server.service.edge.rpc.fetch.TenantWidgetsBundlesEdgeEve
 
 import java.util.LinkedList;
 import java.util.List;
+import java.util.NoSuchElementException;
 
 public class EdgeSyncCursor {
 
@@ -59,13 +60,12 @@ public class EdgeSyncCursor {
     }
 
     public EdgeEventFetcher getNext() {
-        if (hasNext()) {
+        if (!hasNext()) {
-            EdgeEventFetcher edgeEventFetcher = fetchers.get(currentIdx);
+            throw new NoSuchElementException();
-            currentIdx++;
-            return edgeEventFetcher;
-        } else {
-            throw new IndexOutOfBoundsException();
         }
+        EdgeEventFetcher edgeEventFetcher = fetchers.get(currentIdx);
+        currentIdx++;
+        return edgeEventFetcher;
     }
 
     public int getCurrentIdx() {