Browse Source

Added sorting to test for alarm assignment, added and to where clause for filter by assigneeId

pull/8232/head
zbeacon 3 years ago
parent
commit
a889649d32
  1. 4
      dao/src/main/java/org/thingsboard/server/dao/sql/query/DefaultAlarmQueryRepository.java
  2. 1
      dao/src/test/java/org/thingsboard/server/dao/service/BaseAlarmServiceTest.java

4
dao/src/main/java/org/thingsboard/server/dao/sql/query/DefaultAlarmQueryRepository.java

@ -148,7 +148,7 @@ public class DefaultAlarmQueryRepository implements AlarmQueryRepository {
}
EntityDataSortOrder sortOrder = pageLink.getSortOrder();
if (EntityKeyType.ALARM_FIELD.equals(sortOrder.getKey().getType()) && ASSIGNEE_KEY.equalsIgnoreCase(sortOrder.getKey().getKey())) {
if (sortOrder != null && EntityKeyType.ALARM_FIELD.equals(sortOrder.getKey().getType()) && ASSIGNEE_KEY.equalsIgnoreCase(sortOrder.getKey().getKey())) {
sortOrder = new EntityDataSortOrder(new EntityKey(EntityKeyType.ALARM_FIELD, ASSIGNEE_EMAIL_KEY), sortOrder.getDirection());
}
@ -269,6 +269,8 @@ public class DefaultAlarmQueryRepository implements AlarmQueryRepository {
}
if (pageLink.getAssigneeId() != null) {
addAndIfNeeded(wherePart, addAnd);
addAnd = true;
ctx.addUuidParameter("assigneeId", pageLink.getAssigneeId().getId());
wherePart.append(" a.assignee_id = :assigneeId");
}

1
dao/src/test/java/org/thingsboard/server/dao/service/BaseAlarmServiceTest.java

@ -267,6 +267,7 @@ public abstract class BaseAlarmServiceTest extends AbstractServiceTest {
pageLink.setPage(0);
pageLink.setPageSize(10);
pageLink.setAssigneeId(tenantUser.getId());
pageLink.setSortOrder(new EntityDataSortOrder(new EntityKey(EntityKeyType.ALARM_FIELD, "assignee")));
PageData<AlarmData> assignedAlarms = alarmService.findAlarmDataByQueryForEntities(tenantId, toQuery(pageLink), Collections.singletonList(created.getOriginator()));
Assert.assertNotNull(assignedAlarms.getData());

Loading…
Cancel
Save