Refactor: add check to ensure msg data is always object

3 years ago · acac0af2d1
1 changed files with 3 additions and 0 deletions
--- a/rule-engine/rule-engine-components/src/main/java/org/thingsboard/rule/engine/metadata/CalculateDeltaNode.java
+++ b/rule-engine/rule-engine-components/src/main/java/org/thingsboard/rule/engine/metadata/CalculateDeltaNode.java
@ -77,6 +77,9 @@ public class CalculateDeltaNode implements TbNode {
    public void onMsg(TbContext ctx, TbMsg msg) {
        if (msg.getType().equals(SessionMsgType.POST_TELEMETRY_REQUEST.name())) {
            JsonNode json = JacksonUtil.toJsonNode(msg.getData());
+            if (!json.isObject()) {
+                throw new IllegalArgumentException("Message body is not an object!");
+            }
            String inputKey = config.getInputValueKey();
            if (json.has(inputKey)) {
                DonAsynchron.withCallback(getLastValue(msg.getOriginator()),