Merge branch 'fix/4099-opc-empty-config' into improvements/050824-gateway

ui-ngx/src/app/modules/home/components/widget/lib/gateway/connectors-configuration/broker-config-control/broker-config-control.component.ts

@@ -109,12 +109,13 @@ export class BrokerConfigControlComponent implements ControlValueAccessor, Valid
   }
 
   writeValue(brokerConfig: BrokerConfig): void {
-    const brokerConfigState = {
+    const {
-      ...brokerConfig,
+      version = 5,
-      version: brokerConfig.version || 5,
+      clientId = `tb_gw_${generateSecret(5)}`,
-      clientId: brokerConfig.clientId || 'tb_gw_' + generateSecret(5),
+      security = {},
-    };
+    } = brokerConfig;
-    this.brokerConfigFormGroup.reset(brokerConfigState, {emitEvent: false});
+
+    this.brokerConfigFormGroup.reset({ ...brokerConfig, version, clientId, security }, { emitEvent: false });
     this.cdr.markForCheck();
   }
 

ui-ngx/src/app/modules/home/components/widget/lib/gateway/connectors-configuration/opc-server-config/opc-server-config.component.ts

@@ -85,7 +85,7 @@ export class OpcServerConfigComponent implements ControlValueAccessor, Validator
       subCheckPeriodInMillis: [10, [Validators.required, Validators.min(10)]],
       showMap: [false, []],
       security: [SecurityPolicy.BASIC128, []],
-      identity: [{}, [Validators.required]]
+      identity: []
     });
 
     this.serverConfigFormGroup.valueChanges.pipe(
@@ -116,16 +116,25 @@ export class OpcServerConfigComponent implements ControlValueAccessor, Validator
   }
 
   writeValue(serverConfig: ServerConfig): void {
-    const { timeoutInMillis, scanPeriodInMillis, enableSubscriptions, subCheckPeriodInMillis, showMap, security } = serverConfig;
+    const {
-    const serverConfigState = {
+      timeoutInMillis = 1000,
+      scanPeriodInMillis = 1000,
+      enableSubscriptions = true,
+      subCheckPeriodInMillis = 10,
+      showMap = false,
+      security = SecurityPolicy.BASIC128,
+      identity = {},
+    } = serverConfig;
+
+    this.serverConfigFormGroup.reset({
       ...serverConfig,
-      timeoutInMillis: timeoutInMillis || 1000,
+      timeoutInMillis,
-      scanPeriodInMillis: scanPeriodInMillis || 1000,
+      scanPeriodInMillis,
-      enableSubscriptions: enableSubscriptions || true,
+      enableSubscriptions,
-      subCheckPeriodInMillis: subCheckPeriodInMillis || 10,
+      subCheckPeriodInMillis,
-      showMap: showMap || false,
+      showMap,
-      security: security || SecurityPolicy.BASIC128,
+      security,
-    };
+      identity,
-    this.serverConfigFormGroup.reset(serverConfigState, {emitEvent: false});
+    }, { emitEvent: false });
   }
 }

ui-ngx/src/app/modules/home/components/widget/lib/gateway/gateway-widget.models.ts

@@ -170,6 +170,7 @@ export interface ConnectorSecurity {
   pathToCACert?: string;
   pathToPrivateKey?: string;
   pathToClientCert?: string;
+  mode?: ModeType;
 }
 
 export type ConnectorMapping = DeviceConnectorMapping | RequestMappingData | ConverterConnectorMapping;