Browse Source

Small revert

pull/14775/head
Andrii Landiak 9 months ago
parent
commit
cc6af84a92
  1. 12
      dao/src/main/java/org/thingsboard/server/dao/ota/BaseOtaPackageService.java

12
dao/src/main/java/org/thingsboard/server/dao/ota/BaseOtaPackageService.java

@ -196,7 +196,7 @@ public class BaseOtaPackageService extends AbstractCachedEntityService<OtaPackag
log.trace("Executing deleteOtaPackage [{}]", otaPackageId);
validateId(otaPackageId, id -> INCORRECT_OTA_PACKAGE_ID + id);
try {
Long oid = otaPackageDao.getDataOidById(otaPackageId.getId());
Long oid = getDataOidById(tenantId, otaPackageId);
otaPackageDao.removeById(tenantId, otaPackageId.getId());
unlinkDataIfPresent(tenantId, otaPackageId, oid);
publishEvictEvent(new OtaPackageCacheEvictEvent(otaPackageId));
@ -217,6 +217,16 @@ public class BaseOtaPackageService extends AbstractCachedEntityService<OtaPackag
}
}
private Long getDataOidById(TenantId tenantId, OtaPackageId otaPackageId) {
try {
log.trace("Executing getDataOidById tenantId [{}], otaPackageId [{}]", tenantId, otaPackageId);
return otaPackageDao.getDataOidById(otaPackageId.getId());
} catch (Exception e) {
log.warn("[{}][{}] Failed to retrieve OID before deletion", tenantId, otaPackageId, e);
}
return null;
}
private void unlinkDataIfPresent(TenantId tenantId, OtaPackageId otaPackageId, Long oid) {
if (oid == null) {
return;

Loading…
Cancel
Save