From d3e526058f4d6e25fbca9d450be0d01f96bb2c91 Mon Sep 17 00:00:00 2001 From: Volodymyr Babak Date: Wed, 6 May 2026 16:51:04 +0300 Subject: [PATCH] Code review changes --- .../server/transport/snmp/service/SnmpTransportService.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/common/transport/snmp/src/main/java/org/thingsboard/server/transport/snmp/service/SnmpTransportService.java b/common/transport/snmp/src/main/java/org/thingsboard/server/transport/snmp/service/SnmpTransportService.java index 5105b35d1d..a15a21b6e3 100644 --- a/common/transport/snmp/src/main/java/org/thingsboard/server/transport/snmp/service/SnmpTransportService.java +++ b/common/transport/snmp/src/main/java/org/thingsboard/server/transport/snmp/service/SnmpTransportService.java @@ -390,9 +390,11 @@ public class SnmpTransportService implements TbTransportService, CommandResponde JsonObject responseData = responseDataMappers.get(requestContext.getCommunicationSpec()).map(response, requestContext); if (responseData.size() == 0) { - log.warn("[{}] No values in the response for spec {}. Response PDUs: {}, Mappings count: {}", + log.warn("[{}] No values in the response for spec {}. Response PDUs count: {}, Mappings count: {}", sessionContext.getDeviceId(), requestContext.getCommunicationSpec(), - response, requestContext.getResponseMappings() != null ? requestContext.getResponseMappings().size() : 0); + response.size(), requestContext.getResponseMappings().size()); + log.debug("[{}] No values in the response for spec {}. Response PDUs: {}", + sessionContext.getDeviceId(), requestContext.getCommunicationSpec(), response); throw new IllegalArgumentException("No values in the response"); }