From 2ec2e7179dc32ebea0053f7eb9ea16eb757c4704 Mon Sep 17 00:00:00 2001 From: Sergey Matvienko Date: Mon, 23 Aug 2021 10:28:22 +0300 Subject: [PATCH 01/16] dependency management: org.springframework:spring-core (version with no change, exclusions replaced with transitive dependency management --- pom.xml | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/pom.xml b/pom.xml index 687b6031fd..1eff6471d8 100755 --- a/pom.xml +++ b/pom.xml @@ -1059,23 +1059,11 @@ org.springframework.security spring-security-oauth2-client ${spring-security.version} - - - org.springframework - spring-core - - org.springframework.security spring-security-oauth2-jose ${spring-security.version} - - - org.springframework - spring-core - - org.springframework From 3ce5c27cb6173483d20b890dd0ff7e3c03a3a5bf Mon Sep 17 00:00:00 2001 From: Sergey Matvienko Date: Mon, 23 Aug 2021 10:46:18 +0300 Subject: [PATCH 02/16] dependency management: com.fasterxml (version unified with general jackson.version (no change), exclusions replaced with transitive dependency management), fasterxml-classmate version defined --- pom.xml | 43 +++++++++++++++++++++++++++++++++---------- 1 file changed, 33 insertions(+), 10 deletions(-) diff --git a/pom.xml b/pom.xml index 1eff6471d8..b759fc51d4 100755 --- a/pom.xml +++ b/pom.xml @@ -67,8 +67,7 @@ 2.11.0 1.4 2.12.1 - 2.12.1 - 2.12.1 + 1.3.4 2.2.6 2.6.1 2.0.0-M3 @@ -1260,12 +1259,42 @@ com.fasterxml.jackson.core jackson-core - ${jackson-core.version} + ${jackson.version} com.fasterxml.jackson.core jackson-annotations - ${jackson-annotations.version} + ${jackson.version} + + + com.fasterxml.jackson.dataformat + jackson-dataformat-cbor + ${jackson.version} + + + com.fasterxml.jackson.datatype + jackson-datatype-jdk8 + ${jackson.version} + + + com.fasterxml.jackson.datatype + jackson-datatype-joda + ${jackson.version} + + + com.fasterxml.jackson.datatype + jackson-datatype-jsr310 + ${jackson.version} + + + com.fasterxml.jackson.module + jackson-module-parameter-names + ${jackson.version} + + + com.fasterxml + classmate + ${fasterxml-classmate.version} com.github.fge @@ -1545,12 +1574,6 @@ de.ruedigermoeller fst ${fst.version} - - - com.fasterxml.jackson.core - jackson-core - - io.springfox.ui From f8f92494e8357bf578fe02512265659e9321e054 Mon Sep 17 00:00:00 2001 From: Sergey Matvienko Date: Mon, 23 Aug 2021 12:17:02 +0300 Subject: [PATCH 03/16] dependency management: io.netty (version unified with general netty.version (no change), exclusions replaced with transitive dependency management) --- pom.xml | 76 +++++++++++++++++++++++++++++++++++++++++++++++---------- 1 file changed, 63 insertions(+), 13 deletions(-) diff --git a/pom.xml b/pom.xml index b759fc51d4..4f2450a7a1 100755 --- a/pom.xml +++ b/pom.xml @@ -1208,7 +1208,22 @@ io.netty - netty-handler + netty-buffer + ${netty.version} + + + io.netty + netty-codec + ${netty.version} + + + io.netty + netty-codec-http + ${netty.version} + + + io.netty + netty-codec-http2 ${netty.version} @@ -1216,6 +1231,53 @@ netty-codec-mqtt ${netty.version} + + io.netty + netty-codec-socks + ${netty.version} + + + io.netty + netty-common + ${netty.version} + + + io.netty + netty-handler + ${netty.version} + + + io.netty + netty-handler-proxy + ${netty.version} + + + io.netty + netty-resolver + ${netty.version} + + + io.netty + netty-transport + ${netty.version} + + + io.netty + netty-transport-native-epoll + ${netty.version} + linux-x86_64 + + + io.netty + netty-transport-native-kqueue + ${netty.version} + osx-x86_64 + + + io.netty + netty-transport-native-unix-common + ${netty.version} + com.datastax.oss java-driver-core @@ -1405,12 +1467,6 @@ io.grpc grpc-netty ${grpc.version} - - - io.netty - * - - io.grpc @@ -1609,12 +1665,6 @@ com.microsoft.azure azure-servicebus ${azure-servicebus.version} - - - io.netty - * - - org.passay From bf938a45e7a805329f2411e83b7feb5eb7e8670a Mon Sep 17 00:00:00 2001 From: Sergey Matvienko Date: Mon, 16 Aug 2021 09:16:41 +0300 Subject: [PATCH 04/16] grpc: grpc-netty replaced with grpc-netty-shaded to decouple grpc and netty versions in the project (CE) --- application/pom.xml | 2 +- pom.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/application/pom.xml b/application/pom.xml index 03832654fa..4f24d4a5ad 100644 --- a/application/pom.xml +++ b/application/pom.xml @@ -231,7 +231,7 @@ io.grpc - grpc-netty + grpc-netty-shaded io.grpc diff --git a/pom.xml b/pom.xml index 4f2450a7a1..e5217e8ad6 100755 --- a/pom.xml +++ b/pom.xml @@ -1465,7 +1465,7 @@ io.grpc - grpc-netty + grpc-netty-shaded ${grpc.version} From f73f08047534cd4e6d598910636e64fa399c40cb Mon Sep 17 00:00:00 2001 From: Sergey Matvienko Date: Mon, 16 Aug 2021 10:09:26 +0300 Subject: [PATCH 05/16] grpc: grpc-netty replaced with grpc-netty-shaded (edge-api) --- common/edge-api/pom.xml | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/common/edge-api/pom.xml b/common/edge-api/pom.xml index 3915ea7bec..ed19be3480 100644 --- a/common/edge-api/pom.xml +++ b/common/edge-api/pom.xml @@ -87,17 +87,7 @@ io.grpc - grpc-netty - - - netty-transport - io.netty - - - netty-common - io.netty - - + grpc-netty-shaded io.grpc From 11720e076f3704ca8a0573de478b1ec043d2ed8f Mon Sep 17 00:00:00 2001 From: Sergey Matvienko Date: Mon, 23 Aug 2021 12:38:58 +0300 Subject: [PATCH 06/16] grpc: replaced imports for grpc-netty-shaded (io.grpc.netty. -> io.grpc.netty.shaded.io.grpc.netty.) (CE) --- .../thingsboard/server/service/edge/rpc/EdgeGrpcService.java | 2 +- .../main/java/org/thingsboard/edge/rpc/EdgeGrpcClient.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/application/src/main/java/org/thingsboard/server/service/edge/rpc/EdgeGrpcService.java b/application/src/main/java/org/thingsboard/server/service/edge/rpc/EdgeGrpcService.java index e118a0b0c2..730daf3f28 100644 --- a/application/src/main/java/org/thingsboard/server/service/edge/rpc/EdgeGrpcService.java +++ b/application/src/main/java/org/thingsboard/server/service/edge/rpc/EdgeGrpcService.java @@ -19,7 +19,7 @@ import com.fasterxml.jackson.databind.ObjectMapper; import com.google.common.util.concurrent.FutureCallback; import com.google.common.util.concurrent.Futures; import io.grpc.Server; -import io.grpc.netty.NettyServerBuilder; +import io.grpc.netty.shaded.io.grpc.netty.NettyServerBuilder; import io.grpc.stub.StreamObserver; import lombok.extern.slf4j.Slf4j; import org.springframework.beans.factory.annotation.Autowired; diff --git a/common/edge-api/src/main/java/org/thingsboard/edge/rpc/EdgeGrpcClient.java b/common/edge-api/src/main/java/org/thingsboard/edge/rpc/EdgeGrpcClient.java index 4c74fdc2f9..70d985ef64 100644 --- a/common/edge-api/src/main/java/org/thingsboard/edge/rpc/EdgeGrpcClient.java +++ b/common/edge-api/src/main/java/org/thingsboard/edge/rpc/EdgeGrpcClient.java @@ -17,8 +17,8 @@ package org.thingsboard.edge.rpc; import com.google.common.io.Resources; import io.grpc.ManagedChannel; -import io.grpc.netty.GrpcSslContexts; -import io.grpc.netty.NettyChannelBuilder; +import io.grpc.netty.shaded.io.grpc.netty.GrpcSslContexts; +import io.grpc.netty.shaded.io.grpc.netty.NettyChannelBuilder; import io.grpc.stub.StreamObserver; import lombok.extern.slf4j.Slf4j; import org.springframework.beans.factory.annotation.Value; From e565725099556e176c858b89201eb335a9fb710c Mon Sep 17 00:00:00 2001 From: Sergey Matvienko Date: Mon, 23 Aug 2021 13:07:41 +0300 Subject: [PATCH 07/16] dependency management: added commons-codec commons-logging in dep management (only greater available version in the classpath left) --- pom.xml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/pom.xml b/pom.xml index e5217e8ad6..d188bf371f 100755 --- a/pom.xml +++ b/pom.xml @@ -64,7 +64,9 @@ 28.2-jre 2.6.1 3.4 + 1.15 2.11.0 + 1.2 1.4 2.12.1 1.3.4 @@ -1308,6 +1310,16 @@ commons-io ${commons-io.version} + + commons-codec + commons-codec + ${commons-codec.version} + + + commons-logging + commons-logging + ${commons-logging.version} + org.apache.commons commons-csv From d8455aca258a8ff605235692b709cf78ae3330ce Mon Sep 17 00:00:00 2001 From: Sergey Matvienko Date: Mon, 23 Aug 2021 13:14:53 +0300 Subject: [PATCH 08/16] dependency management: removed unnecessary exclude commons-io from org.owasp.antisamy because commons-io already defined in dependencyManagement (transitive dependency are managed as well) --- pom.xml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/pom.xml b/pom.xml index d188bf371f..352fc13809 100755 --- a/pom.xml +++ b/pom.xml @@ -1776,10 +1776,6 @@ com.github.spotbugs spotbugs-annotations - - commons-io - commons-io - From 381f5d4efc143ffb167a2c0a6befbf6aca5706f8 Mon Sep 17 00:00:00 2001 From: Sergey Matvienko Date: Mon, 23 Aug 2021 13:24:16 +0300 Subject: [PATCH 09/16] dependency management: joda-time unified only newer available version in the classpath left (2.3, 2.4, 2.8.1 -> 2.8.1) --- pom.xml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pom.xml b/pom.xml index 352fc13809..56cccd7d1c 100755 --- a/pom.xml +++ b/pom.xml @@ -68,6 +68,7 @@ 2.11.0 1.2 1.4 + 2.8.1 2.12.1 1.3.4 2.2.6 @@ -1325,6 +1326,11 @@ commons-csv ${commons-csv.version} + + joda-time + joda-time + ${joda-time.version} + com.fasterxml.jackson.core jackson-databind From 70c59af33ad1987d9bd86128bbc99bdb86ec732e Mon Sep 17 00:00:00 2001 From: Sergey Matvienko Date: Mon, 23 Aug 2021 13:50:06 +0300 Subject: [PATCH 10/16] dependency management: apache httpclient (4.5.2, 4.5.13 -> 4.5.13), httpcore (4.4.5, 4.4.13, 4.4.14 -> 4.4.14) --- pom.xml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/pom.xml b/pom.xml index 56cccd7d1c..19e1b376db 100755 --- a/pom.xml +++ b/pom.xml @@ -68,6 +68,8 @@ 2.11.0 1.2 1.4 + 4.5.13 + 4.4.14 2.8.1 2.12.1 1.3.4 @@ -1326,6 +1328,16 @@ commons-csv ${commons-csv.version} + + org.apache.httpcomponents + httpclient + ${apache-httpclient.version} + + + org.apache.httpcomponents + httpcore + ${apache-httpcore.version} + joda-time joda-time From 08736754c4682846e2b24023503fd17edd48ad06 Mon Sep 17 00:00:00 2001 From: Sergey Matvienko Date: Mon, 23 Aug 2021 14:00:52 +0300 Subject: [PATCH 11/16] dependency management: removed aws.sdk.version (already defined in the root pom.xml with the same version) --- rule-engine/rule-engine-components/pom.xml | 2 -- 1 file changed, 2 deletions(-) diff --git a/rule-engine/rule-engine-components/pom.xml b/rule-engine/rule-engine-components/pom.xml index ccd905f897..0a05e4967d 100644 --- a/rule-engine/rule-engine-components/pom.xml +++ b/rule-engine/rule-engine-components/pom.xml @@ -35,7 +35,6 @@ UTF-8 ${basedir}/../.. - 1.11.747 1.16.0 @@ -93,7 +92,6 @@ com.amazonaws aws-java-sdk-sns - ${aws.sdk.version} com.google.cloud From 9b7b0ac7bc04fabc8982517afff2a85989172405 Mon Sep 17 00:00:00 2001 From: Sergey Matvienko Date: Mon, 23 Aug 2021 14:08:58 +0300 Subject: [PATCH 12/16] dependency management: proto-google-common-protos (1.16.0, 1.17.0, 2.0.1 -> 2.0.1 /required by common used grpc 1.38.0/ ). Version management moved to the root --- pom.xml | 6 ++++++ rule-engine/rule-engine-components/pom.xml | 2 -- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 19e1b376db..f83c8fa52e 100755 --- a/pom.xml +++ b/pom.xml @@ -112,6 +112,7 @@ 1.27 1.11.747 1.105.0 + 2.1.0 3.2.0 1.5.0 1.4.3 @@ -1691,6 +1692,11 @@ google-cloud-pubsub ${pubsub.client.version} + + com.google.api.grpc + proto-google-common-protos + ${google.common.protos.version} + com.microsoft.azure azure-servicebus diff --git a/rule-engine/rule-engine-components/pom.xml b/rule-engine/rule-engine-components/pom.xml index 0a05e4967d..73615c1c1b 100644 --- a/rule-engine/rule-engine-components/pom.xml +++ b/rule-engine/rule-engine-components/pom.xml @@ -35,7 +35,6 @@ UTF-8 ${basedir}/../.. - 1.16.0 @@ -100,7 +99,6 @@ com.google.api.grpc proto-google-common-protos - ${google.common.protos.version} com.rabbitmq From 8dea07938ed8b15d22af3cfb959b4c230987bf49 Mon Sep 17 00:00:00 2001 From: Sergey Matvienko Date: Mon, 23 Aug 2021 16:28:06 +0300 Subject: [PATCH 13/16] msa-black-box-tests: httpclient dependency version inherited from the root pom.xml --- msa/black-box-tests/pom.xml | 2 -- 1 file changed, 2 deletions(-) diff --git a/msa/black-box-tests/pom.xml b/msa/black-box-tests/pom.xml index 6d4465f3c4..000fc23510 100644 --- a/msa/black-box-tests/pom.xml +++ b/msa/black-box-tests/pom.xml @@ -36,7 +36,6 @@ ${basedir}/../.. 1.11.4 1.10 - 4.5.13 @@ -57,7 +56,6 @@ org.apache.httpcomponents httpclient - ${httpclient.version} io.takari.junit From aefb7e4bb3767794790f2e548ee2366cd6035b46 Mon Sep 17 00:00:00 2001 From: Sergey Matvienko Date: Mon, 23 Aug 2021 18:59:54 +0300 Subject: [PATCH 14/16] added netty-tcnative-boringssl-static.version 2.0.41.Final along with netty-all to support SSL --- application/pom.xml | 8 ++++++++ common/edge-api/pom.xml | 5 +++++ common/transport/mqtt/pom.xml | 4 ++++ pom.xml | 6 ++++++ rule-engine/rule-engine-api/pom.xml | 5 +++++ 5 files changed, 28 insertions(+) diff --git a/application/pom.xml b/application/pom.xml index 4f24d4a5ad..4cb7f777cd 100644 --- a/application/pom.xml +++ b/application/pom.xml @@ -229,6 +229,14 @@ com.google.protobuf protobuf-java + + io.netty + netty-all + + + io.netty + netty-tcnative-boringssl-static + io.grpc grpc-netty-shaded diff --git a/common/edge-api/pom.xml b/common/edge-api/pom.xml index ed19be3480..1e685baaf8 100644 --- a/common/edge-api/pom.xml +++ b/common/edge-api/pom.xml @@ -81,6 +81,11 @@ netty-all provided + + io.netty + netty-tcnative-boringssl-static + provided + com.google.guava guava diff --git a/common/transport/mqtt/pom.xml b/common/transport/mqtt/pom.xml index e3e3d3bab7..fb2fffc777 100644 --- a/common/transport/mqtt/pom.xml +++ b/common/transport/mqtt/pom.xml @@ -44,6 +44,10 @@ io.netty netty-all + + io.netty + netty-tcnative-boringssl-static + org.springframework spring-context-support diff --git a/pom.xml b/pom.xml index f83c8fa52e..7c832dd800 100755 --- a/pom.xml +++ b/pom.xml @@ -86,6 +86,7 @@ 1.18.18 1.2.4 4.1.66.Final + 2.0.41.Final 1.7.0 4.8.0 2.19.1 @@ -1212,6 +1213,11 @@ netty-all ${netty.version} + + io.netty + netty-tcnative-boringssl-static + ${netty-tcnative-boringssl-static.version} + io.netty netty-buffer diff --git a/rule-engine/rule-engine-api/pom.xml b/rule-engine/rule-engine-api/pom.xml index 03fa42b606..bb7c8d1095 100644 --- a/rule-engine/rule-engine-api/pom.xml +++ b/rule-engine/rule-engine-api/pom.xml @@ -63,6 +63,11 @@ netty-all provided + + io.netty + netty-tcnative-boringssl-static + provided + com.google.guava guava From b020b051c55ad81e3c2f8d5dcd90e33cbfc43fcb Mon Sep 17 00:00:00 2001 From: Sergey Matvienko Date: Tue, 24 Aug 2021 19:00:23 +0300 Subject: [PATCH 15/16] tests: maven-surefire-plugin upgraded 3.0.0-M1 -> 3.0.0-M5 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 7c832dd800..33ecd7855a 100755 --- a/pom.xml +++ b/pom.xml @@ -651,7 +651,7 @@ org.apache.maven.plugins maven-surefire-plugin - 3.0.0-M1 + 3.0.0-M5 --illegal-access=permit From ecf049b5c6554c653b35bf0f03a07738dcd142be Mon Sep 17 00:00:00 2001 From: Sergey Matvienko Date: Wed, 25 Aug 2021 08:05:52 +0300 Subject: [PATCH 16/16] dependency: netty latest 4.1.67, netty-tcnative-boringssl 2.0.40 (according to the optional netty-transport dependency) --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 33ecd7855a..70e4dac72e 100755 --- a/pom.xml +++ b/pom.xml @@ -85,8 +85,8 @@ 1.38.0 1.18.18 1.2.4 - 4.1.66.Final - 2.0.41.Final + 4.1.67.Final + 2.0.40.Final 1.7.0 4.8.0 2.19.1