Browse Source
PROD-followup on the new-menu review: both #menuPopover template refs in UserMenuComponent's template resolved to only one popover instance, so menuPopover?.hide() inside the shared userMenuTpl closed only one of the two mutually-exclusive trigger buttons (they swap via lt-lg media query). Rename to #menuPopoverFull / #menuPopoverIcon and call .hide() on both from the shared Account/Logout menu items so whichever button is visible for the current breakpoint always closes cleanly. Also drop legacy commented-out selectors in menu-toggle.component.scss and tighten HomeService.toggleSideBar to EventEmitter<void>.pull/15888/head
3 changed files with 5 additions and 9 deletions
Loading…
Reference in new issue